feat(pkg/board): add is board set (#627)

Author: lucarin91

adbd.Dockerfile

@@ -1,16 +1,16 @@
 FROM debian:trixie
 
 RUN apt-get update \
-    && apt-get install -y --no-install-recommends adbd file openssh-server \
+    && apt-get install -y --no-install-recommends adbd file ssh sudo \
     && apt-get clean \
     && rm -rf /var/lib/apt/lists/*
 
-RUN useradd -m -s /bin/bash arduino && \
-    echo "arduino:arduino" | chpasswd
-RUN mkdir /home/arduino/ArduinoApps && \
-    chown arduino:arduino /home/arduino/ArduinoApps
+RUN useradd -m --create-home --shell /bin/bash --user-group --groups sudo arduino && \
+    echo "arduino:arduino" | chpasswd && \
+    mkdir /home/arduino/ArduinoApps && \
+    chown -R arduino:arduino /home/arduino/ArduinoApps
 
 WORKDIR /home/arduino
 EXPOSE 22
 
-CMD ["/bin/sh", "-c", "/usr/sbin/sshd -D & adbd"]
+CMD ["/bin/sh", "-c", "/usr/sbin/sshd -D & su arduino -c adbd"]

cmd/arduino-app-cli/board/board.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"path"
+	"strconv"
 
 	"github.com/spf13/cobra"
 
@@ -111,16 +112,28 @@ func newBoardListCmd() *cobra.Command {
 		RunE: func(cmd *cobra.Command, args []string) error {
 			boards := cmd.Context().Value(boardsListKey).([]board.Board)
 			for _, b := range boards {
-				var address string
+
+				var address, configured string
 				switch b.Protocol {
 				case board.SerialProtocol, board.LocalProtocol:
 					address = b.Serial
+
+					if conn, err := b.GetConnection(); err != nil {
+						return fmt.Errorf("failed to connect to board %s: %w", b.BoardName, err)
+					} else {
+						if s, err := board.IsUserPasswordSet(conn); err != nil {
+							return fmt.Errorf("failed to check if user password is set: %w", err)
+						} else {
+							configured = "- Configured: " + strconv.FormatBool(s)
+						}
+					}
 				case board.NetworkProtocol:
 					address = b.Address
 				default:
 					panic("unreachable")
 				}
-				feedback.Printf("%s (%s) - Connection: %s [%s]\n", b.BoardName, b.CustomName, b.Protocol, address)
+
+				feedback.Printf("%s (%s) - Connection: %s [%s] %s\n", b.BoardName, b.CustomName, b.Protocol, address, configured)
 			}
 			return nil
 		},

pkg/board/board.go

@@ -222,6 +222,25 @@ func GetCustomName(ctx context.Context, conn remote.RemoteConn) (string, error)
 	return string(bytes.TrimSpace(out)), nil
 }
 
+func IsUserPasswordSet(conn remote.RemoteShell) (bool, error) {
+	cmd := conn.GetCmd("chage", "-l", "arduino")
+
+	w, out, _, closer, err := cmd.Interactive()
+	if err != nil {
+		return false, fmt.Errorf("failed to check password: %w", err)
+	}
+	w.Close() // we don't need to write anything
+
+	isUserSet, err := remote.ParseChage(out)
+	if err != nil {
+		return false, err
+	}
+	if err := closer(); err != nil {
+		return false, err
+	}
+	return isUserSet, nil
+}
+
 func getSerial(conn remote.RemoteConn) (string, error) {
 	f, err := conn.ReadFile(SerialPath)
 	if err != nil {

pkg/board/remote/parser.go

@@ -0,0 +1,27 @@
+package remote
+
+import (
+	"bufio"
+	"fmt"
+	"io"
+	"strings"
+)
+
+func ParseChage(r io.Reader) (bool, error) {
+	scanner := bufio.NewScanner(r)
+	for scanner.Scan() {
+		line := scanner.Text()
+		if strings.HasPrefix(line, "Last password change") {
+			parts := strings.SplitN(line, ":", 2)
+			if len(parts) < 2 {
+				return false, fmt.Errorf("unexpected output from chage command: %s", line)
+			}
+			value := strings.TrimSpace(parts[1])
+			return value != "password must be changed", nil
+		}
+	}
+	if err := scanner.Err(); err != nil {
+		return false, err
+	}
+	return false, fmt.Errorf("unexpected output from chage command")
+}

pkg/board/remote/parser_test.go

@@ -0,0 +1,73 @@
+package remote
+
+import (
+	"strings"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestParseChage(t *testing.T) {
+	tests := []struct {
+		name    string
+		input   string
+		want    bool
+		wantErr bool
+	}{
+		{
+			name: "user set",
+			input: `
+Last password change                                    : Jun 30, 2025
+Password expires                                        : never
+Password inactive                                       : never
+Account expires                                         : never
+Minimum number of days between password change          : 0
+Maximum number of days between password change          : 99999
+Number of days of warning before password expires       : 7`,
+			want: true,
+		},
+		{
+			name: "user not set",
+			input: `
+Last password change                                    : password must be changed
+Password expires                                        : password must be changed
+Password inactive                                       : password must be changed
+Account expires                                         : never
+Minimum number of days between password change          : 0
+Maximum number of days between password change          : 99999
+Number of days of warning before password expires       : 7`,
+			want: false,
+		},
+		{
+			name: "malformed input",
+			input: `
+Last password change                                    - Jun 30, 2025
+Password expires                                        : never
+`,
+			wantErr: true,
+		},
+		{
+			name:    "empty input",
+			input:   "",
+			wantErr: true,
+		},
+		{
+			name:    "no relevant line",
+			input:   "something else",
+			wantErr: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := ParseChage(strings.NewReader(tt.input))
+			if tt.wantErr {
+				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+				assert.Equal(t, tt.want, got)
+			}
+		})
+	}
+}