feat(updater): update on windows using installer (#675)

dido18 · web-flow · commit 1fd7617103f9 · 2025-09-22T15:16:43.000+02:00
diff --git a/.github/workflows/go-test.yml b/.github/workflows/go-test.yml
@@ -8,6 +8,8 @@ on:
 
 env:
   GO_VERSION: "1.25.0"
+  GITHUB_TOKEN: ${{ secrets.ARDUINOBOT_TOKEN }}
+  GITHUB_USERNAME: ArduinoBot
 
 jobs:
   go-test-orchestrator:
@@ -57,6 +59,10 @@ jobs:
           version: 3.x
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Configure Git for private repo cloning
+        run: |
+          git config --global url."https://${{ env.GITHUB_USERNAME }}:${{ env.GITHUB_TOKEN }}@github.com".insteadOf "https://github.com"
+
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
diff --git a/.licenses/arduino-app-cli/NOTICE b/.licenses/arduino-app-cli/NOTICE
@@ -164868,7 +164868,7 @@ rights granted to you under this License for this implementation of Go
 shall terminate as of the date such litigation is filed.
 
 *****
-golang.org/x/sys/execabs@v0.35.0
+golang.org/x/sys/execabs@v0.36.0
 
 Copyright 2009 The Go Authors.
 
@@ -164924,7 +164924,7 @@ rights granted to you under this License for this implementation of Go
 shall terminate as of the date such litigation is filed.
 
 *****
-golang.org/x/sys/unix@v0.35.0
+golang.org/x/sys/unix@v0.36.0
 
 Copyright 2009 The Go Authors.
 
diff --git a/.licenses/arduino-app-cli/go/golang.org/x/sys/execabs.dep.yml b/.licenses/arduino-app-cli/go/golang.org/x/sys/execabs.dep.yml
@@ -1,13 +1,13 @@
 ---
 name: golang.org/x/sys/execabs
-version: v0.35.0
+version: v0.36.0
 type: go
 summary: Package execabs is a drop-in replacement for os/exec that requires PATH lookups
   to find absolute paths.
 homepage: https://pkg.go.dev/golang.org/x/sys/execabs
 license: other
 licenses:
-- sources: sys@v0.35.0/LICENSE
+- sources: sys@v0.36.0/LICENSE
   text: |
     Copyright 2009 The Go Authors.
 
@@ -36,7 +36,7 @@ licenses:
     THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-- sources: sys@v0.35.0/PATENTS
+- sources: sys@v0.36.0/PATENTS
   text: |
     Additional IP Rights Grant (Patents)
 
diff --git a/.licenses/arduino-app-cli/go/golang.org/x/sys/unix.dep.yml b/.licenses/arduino-app-cli/go/golang.org/x/sys/unix.dep.yml
@@ -1,12 +1,12 @@
 ---
 name: golang.org/x/sys/unix
-version: v0.35.0
+version: v0.36.0
 type: go
 summary: Package unix contains an interface to the low-level operating system primitives.
 homepage: https://pkg.go.dev/golang.org/x/sys/unix
 license: other
 licenses:
-- sources: sys@v0.35.0/LICENSE
+- sources: sys@v0.36.0/LICENSE
   text: |
     Copyright 2009 The Go Authors.
 
@@ -35,7 +35,7 @@ licenses:
     THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-- sources: sys@v0.35.0/PATENTS
+- sources: sys@v0.36.0/PATENTS
   text: |
     Additional IP Rights Grant (Patents)
 
diff --git a/.licenses/arduino-router/NOTICE b/.licenses/arduino-router/NOTICE
@@ -604,7 +604,7 @@ This software is released under the [BSD 3-clause license].
 [BSD 3-clause license]: https://github.com/bugst/go-serial/blob/master/LICENSE
 
 *****
-golang.org/x/sys/unix@v0.35.0
+golang.org/x/sys/unix@v0.36.0
 
 Copyright 2009 The Go Authors.
 
diff --git a/.licenses/arduino-router/go/golang.org/x/sys/unix.dep.yml b/.licenses/arduino-router/go/golang.org/x/sys/unix.dep.yml
@@ -1,12 +1,12 @@
 ---
 name: golang.org/x/sys/unix
-version: v0.35.0
+version: v0.36.0
 type: go
 summary: Package unix contains an interface to the low-level operating system primitives.
 homepage: https://pkg.go.dev/golang.org/x/sys/unix
 license: other
 licenses:
-- sources: sys@v0.35.0/LICENSE
+- sources: sys@v0.36.0/LICENSE
   text: |
     Copyright 2009 The Go Authors.
 
@@ -35,7 +35,7 @@ licenses:
     THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
     (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
     OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-- sources: sys@v0.35.0/PATENTS
+- sources: sys@v0.36.0/PATENTS
   text: |
     Additional IP Rights Grant (Patents)
 
diff --git a/debian/arduino-app-cli/usr/share/doc/arduino-app-cli/copyright b/debian/arduino-app-cli/usr/share/doc/arduino-app-cli/copyright
@@ -164883,7 +164883,7 @@ rights granted to you under this License for this implementation of Go
 shall terminate as of the date such litigation is filed.
 
 *****
-golang.org/x/sys/execabs@v0.35.0
+golang.org/x/sys/execabs@v0.36.0
 
 Copyright 2009 The Go Authors.
 
@@ -164939,7 +164939,7 @@ rights granted to you under this License for this implementation of Go
 shall terminate as of the date such litigation is filed.
 
 *****
-golang.org/x/sys/unix@v0.35.0
+golang.org/x/sys/unix@v0.36.0
 
 Copyright 2009 The Go Authors.
 
diff --git a/debian/arduino-router/usr/share/doc/arduino-router/copyright b/debian/arduino-router/usr/share/doc/arduino-router/copyright
@@ -619,7 +619,7 @@ This software is released under the [BSD 3-clause license].
 [BSD 3-clause license]: https://github.com/bugst/go-serial/blob/master/LICENSE
 
 *****
-golang.org/x/sys/unix@v0.35.0
+golang.org/x/sys/unix@v0.36.0
 
 Copyright 2009 The Go Authors.
 
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/bcmi-labs/orchestrator
 
-go 1.25
+go 1.25.1
 
 // This is needed because compose introduce a regression in https://github.com/docker/compose/pull/13062
 // They changed the wait monitor ends. Because we're using the Logs() method, we are no longer able to make it
@@ -17,6 +17,7 @@ require (
 	github.com/Andrew-M-C/go.emoji v1.1.4
 	github.com/arduino/arduino-cli v1.3.1
 	github.com/arduino/go-paths-helper v1.14.0
+	github.com/arduino/go-windows-runas v0.0.0-20250918132957-e681a11c5bd8
 	github.com/codeclysm/extract/v4 v4.0.0
 	github.com/compose-spec/compose-go/v2 v2.8.1
 	github.com/containerd/errdefs v1.0.0
@@ -272,7 +273,7 @@ require (
 	golang.org/x/net v0.42.0 // indirect
 	golang.org/x/oauth2 v0.30.0 // indirect
 	golang.org/x/sync v0.16.0 // indirect
-	golang.org/x/sys v0.35.0 // indirect
+	golang.org/x/sys v0.36.0 // indirect
 	golang.org/x/time v0.11.0 // indirect
 	golang.org/x/tools v0.35.0 // indirect
 	google.golang.org/genproto/googleapis/api v0.0.0-20250528174236-200df99c418a // indirect
diff --git a/go.sum b/go.sum
@@ -93,6 +93,8 @@ github.com/arduino/go-timeutils v0.0.0-20171220113728-d1dd9e313b1b h1:9hDi4F2st6
 github.com/arduino/go-timeutils v0.0.0-20171220113728-d1dd9e313b1b/go.mod h1:uwGy5PpN4lqW97FiLnbcx+xx8jly5YuPMJWfVwwjJiQ=
 github.com/arduino/go-win32-utils v1.0.0 h1:/cXB86sOJxOsCHP7sQmXGLkdValwJt56mIwOHYxgQjQ=
 github.com/arduino/go-win32-utils v1.0.0/go.mod h1:0jqM7doGEAs6DaJCxxhLBUDS5OawrqF48HqXkcEie/Q=
+github.com/arduino/go-windows-runas v0.0.0-20250918132957-e681a11c5bd8 h1:bJSXX/6PkMnriAi3p4FL7+DEZEc19PbLD4jcLEcLO8w=
+github.com/arduino/go-windows-runas v0.0.0-20250918132957-e681a11c5bd8/go.mod h1:cyVCsn7S6M3H1Nl94YOEu14ZJU+DYiPTDeYQcCMVWqk=
 github.com/arduino/pluggable-discovery-protocol-handler/v2 v2.2.1 h1:Fw8zKj1b/FkcQrWgN7aBw3ubSxpKIUtdANLXvd1Qdzw=
 github.com/arduino/pluggable-discovery-protocol-handler/v2 v2.2.1/go.mod h1:1dgblsmK2iBx3L5iNTyRIokeaxbTLUrYiUbHBK6yC3Y=
 github.com/armon/circbuf v0.0.0-20150827004946-bbbad097214e/go.mod h1:3U/XgcO3hCbHZ8TKRvWD2dDTCfh9M9ya+I9JpbB7O8o=
@@ -1160,8 +1162,8 @@ golang.org/x/sys v0.0.0-20220715151400-c0bba94af5f8/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
-golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
+golang.org/x/sys v0.36.0 h1:KVRy2GtZBrk1cBYA7MKu5bEZFxQk4NIDV6RLVcC8o0k=
+golang.org/x/sys v0.36.0/go.mod h1:OgkHotnGiDImocRcuBABYBEXf8A9a87e/uXjp9XT3ks=
 golang.org/x/term v0.0.0-20201117132131-f5c789dd3221/go.mod h1:Nr5EML6q2oocZ2LXRh80K7BxOlk5/8JxuGnuhpl+muw=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
diff --git a/pkg/autoupdater/updater/apply_default.go b/pkg/autoupdater/updater/apply_default.go
@@ -1,4 +1,4 @@
-//go:build !darwin
+//go:build !darwin && !windows
 
 package updater
 
@@ -167,9 +167,5 @@ func apply(targetPath string, current releaser.Version, client *releaser.Client,
 
 // isExecutable checks if a file is executable.
 func isExecutable(info fs.FileInfo) bool {
-	if runtime.GOOS == "windows" {
-		return filepath.Ext(info.Name()) == ".exe"
-	} else {
-		return info.Mode()&0111 != 0
-	}
+	return info.Mode()&0111 != 0
 }
diff --git a/pkg/autoupdater/updater/apply_windows.go b/pkg/autoupdater/updater/apply_windows.go
@@ -0,0 +1,61 @@
+//go:build windows
+
+package updater
+
+import (
+	"bytes"
+	"crypto/sha256"
+	"fmt"
+	"io"
+	"log/slog"
+	"os"
+	"runtime"
+
+	"github.com/bcmi-labs/orchestrator/pkg/autoupdater/releaser"
+)
+
+// NOTE: On windows, the 'targetpath' is ignored (see the first argument) because is not replaced with the new version but
+// the update is based on an installer executable. So, instead of replacing the binary in place, the installer is downloaded and run (see the exec_windows.go)
+func apply(_ string, current releaser.Version, client *releaser.Client, upgradeConfirmCb UpgradeConfirmCB) (string, error) {
+	plat := releaser.NewPlatform(runtime.GOOS, runtime.GOARCH)
+	slog.Info("Checking for updates", "platform", plat)
+	manifest, err := client.GetLatestVersion(plat)
+	if err != nil {
+		return "", err
+	}
+	if manifest.Version == current {
+		// No updates available, bye bye
+		return "", nil
+	}
+
+	if upgradeConfirmCb != nil && !upgradeConfirmCb(current, manifest.Version) {
+		slog.Info("Update not confirmed by user, exiting without applying update")
+		return "", nil
+	}
+
+	// Download the update
+	slog.Info("Downloading update", "version", manifest.Version, "platform", plat)
+	download, err := client.FetchRelease(manifest)
+	if err != nil {
+		return "", fmt.Errorf("could not fetch update: %w", err)
+	}
+	defer download.Close()
+
+	tmpRelease, err := os.CreateTemp("", "update-*.exe")
+	if err != nil {
+		return "", fmt.Errorf("could not create temp file: %w", err)
+	}
+
+	sha := sha256.New()
+	if _, err := io.Copy(io.MultiWriter(sha, tmpRelease), download); err != nil {
+		return "", err
+	}
+	tmpRelease.Close()
+
+	// Check the hash
+	if s := sha.Sum(nil); !bytes.Equal(s, manifest.Sha256) {
+		return "", fmt.Errorf("bad hash: %x (expected %x)", s, manifest.Sha256)
+	}
+
+	return tmpRelease.Name(), nil
+}
diff --git a/pkg/autoupdater/updater/exec_default.go b/pkg/autoupdater/updater/exec_default.go
@@ -1,4 +1,4 @@
-//go:build !darwin
+//go:build !darwin && !windows
 
 package updater
 
diff --git a/pkg/autoupdater/updater/exec_windows.go b/pkg/autoupdater/updater/exec_windows.go
@@ -0,0 +1,20 @@
+//go:build windows
+
+package updater
+
+import (
+	"fmt"
+
+	runas "github.com/arduino/go-windows-runas"
+)
+
+func execApp(path string) error {
+	exitCode, err := runas.RunElevated(path, "", []string{}, false)
+	if err != nil {
+		return fmt.Errorf("could not run installer: %w", err)
+	}
+	if exitCode != 0 {
+		return fmt.Errorf("installer exited with code %d", exitCode)
+	}
+	return nil
+}
diff --git a/pkg/autoupdater/updater/updater_test.go b/pkg/autoupdater/updater/updater_test.go
@@ -2,6 +2,7 @@ package updater
 
 import (
 	"net/http"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -40,6 +41,9 @@ func TestCheckForUpdates(t *testing.T) {
 	})
 
 	t.Run("update ok but restart failed", func(t *testing.T) {
+		if runtime.GOOS == "windows" {
+			t.Skip("cannot test it on windows because it opens installer executable")
+		}
 		tmp := CreateTmpExecutable(t, "a-bad-exec-format", []byte{0xDE, 0xAD, 0xBE, 0xEF})
 		defer tmp.cleanup()
 		client := CreateRelease(t, "2.0.0", []byte{0x01, 0x02, 0x03, 0x04, 0x05, 0x06})
