orchestrator: fix provision in case the container need to be pulled (#468)

alessio-perugini · web-flow · commit 5ff7b320309e · 2025-07-25T14:57:44.000+02:00
diff --git a/internal/orchestrator/provision.go b/internal/orchestrator/provision.go
@@ -142,8 +142,12 @@ func dynamicProvisioning(
 			if err := pullBasePythonContainer(ctx, pythonImage); err != nil {
 				return fmt.Errorf("provisioning failed to pull base image: %w", err)
 			}
+			// Now that we have pulled the container we recreate it
+			resp, err = docker.ContainerCreate(ctx, containerCfg, containerHostCfg, nil, nil, "")
+		}
+		if err != nil {
+			return fmt.Errorf("provisiong failed to create container: %w", err)
 		}
-		return fmt.Errorf("provisiong failed to create container: %w", err)
 	}
 
 	slog.Debug("provisioning container created", slog.String("container_id", resp.ID))

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,12 @@ func dynamicProvisioning(`
`142`	`142`	`if err := pullBasePythonContainer(ctx, pythonImage); err != nil {`
`143`	`143`	`return fmt.Errorf("provisioning failed to pull base image: %w", err)`
`144`	`144`	`}`
	`145`	`+ // Now that we have pulled the container we recreate it`
	`146`	`+ resp, err = docker.ContainerCreate(ctx, containerCfg, containerHostCfg, nil, nil, "")`
	`147`	`+ }`
	`148`	`+ if err != nil {`
	`149`	`+ return fmt.Errorf("provisiong failed to create container: %w", err)`
`145`	`150`	`}`
`146`		`- return fmt.Errorf("provisiong failed to create container: %w", err)`
`147`	`151`	`}`
`148`	`152`
`149`	`153`	`slog.Debug("provisioning container created", slog.String("container_id", resp.ID))`