orchestrator: change default apps and data folder (#462)

Author: alessio-perugini

.gitignore

@@ -34,4 +34,4 @@ build/
 /arduino-app-cli
 /apps
 # temporary staging directories
-/debian/orchestrator/home/arduino/.arduino-app-cli/examples
+/debian/orchestrator/home

README.md

@@ -248,7 +248,7 @@ NOTE: currently the mac-os is not supported since the `github.com/arduino/arduin
 
 ### Orchestrator configurations
 
-The orchestrator will write apps in `~/arduino-apps` folder, and examples in `~/.arduino-app-cli/examples`.
+The orchestrator will write apps in `~/arduino-apps` folder, and examples in `~/.config/arduino-app-cli/examples`.
 To override the path provide the following flags:
 
 - `ARDUINO_APP_CLI__APPS_DIR`

Taskfile.yml

@@ -107,7 +107,7 @@ tasks:
           set -e
           echo "Runner version set as: {{ .EXAMPLE_VERSION }}"
           TMP_PATH="$(mktemp -d)"
-          DEST_PATH="debian/orchestrator/home/arduino/.arduino-app-cli/"
+          DEST_PATH="debian/orchestrator/home/arduino/.config/arduino-app-cli/"
           echo "Cloning bcmi-labs/app-bricks-example into temporary directory ${TMP_PATH}..."
           git clone --depth 1 --branch "{{ .EXAMPLE_VERSION }}" https://github.com/bcmi-labs/app-bricks-example "${TMP_PATH}"
           rm -rf "${DEST_PATH}"

debian/orchestrator/etc/systemd/system/arduino-orchestrator.service

@@ -8,8 +8,6 @@ Requires=docker.service arduino-router.service
 ExecStart=/usr/bin/arduino-app-cli daemon --port 8800
 User=arduino
 Group=arduino
-Environment="ARDUINO_APP_CLI__APPS_DIR=/home/arduino/arduino-apps"
-Environment="ARDUINO_APP_CLI__DATA_DIR=/home/arduino/.arduino-app-cli"
 Environment="ARDUINO_APP_CLI__LOG_LEVEL=ERROR"
 Environment="ARDUINO_ROUTER_SOCKET=/var/run/arduino-router.sock"
 StandardOutput=journal

internal/orchestrator/config.go

@@ -32,11 +32,11 @@ func NewOrchestratorConfigFromEnv() (*OrchestratorConfig, error) {
 
 	dataDir := paths.New(os.Getenv("ARDUINO_APP_CLI__DATA_DIR"))
 	if dataDir == nil {
-		home, err := os.UserHomeDir()
+		xdgConfig, err := os.UserConfigDir()
 		if err != nil {
 			return nil, err
 		}
-		dataDir = paths.New(home).Join(".arduino-app-cli")
+		dataDir = paths.New(xdgConfig).Join("arduino-app-cli")
 	}
 	if !dataDir.IsAbs() {
 		wd, err := paths.Getwd()