[DynamoDB] Add waiter for table not exists after delete (#338)

* Add waiter for table delete

* WIP rework waiter generator & exception condition

* Response::resolve() always throw exceptions, that can be caught

* Fix error waiter for sqs

* Fallback to full __type error code, like official sdk

* Waiter::resolve() ignores http exceptions

Author: GromNaN

src/DynamoDbClient.php

@@ -24,6 +24,7 @@
 use AsyncAws\DynamoDb\Result\QueryOutput;
 use AsyncAws\DynamoDb\Result\ScanOutput;
 use AsyncAws\DynamoDb\Result\TableExistsWaiter;
+use AsyncAws\DynamoDb\Result\TableNotExistsWaiter;
 use AsyncAws\DynamoDb\Result\UpdateItemOutput;
 use AsyncAws\DynamoDb\Result\UpdateTableOutput;
 
@@ -273,6 +274,23 @@ public function tableExists($input): TableExistsWaiter
         return new TableExistsWaiter($response, $this, $input);
     }
 
+    /**
+     * Check status of operation describeTable.
+     *
+     * @see describeTable
+     *
+     * @param array{
+     *   TableName: string,
+     * }|DescribeTableInput $input
+     */
+    public function tableNotExists($input): TableNotExistsWaiter
+    {
+        $input = DescribeTableInput::create($input);
+        $response = $this->getResponse($input->request());
+
+        return new TableNotExistsWaiter($response, $this, $input);
+    }
+
     /**
      * Edits an existing item's attributes, or adds a new item to the table if it does not already exist. You can put,
      * delete, or add attribute values. You can also perform a conditional update on an existing item (insert a new

src/Result/TableExistsWaiter.php

@@ -19,7 +19,7 @@ protected function extractState(Response $response, ?HttpException $exception):
             return self::STATE_SUCCESS;
         }
 
-        if (null !== $exception) {
+        if (null !== $exception && 'ResourceNotFoundException' === $exception->getAwsCode()) {
             return self::STATE_PENDING;
         }
 

src/Result/TableNotExistsWaiter.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace AsyncAws\DynamoDb\Result;
+
+use AsyncAws\Core\Exception\Http\HttpException;
+use AsyncAws\Core\Response;
+use AsyncAws\Core\Waiter;
+use AsyncAws\DynamoDb\DynamoDbClient;
+use AsyncAws\DynamoDb\Input\DescribeTableInput;
+
+class TableNotExistsWaiter extends Waiter
+{
+    protected const WAIT_TIMEOUT = 500.0;
+    protected const WAIT_DELAY = 20.0;
+
+    protected function extractState(Response $response, ?HttpException $exception): string
+    {
+        if (null !== $exception && 'ResourceNotFoundException' === $exception->getAwsCode()) {
+            return self::STATE_SUCCESS;
+        }
+
+        /** @psalm-suppress TypeDoesNotContainType */
+        return null === $exception ? self::STATE_PENDING : self::STATE_FAILURE;
+    }
+
+    protected function refreshState(): Waiter
+    {
+        if (!$this->awsClient instanceof DynamoDbClient) {
+            throw new \InvalidArgumentException('missing client injected in waiter result');
+        }
+        if (!$this->input instanceof DescribeTableInput) {
+            throw new \InvalidArgumentException('missing last request injected in waiter result');
+        }
+
+        return $this->awsClient->TableNotExists($this->input);
+    }
+}

tests/Unit/DynamoDbClientTest.php

@@ -26,6 +26,8 @@
 use AsyncAws\DynamoDb\Result\PutItemOutput;
 use AsyncAws\DynamoDb\Result\QueryOutput;
 use AsyncAws\DynamoDb\Result\ScanOutput;
+use AsyncAws\DynamoDb\Result\TableExistsWaiter;
+use AsyncAws\DynamoDb\Result\TableNotExistsWaiter;
 use AsyncAws\DynamoDb\Result\UpdateItemOutput;
 use AsyncAws\DynamoDb\Result\UpdateTableOutput;
 use AsyncAws\DynamoDb\ValueObject\KeySchemaElement;
@@ -160,6 +162,34 @@ public function testScan(): void
         self::assertFalse($result->info()['resolved']);
     }
 
+    public function testTableExists(): void
+    {
+        $client = new DynamoDbClient([], new NullProvider(), new MockHttpClient());
+
+        $input = new DescribeTableInput([
+            'TableName' => 'Foobar',
+
+        ]);
+        $result = $client->tableExists($input);
+
+        self::assertInstanceOf(TableExistsWaiter::class, $result);
+        self::assertFalse($result->info()['resolved']);
+    }
+
+    public function testTableNotExists(): void
+    {
+        $client = new DynamoDbClient([], new NullProvider(), new MockHttpClient());
+
+        $input = new DescribeTableInput([
+            'TableName' => 'Foobar',
+
+        ]);
+        $result = $client->tableNotExists($input);
+
+        self::assertInstanceOf(TableNotExistsWaiter::class, $result);
+        self::assertFalse($result->info()['resolved']);
+    }
+
     public function testUpdateItem(): void
     {
         $client = new DynamoDbClient([], new NullProvider(), new MockHttpClient());