Fix loop->stop() test and incomplete/skipped marking

bwoebi · bwoebi · commit e2f11010c0a3 · 2016-05-27T04:08:34.000+02:00
diff --git a/src/Test.php b/src/Test.php
@@ -33,10 +33,7 @@ function testEmptyLoop() {
 		$this->loop->run();
 	}
 	
-	/**
-	 * @expectedException \Exception
-	 */
-	function testStopThrowsIfNotCurrentlyRunning() {
+	function testStopWorksEvenIfNotCurrentlyRunning() {
 		$this->loop->stop();
 	}
 
@@ -703,7 +700,7 @@ function testLoopException() {
 	 */
 	function testOnSignalWatcher() {
 		if (!\extension_loaded("posix")) {
-			$this->markTestIncomplete("ext/posix required to test signal handlers");
+			$this->markTestSkipped("ext/posix required to test signal handlers");
 		}
 
 		$this->expectOutputString("caught SIGUSR1");

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,7 @@ function testEmptyLoop() {`
`33`	`33`	`$this->loop->run();`
`34`	`34`	`}`
`35`	`35`
`36`		`- /**`
`37`		`- * @expectedException \Exception`
`38`		`- */`
`39`		`- function testStopThrowsIfNotCurrentlyRunning() {`
	`36`	`+ function testStopWorksEvenIfNotCurrentlyRunning() {`
`40`	`37`	`$this->loop->stop();`
`41`	`38`	`}`
`42`	`39`
`@@ -703,7 +700,7 @@ function testLoopException() {`
`703`	`700`	`*/`
`704`	`701`	`function testOnSignalWatcher() {`
`705`	`702`	`if (!\extension_loaded("posix")) {`
`706`		`- $this->markTestIncomplete("ext/posix required to test signal handlers");`
	`703`	`+ $this->markTestSkipped("ext/posix required to test signal handlers");`
`707`	`704`	`}`
`708`	`705`
`709`	`706`	`$this->expectOutputString("caught SIGUSR1");`