Skip to content

Commit 3a0d16c

Browse files
committed
Stricter lint, fix lint errors
1 parent c13696a commit 3a0d16c

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

.eslintrc.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@ module.exports = {
2424
jsx: true, // Allows for the parsing of JSX
2525
arrowFunctions: true,
2626
},
27+
// Next two lines enable deeper TS type checking
28+
// https://typescript-eslint.io/docs/linting/typed-linting/
29+
tsconfigRootDir: __dirname,
30+
project: [
31+
'lib/tsconfig.json',
32+
'react/tsconfig.json',
33+
'data-browser/tsconfig.json',
34+
],
2735
},
2836
plugins: ['react', '@typescript-eslint', 'prettier', 'react-hooks', 'jsx-a11y'],
2937
settings: {

data-browser/src/components/CQWrapper.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {
55
StyledComponent,
66
} from 'styled-components';
77

8+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
89
type CT = React.FunctionComponent<any>;
910

1011
type SComp<

react/src/hooks.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ export function useValue(
300300
// Value hasn't been set in state yet, so get the value
301301
let value: JSONValue = undefined;
302302

303-
// Try to actually get the value, log any errorr
303+
// Try to actually get the value, log any error
304304
try {
305305
value = resource.get(propertyURL);
306306

tsconfig.build.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@
1818
"skipLibCheck": true,
1919
// used in monorepo ts projects to set precendence in compiling tsc things https://dev.to/t7yang/typescript-yarn-workspace-monorepo-1pao
2020
"composite": true,
21-
"strictNullChecks": true
21+
"strictNullChecks": true,
22+
// Todo: enable this
23+
// "noImplicitAny": true
2224
},
2325
"exclude": [
2426
"node_modules",

0 commit comments

Comments
 (0)