Skip to content

Commit 4165667

Browse files
committed
Fix e2e test
1 parent 08ace23 commit 4165667

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

data-browser/tests/e2e.spec.ts

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,10 @@ test.describe('data-browser', async () => {
128128
await signIn(page);
129129
await newDrive(page);
130130

131-
// Create folder called 'Not This folder'
131+
// Create folder called 1
132132
await page.locator('[data-test="sidebar-new-resource"]').click();
133133
await page.locator('button:has-text("folder")').click();
134-
await setTitle(page, 'Not This Folder');
134+
await setTitle(page, 'Salad folder');
135135

136136
// Create document called 'Avocado Salad'
137137
await page.locator('button:has-text("New Resource")').click();
@@ -143,9 +143,9 @@ test.describe('data-browser', async () => {
143143

144144
await page.locator('[data-test="sidebar-new-resource"]').click();
145145

146-
// Create folder called 'This folder'
146+
// Create folder called 'Cake folder'
147147
await page.locator('button:has-text("folder")').click();
148-
await setTitle(page, 'This Folder');
148+
await setTitle(page, 'Cake Folder');
149149

150150
// Create document called 'Avocado Salad'
151151
await page.locator('button:has-text("New Resource")').click();
@@ -155,15 +155,16 @@ test.describe('data-browser', async () => {
155155
await page.waitForResponse(`${serverUrl}/commit`);
156156
await editTitle('Avocado Cake', page);
157157

158-
await clickSidebarItem('This Folder', page);
159-
160-
// Set search scope to 'This folder'
158+
await clickSidebarItem('Cake Folder', page);
161159

160+
// Set search scope to 'Cake folder'
162161
await page.waitForTimeout(REBUILD_INDEX_TIME);
163-
await page.locator('button[title="Search in This Folder"]').click();
162+
await page.locator('button[title="Search in Cake Folder"]').click();
164163
// Search for 'Avocado'
165164
await page.locator('[data-test="address-bar"]').type('Avocado');
166-
await expect(page.locator('h2:text("Avocado Cake")')).toBeVisible();
165+
// I don't like the `.first` here, but for some reason there is one frame where
166+
// Multiple hits render, which fails the tests.
167+
await expect(page.locator('h2:text("Avocado Cake")').first()).toBeVisible();
167168
await expect(page.locator('h2:text("Avocado Salad")')).not.toBeVisible();
168169

169170
// Remove scope
@@ -183,7 +184,7 @@ test.describe('data-browser', async () => {
183184
'[data-test="sort-https://atomicdata.dev/properties/description"]',
184185
);
185186
// These values can change as new Properties are added to atomicdata.dev
186-
const firstPageText = 'text=A base64';
187+
const firstPageText = 'text=A base64 serialized JSON object';
187188
const secondPageText = 'text=include-nested';
188189
await expect(page.locator(firstPageText)).toBeVisible();
189190
await page.click('[data-test="next-page"]');

0 commit comments

Comments
 (0)