Skip to content

Commit 8d16c1a

Browse files
authored
Deprecate Node6 Execution Handlers (#454)
Updating Execution Handlers from `Node` -> `Node10`. * Updated esbuild to output Node10 code * Updated most dependencies. Notably leaving out `tfx-cli` since this is a crucial dpeloyment, and we use `tfx-cli` primarily for deployments. * Tasks now require `minimumAgentVersion` of `2.144.0`. This is the first Minimum Agent Version that supports Node10. * Specifically, this will force hosted agents to update unless autoupdates have been opted-out of. See: #453
1 parent d76ee36 commit 8d16c1a

File tree

27 files changed

+4176
-6483
lines changed

27 files changed

+4176
-6483
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type": "Breaking Change",
3+
"description": "Bumped Minimum Azure Pipelines Agent version to 2.144.0 due to Node6 Execution Handler Deprecation: see https://github.com/aws/aws-toolkit-azure-devops/issues/453"
4+
}

build-scripts/generateRunners.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,10 @@ async function run(): Promise<${returnType === undefined ? 'void' : returnType}>
7676
}
7777
`
7878

79+
// TODO: Optionally output "TaskResult.SucceededWithIssues" depending on result?
7980
const run = `
8081
run().then((result) => {
81-
const tooLow = warnIfBuildAgentTooLow()
82-
tl.setResult(tooLow ? tl.TaskResult.SucceededWithIssues : tl.TaskResult.Succeeded, ${
83-
successResult === undefined ? "''" : successResult
84-
})
82+
tl.setResult(tl.TaskResult.Succeeded, '')
8583
}).catch((error) => {
8684
tl.setResult(tl.TaskResult.Failed, \`\${error}\`)
8785
})

build-scripts/packageExtension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ function packagePlugin(options: CommandLineOptions) {
120120
entryPoints: [inputFilename],
121121
bundle: true,
122122
platform: 'node',
123-
target: ['node6'],
123+
target: ['node10'],
124124
minify: true,
125125
outfile: `${taskPackageFolder}/${taskName}.js`
126126
})

package-lock.json

Lines changed: 4117 additions & 6427 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"@types/adm-zip": "^0.4.33",
4141
"@types/base-64": "^0.1.3",
4242
"@types/fs-extra": "^8.0.0",
43-
"@types/jest": "^26.0.19",
43+
"@types/jest": "^27.4.1",
4444
"@types/js-yaml": "^3.12.1",
4545
"@types/json-query": "^2.2.0",
4646
"@types/mime-types": "^2.1.0",
@@ -54,28 +54,28 @@
5454
"@types/validator": "^13.1.2",
5555
"@typescript-eslint/eslint-plugin": "^4.12.0",
5656
"@typescript-eslint/parser": "^4.12.0",
57-
"esbuild": "^0.8.54",
58-
"eslint": "^7.21.0",
57+
"esbuild": "^0.14.26",
58+
"eslint": "^7.32.0",
5959
"eslint-config-prettier": "^7.1.0",
6060
"eslint-plugin-header": "^3.1.0",
6161
"eslint-plugin-no-null": "^1.0.2",
6262
"fs-extra": "^8.0.0",
63-
"husky": "^4.2.3",
64-
"jest": "^26.6.3",
65-
"jest-junit": "^12.0.0",
63+
"husky": "^4.3.8",
64+
"jest": "^27.5.1",
65+
"jest-junit": "^13.0.0",
6666
"json-query": "^2.2.2",
6767
"prettier": "1.19.1",
6868
"pretty-quick": "^2.0.1",
6969
"readline-sync": "^1.4.10",
7070
"sync-request": "^6.1.0",
7171
"tfx-cli": "^0.9.2",
7272
"tmp": "^0.2.1",
73-
"ts-jest": "^26.4.4",
73+
"ts-jest": "^27.1.3",
7474
"ts-loader": "^6.1.0",
7575
"ts-node": "^8.4.1",
7676
"typescript": "^4.2.2",
7777
"uuid": "^3.3.3",
78-
"validator": "^13.5.2"
78+
"validator": "^13.7.0"
7979
},
8080
"dependencies": {
8181
"@typescript-eslint/typescript-estree": "^4.17.0",
@@ -87,7 +87,7 @@
8787
"js-yaml": "^3.13.1",
8888
"mime-types": "^2.1.30",
8989
"semver": "^7.3.4",
90-
"shelljs": "^0.8.3"
90+
"shelljs": "^0.8.5"
9191
},
9292
"jest": {
9393
"coverageDirectory": "./coverage/",

src/tasks/AWSCLI/task.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"category": "Deploy",
99
"visibility": ["Build", "Release"],
1010
"demands": [],
11-
"minimumAgentVersion": "1.91.0",
11+
"minimumAgentVersion": "2.144.0",
1212
"instanceNameFormat": "AWS CLI: $(awsCommand)",
1313
"showEnvironmentVariables": true,
1414
"groups": [
@@ -73,7 +73,7 @@
7373
}
7474
],
7575
"execution": {
76-
"Node": {
76+
"Node10": {
7777
"target": "AWSCLI.js",
7878
"argumentFormat": ""
7979
}

src/tasks/AWSPowerShellModuleScript/task.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"category": "Deploy",
99
"visibility": ["Build", "Release"],
1010
"demands": ["DotNetFramework"],
11-
"minimumAgentVersion": "1.91.0",
11+
"minimumAgentVersion": "2.144.0",
1212
"instanceNameFormat": "AWS Tools for Windows PowerShell Script: $(scriptFile)",
1313
"showEnvironmentVariables": true,
1414
"groups": [

src/tasks/AWSShellScript/task.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"demands": ["sh"],
1111
"instanceNameFormat": "AWS Shell Script",
1212
"showEnvironmentVariables": true,
13+
"minimumAgentVersion": "2.144.0",
1314
"groups": [
1415
{
1516
"name": "advanced",
@@ -111,7 +112,7 @@
111112
}
112113
],
113114
"execution": {
114-
"Node": {
115+
"Node10": {
115116
"target": "AWSShellScript.js",
116117
"argumentFormat": ""
117118
}

src/tasks/BeanstalkCreateApplicationVersion/task.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"category": "Deploy",
99
"visibility": ["Build", "Release"],
1010
"demands": [],
11-
"minimumAgentVersion": "1.91.0",
11+
"minimumAgentVersion": "2.144.0",
1212
"instanceNameFormat": "Create Elastic Beanstalk Revision: $(applicationName)",
1313
"groups": [
1414
{
@@ -140,7 +140,7 @@
140140
}
141141
],
142142
"execution": {
143-
"Node": {
143+
"Node10": {
144144
"target": "BeanstalkCreateApplicationVersion.js",
145145
"argumentFormat": ""
146146
}

src/tasks/BeanstalkDeployApplication/task.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"category": "Deploy",
99
"visibility": ["Build", "Release"],
1010
"demands": [],
11-
"minimumAgentVersion": "1.91.0",
11+
"minimumAgentVersion": "2.144.0",
1212
"instanceNameFormat": "Deploy to Elastic Beanstalk: $(applicationName)",
1313
"groups": [
1414
{
@@ -157,7 +157,7 @@
157157
}
158158
],
159159
"execution": {
160-
"Node": {
160+
"Node10": {
161161
"target": "BeanstalkDeployApplication.js",
162162
"argumentFormat": ""
163163
}

0 commit comments

Comments
 (0)