chore: replace deprecated String.prototype.substr() (#458)

CommanderRoot · web-flow · commit b2a1fea48659 · 2022-04-01T11:03:11.000-07:00
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher &lt;rootcommander@gmail.com&gt;
diff --git a/src/tasks/S3Upload/TaskOperations.ts b/src/tasks/S3Upload/TaskOperations.ts
@@ -148,7 +148,7 @@ export class TaskOperations {
         for (const matchedFile of matchedFiles) {
             let relativePath = matchedFile.substring(this.taskParameters.sourceFolder.length)
             if (relativePath.startsWith(path.sep)) {
-                relativePath = relativePath.substr(1)
+                relativePath = relativePath.slice(1)
             }
             let targetPath = relativePath
 

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ export class TaskOperations {`
`148`	`148`	`for (const matchedFile of matchedFiles) {`
`149`	`149`	`let relativePath = matchedFile.substring(this.taskParameters.sourceFolder.length)`
`150`	`150`	`if (relativePath.startsWith(path.sep)) {`
`151`		`- relativePath = relativePath.substr(1)`
	`151`	`+ relativePath = relativePath.slice(1)`
`152`	`152`	`}`
`153`	`153`	`let targetPath = relativePath`
`154`	`154`