Skip to content

Commit fd1cc3f

Browse files
committed
bug fix for js tags
1 parent 973095b commit fd1cc3f

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

sagemaker-train/src/sagemaker/train/evaluate/execution.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def _get_or_create_pipeline(
167167
role_arn: str,
168168
session: Optional[Session] = None,
169169
region: Optional[str] = None,
170-
tags: Optional[List[TagsDict]] = [],
170+
create_tags: Optional[List[TagsDict]] = [],
171171
) -> Pipeline:
172172
"""Get existing pipeline or create/update it.
173173
@@ -181,7 +181,7 @@ def _get_or_create_pipeline(
181181
role_arn: IAM role ARN for pipeline execution
182182
session: Boto3 session (optional)
183183
region: AWS region (optional)
184-
tags (Optional[List[TagsDict]]): List of tags to include in pipeline
184+
create_tags (Optional[List[TagsDict]]): List of tags to include in pipeline
185185
186186
Returns:
187187
Pipeline instance (existing updated or newly created)
@@ -207,7 +207,7 @@ def _get_or_create_pipeline(
207207

208208
# Get tags using Tag.get_all
209209
tags_list = Tag.get_all(resource_arn=pipeline_arn, session=session, region=region)
210-
tags.extend({tag.key: tag.value for tag in tags_list})
210+
tags = {tag.key: tag.value for tag in tags_list}
211211

212212
# Validate tag
213213
if tags.get(_TAG_SAGEMAKER_MODEL_EVALUATION) == "true":
@@ -230,19 +230,19 @@ def _get_or_create_pipeline(
230230

231231
# No matching pipeline found, create new one
232232
logger.info(f"No existing pipeline found with prefix {pipeline_name_prefix}, creating new one")
233-
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region)
233+
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region, create_tags)
234234

235235
except ClientError as e:
236236
error_code = e.response['Error']['Code']
237237
if "ResourceNotFound" in error_code:
238-
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region)
238+
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region, create_tags)
239239
else:
240240
raise
241241

242242
except Exception as e:
243243
# If search fails for other reasons, try to create
244244
logger.info(f"Error searching for pipeline ({str(e)}), attempting to create new pipeline")
245-
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region)
245+
return _create_evaluation_pipeline(eval_type, role_arn, pipeline_definition, session, region, create_tags)
246246

247247

248248
def _start_pipeline_execution(
@@ -555,7 +555,7 @@ def start(
555555
role_arn=role_arn,
556556
session=session,
557557
region=region,
558-
tags=tags,
558+
create_tags=tags,
559559
)
560560

561561
# Start pipeline execution via boto3

0 commit comments

Comments
 (0)