From ef168516ce0e85265b235d720cd74e5cce1f0f16 Mon Sep 17 00:00:00 2001 From: aviruthen <91846056+aviruthen@users.noreply.github.com> Date: Mon, 15 Dec 2025 12:10:57 -0800 Subject: [PATCH 1/3] Initialize framework and version in post_init --- sagemaker-serve/src/sagemaker/serve/model_builder.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sagemaker-serve/src/sagemaker/serve/model_builder.py b/sagemaker-serve/src/sagemaker/serve/model_builder.py index fb6ed94471..b1a26001c4 100644 --- a/sagemaker-serve/src/sagemaker/serve/model_builder.py +++ b/sagemaker-serve/src/sagemaker/serve/model_builder.py @@ -489,6 +489,11 @@ def _initialize_defaults(self) -> None: self.container_config = "host" self.inference_recommender_job_results = None self.container_log_level = logging.INFO + + if not hasattr(self, 'framework') or self.framework is None: + self.framework = None + if not hasattr(self, 'framework_version') or self.framework_version is None: + self.framework_version = None def _fetch_default_instance_type_for_custom_model(self) -> str: hosting_configs = self._fetch_hosting_configs_for_custom_model() From 30c1a8b37d9e3e86835ea510098d624d29cda69f Mon Sep 17 00:00:00 2001 From: aviruthen <91846056+aviruthen@users.noreply.github.com> Date: Wed, 17 Dec 2025 09:20:16 -0800 Subject: [PATCH 2/3] Fix model registry notebook --- .../v3-model-registry-example.ipynb | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/v3-examples/ml-ops-examples/v3-model-registry-example/v3-model-registry-example.ipynb b/v3-examples/ml-ops-examples/v3-model-registry-example/v3-model-registry-example.ipynb index 857e103379..14a94432fb 100644 --- a/v3-examples/ml-ops-examples/v3-model-registry-example/v3-model-registry-example.ipynb +++ b/v3-examples/ml-ops-examples/v3-model-registry-example/v3-model-registry-example.ipynb @@ -185,18 +185,24 @@ "metadata": {}, "outputs": [], "source": [ + "from sagemaker.core.resources import ModelPackage\n", + "from sagemaker.serve.model_builder import ModelBuilder\n", + "\n", + "# Get the registered ModelPackage using the ARN as model_package_name\n", + "model_package = ModelPackage.get(model_package_name=registered_model_package_arn)\n", + "\n", + "s3_model_data_uri = model_package.inference_specification.containers[0].model_data_url\n", + "image_uri = model_package.inference_specification.containers[0].image\n", "\n", - "# Use the model_package in section above\n", "model_builder = ModelBuilder(\n", - " model_package_arn=registered_model_package_arn,\n", + " s3_model_data_url=s3_model_data_uri,\n", + " image_uri=image_uri,\n", " role_arn=role,\n", " sagemaker_session=sagemaker_session\n", ")\n", "\n", - "\n", - "\n", "# Build the model\n", - "model = model_builder.build(model_name=\"my-model-from-registry\")" + "model = model_builder.build(model_name=\"my-model-from-registry\")\n" ] } ], From 4f2d3e4e7a9cd9489becfa84367e738e5610da36 Mon Sep 17 00:00:00 2001 From: aviruthen <91846056+aviruthen@users.noreply.github.com> Date: Wed, 17 Dec 2025 15:38:20 -0800 Subject: [PATCH 3/3] removing redundant condition check --- sagemaker-serve/src/sagemaker/serve/model_builder.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sagemaker-serve/src/sagemaker/serve/model_builder.py b/sagemaker-serve/src/sagemaker/serve/model_builder.py index b1a26001c4..2cfaaaca00 100644 --- a/sagemaker-serve/src/sagemaker/serve/model_builder.py +++ b/sagemaker-serve/src/sagemaker/serve/model_builder.py @@ -490,9 +490,9 @@ def _initialize_defaults(self) -> None: self.inference_recommender_job_results = None self.container_log_level = logging.INFO - if not hasattr(self, 'framework') or self.framework is None: + if not hasattr(self, 'framework'): self.framework = None - if not hasattr(self, 'framework_version') or self.framework_version is None: + if not hasattr(self, 'framework_version'): self.framework_version = None def _fetch_default_instance_type_for_custom_model(self) -> str: