update specs

Author: DannyBen

lib/bashly/commands/add.rb

@@ -21,6 +21,8 @@ class Add < Base
       attr_reader :skip_src_check
 
       def run
+        say "Performing git operations, this may take a while...\n" if lib_source.git?
+
         if args['--list']
           show_list
         else

lib/bashly/library_source.rb

@@ -47,8 +47,8 @@ def path
 
     def git_clone
       dir = Dir.mktmpdir 'bashly-libs-'
-      safe_run "git clone --depth 1 #{git_specs[:url]} #{dir}"
-      safe_run %[git -C "#{dir}" checkout #{git_specs[:ref]}] if git_specs[:ref]
+      safe_run "git clone --quiet #{git_specs[:url]} #{dir}"
+      safe_run %[git -C "#{dir}" checkout --quiet #{git_specs[:ref]}] if git_specs[:ref]
 
       "#{dir}#{git_specs[:path]}"
     end
@@ -69,7 +69,7 @@ def git_specs
     end
 
     def safe_run(cmd)
-      raise "Failed running command:\nm`#{cmd}`" unless system "#{cmd} > /dev/null 2>&1"
+      raise "Failed running command:\nm`#{cmd}`" unless system cmd
     end
 
     def transform_github_uri

spec/approvals/cli/add/from-github

@@ -0,0 +1,3 @@
+Performing git operations, this may take a while...
+
+created spec/tmp/src/lib/database.sh

spec/bashly/commands/add_spec.rb

@@ -200,4 +200,13 @@
         .to output_approval('cli/add/from-extenal-path')
     end
   end
+
+  context 'with a library from github' do
+    before { reset_tmp_dir create_src: true }
+
+    it 'properly installs the library' do
+      expect { subject.execute %w[add --source github:dannyben/bashly//spec/fixtures/libraries database] }
+        .to output_approval('cli/add/from-github')
+    end
+  end
 end