improve flag validations

Author: DannyBen

lib/bashly/config_validator.rb

@@ -82,7 +82,7 @@ def assert_arg(key, value)
 
       assert_array "#{key}.allowed", value['allowed'], of: :string
 
-      refute value['name'].match(/^-/), "#{key}.name must not start with a '-'"
+      refute value['name'].match(/^-/), "#{key}.name must not start with '-'"
     end
 
     def assert_flag(key, value)
@@ -99,9 +99,9 @@ def assert_flag(key, value)
       assert_boolean "#{key}.required", value['required']
       assert_array "#{key}.allowed", value['allowed'], of: :string
 
-      assert value['long'].match(/^--[^\s]+$/), "#{key}.long must be in the form of '--name'" if value['long']
-      assert value['short'].match(/^-[^\s]$/), "#{key}.short must be in the form of '-n'" if value['short']
-      refute value['arg'].match(/^-/), "#{key}.arg must not start with a '-'" if value['arg']
+      assert value['long'].match(/^--[a-zA-Z0-9_\-]+$/), "#{key}.long must be in the form of '--name'" if value['long']
+      assert value['short'].match(/^-[a-zA-Z0-9]$/), "#{key}.short must be in the form of '-n'" if value['short']
+      refute value['arg'].match(/^-/), "#{key}.arg must not start with '-'" if value['arg']
     end
 
     def assert_env_var(key, value)

spec/approvals/validations/invalid_arg

@@ -1 +1 @@
-#<Bashly::ConfigurationError: root.args[0].name must not start with a '-'>
+#<Bashly::ConfigurationError: root.args[0].name must not start with '-'>

spec/approvals/validations/invalid_flag_arg

@@ -1 +1 @@
-#<Bashly::ConfigurationError: root.flags[0].arg must not start with a '-'>
+#<Bashly::ConfigurationError: root.flags[0].arg must not start with '-'>