- Remove deprecated command.short

Author: DannyBen

lib/bashly/commands/base.rb

@@ -21,14 +21,6 @@ def validate_config
       def with_valid_config
         validate_config
         yield
-        show_deprecations
-      end
-
-      def show_deprecations
-        return if config_validator.deprecations.empty? || ENV['BASHLY_HIDE_DEPRECATIONS']
-
-        messages = config_validator.deprecations.map(&:message).join("\n\n")
-        say! "\n#{messages}\n\n"
       end
     end
   end

lib/bashly/commands/validate.rb

@@ -17,13 +17,7 @@ def run
           puts '---'
         end
         validate_config
-        show_deprecations
-        deprecations = config_validator.deprecations
-        if deprecations.empty?
-          say 'g`OK`'
-        else
-          say "r`WARNING` Found #{deprecations.count} deprecations"
-        end
+        say 'g`OK`'
       end
     end
   end

lib/bashly/concerns/validation_helpers.rb

@@ -2,10 +2,6 @@ module Bashly
   # This is a `ConfigValidator` concern responsible for providing basic
   # assertion methods.
   module ValidationHelpers
-    def deprecations
-      @deprecations ||= []
-    end
-
   protected
 
     def assert(valid, message)
@@ -16,10 +12,6 @@ def refute(invalid, message)
       assert !invalid, message
     end
 
-    def deprecate(key, **options)
-      deprecations.push Deprecation.new(key, **options)
-    end
-
     def assert_string(key, value)
       assert value.is_a?(String), "#{key} must be a string"
     end

lib/bashly/config_validator.rb

@@ -193,11 +193,6 @@ def assert_command(key, value)
         refute value['version'], "#{key}.version makes no sense"
         refute value['extensible'], "#{key}.extensible makes no sense"
       end
-
-      # DEPRECATION 0.8.0
-      if value['short']
-        deprecate "#{key}.short", replacement: 'alias', reference: 'https://github.com/DannyBen/bashly/pull/220'
-      end
     end
   end
 end

lib/bashly/deprecation.rb

@@ -11,9 +11,7 @@ def option_keys
             extensible expose filename filters flags
             footer function group help name
             private version
-            short
           ]
-          # DEPRECATION 0.8.0
         end
       end
 
@@ -36,8 +34,6 @@ def aliases
 
       # Returns an array of alternative aliases if any
       def alt
-        # DEPRECATION 0.8.0
-        options['alias'] ||= options['short']
         return [] unless options['alias']
 
         options['alias'].is_a?(String) ? [options['alias']] : options['alias']