Merge pull request #209 from DannyBen/add/catch-all-validation

Disallow catch_all together with repeatable arg

Author: DannyBen

lib/bashly/config_validator.rb

@@ -138,7 +138,7 @@ def assert_command(key, value)
 
       refute value['commands'] && value['args'], "#{key} cannot have both commands and args"
       refute value['commands'] && value['flags'], "#{key} cannot have both commands and flags"
-      
+
       assert_string "#{key}.name", value['name']
       assert_optional_string "#{key}.short", value['short']
       assert_optional_string "#{key}.help", value['help']
@@ -161,6 +161,11 @@ def assert_command(key, value)
       assert_array "#{key}.environment_variables", value['environment_variables'], of: :env_var
       assert_array "#{key}.examples", value['examples'], of: :string
 
+      if value['catch_all'] and value['args']
+        repeatable_arg = value['args'].select { |a| a['repeatable'] }.first&.dig 'name'
+        refute repeatable_arg, "#{key}.catch_all makes no sense with repeatable arg (#{repeatable_arg})"
+      end
+
       if key == "root"
         refute value['short'], "#{key}.short makes no sense"
         refute value['group'], "#{key}.group makes no sense"

spec/approvals/validations/catch_all_and_repeatable_arg

@@ -0,0 +1 @@
+#<Bashly::ConfigurationError: root.catch_all makes no sense with repeatable arg (path)>

spec/fixtures/script/validations.yml

@@ -200,3 +200,12 @@
   - long: --user
     disallowed: true
 
+:catch_all_and_repeatable_arg:
+  name: invalid
+  help: catch_all and repeatable arg make no sense together
+  catch_all: true
+  args:
+  - name: path
+    help: Path to one or more files
+    repeatable: true
+    required: true