refactor completions library

Author: DannyBen

lib/bashly/commands/add.rb

@@ -62,16 +62,16 @@ def comp_command
         case format
         when "script"
           path = output || "#{Settings.target_dir}/completions.bash"
-          add_lib Library::Completions.new(path, format: format)
+          add_lib Library::CompletionsScript.new(path)
 
         when "function"
           function = output || "send_completions"
           path = "#{Settings.source_dir}/lib/#{function}.sh"
-          add_lib Library::Completions.new(path, format: format, function: function)
+          add_lib Library::CompletionsFunction.new(path, function: function)
 
         when "yaml"
           path = output || "#{Settings.target_dir}/completions.yml"
-          add_lib Library::Completions.new(path, format: format)
+          add_lib Library::CompletionsYAML.new(path)
 
         else
           raise Error, "Unrecognized format: #{format}"

lib/bashly/library/completions.rb

@@ -2,55 +2,15 @@ module Bashly
   module Library
     class Completions < Base
       def content
-        {
-          path: target_path,
-          content: file_content
-        }
-      end
-
-      def post_install_message
-        case format
-        when 'script'
-          <<~EOF
-            In order to enable completions, run:
-
-              !txtpur!$ source #{target_path}
-          EOF
-        
-        when 'function'
-          <<~EOF
-            In order to enable completions in your script, create a command or a flag (for example: !txtgrn!#{command.name} completions!txtrst! or !txtgrn!#{command.name} --completions!txtrst!) that calls the !txtgrn!#{function_name}!txtrst! function.
-
-            Your users can then run something like this to enable completions:
-
-              !txtpur!$ eval \"$(#{command.name} completions)\"
-          EOF
-
-        else
-          <<~EOF
-            This file can be converted to a completions script using the !txtgrn!completely!txtrst! gem.
-          EOF
-        end
-      end
-
-    private
-
-      def function_name
-        options[:function]
-      end
-
-      def format
-        options[:format]
+        { path: target_path, content: file_content }
       end
 
       def file_content
-        case format
-        when 'script' then command.completion_script
-        when 'function' then command.completion_function(options[:function])
-        else completions.to_yaml
-        end
+        raise NotImplementedError, "Please implement #file_content"
       end
 
+    protected
+
       def completions
         @completions ||= command.completion_data
       end

lib/bashly/library/completions_function.rb

@@ -0,0 +1,23 @@
+module Bashly
+  module Library
+    class CompletionsFunction < Completions
+      def file_content
+        command.completion_function function_name
+      end
+
+      def post_install_message
+        <<~EOF
+          In order to enable completions in your script, create a command or a flag (for example: !txtgrn!#{command.name} completions!txtrst! or !txtgrn!#{command.name} --completions!txtrst!) that calls the !txtgrn!#{function_name}!txtrst! function.
+
+          Your users can then run something like this to enable completions:
+
+            !txtpur!$ eval \"$(#{command.name} completions)\"
+        EOF
+      end
+
+      def function_name
+        options[:function]
+      end
+    end
+  end
+end

lib/bashly/library/completions_script.rb

@@ -0,0 +1,17 @@
+module Bashly
+  module Library
+    class CompletionsScript < Completions
+      def file_content
+        command.completion_script
+      end
+
+      def post_install_message
+        <<~EOF
+          In order to enable completions, run:
+
+            !txtpur!$ source #{target_path}
+        EOF
+      end
+    end
+  end
+end

lib/bashly/library/completions_yaml.rb

@@ -0,0 +1,15 @@
+module Bashly
+  module Library
+    class CompletionsYAML < Completions
+      def file_content
+        completions.to_yaml
+      end
+
+      def post_install_message
+        <<~EOF
+          This file can be converted to a completions script using the !txtgrn!completely!txtrst! gem.
+        EOF
+      end
+    end
+  end
+end