FIX: Remove xfails and implement download cdp in chrome

Author: kayqueGovetri

botcity/web/bot.py

@@ -281,7 +281,7 @@ def _get_service(self):
         return service
 
     def _others_configurations(self):
-        if self.browser == Browser.UNDETECTED_CHROME:
+        if self.browser in [Browser.UNDETECTED_CHROME, Browser.CHROME, Browser.EDGE]:
             """
             There is a problem in undetected chrome that prevents downloading files even passing
             download_folder_path in preferences.
@@ -1130,20 +1130,12 @@ def print_pdf(self, path=None, print_options=None):
             return default_path
 
         if print_options is None:
-            print_options = {
-                'landscape': False,
-                'displayHeaderFooter': False,
-                'printBackground': True,
-                'preferCSSPageSize': True,
-                'marginTop': 0,
-                'marginBottom': 0
-            }
-        print_options = PrintOptions()
-        print_options.page_ranges = ['1-2']
-        print_options.margin_top = 0
-        print_options.margin_bottom = 0
-        print_options.background = True
-        print_options.orientation = 'landscape'
+            print_options = PrintOptions()
+            print_options.page_ranges = ['1-2']
+            print_options.margin_top = 0
+            print_options.margin_bottom = 0
+            print_options.background = True
+            print_options.orientation = 'landscape'
         data = self._driver.print_page(print_options)
         bytes_file = base64.b64decode(data)
         if not path:

tests/test_browser.py

@@ -236,7 +236,6 @@ def test_scroll_up(web: WebBot):
     assert mouse_icon is not None
 
 
-@pytest.mark.xfail
 def test_set_screen_resolution(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.set_screen_resolution(500, 500)
@@ -246,20 +245,18 @@ def test_set_screen_resolution(web: WebBot):
     assert width == '500'
 
 
-@pytest.mark.xfail(reason="Unknown chrome/undetected error to be investigated.")
 def test_wait_for_downloads(web: WebBot):
     fake_bin_path = conftest.get_fake_bin_path(web=web)
 
     web.browse(conftest.INDEX_PAGE)
-
     web.type_keys([web.KEYS.SHIFT, 'q'])
 
     web.wait_for_downloads(timeout=60000)
     web.wait(5000)
 
     assert os.path.exists(fake_bin_path) and os.path.getsize(fake_bin_path) > 0
 
-@pytest.mark.xfail(reason="Unknown chrome/undetected error to be investigated.")
+
 def test_wait_for_file(web: WebBot):
     fake_bin_path = conftest.get_fake_bin_path(web=web)
 
@@ -290,7 +287,6 @@ def test_set_current_element(web: WebBot):
     assert result['data'] == ['Left2'] or result['data'] == ['Left']
 
 
-# @pytest.mark.xfail(reason="Unknown chrome/undetected error to be investigated.")
 def test_print_pdf(web: WebBot, tmp_folder):
     web.browse(conftest.INDEX_PAGE)
     pdf = web.print_pdf(path=os.path.join(tmp_folder, 'page.pdf'))

tests/test_vision.py

@@ -44,7 +44,6 @@ def test_get_last_element(web: WebBot):
     assert ele is not None
 
 
-@pytest.mark.xfail(reason="find return None in windows chrome")
 def test_find_text(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.set_screen_resolution(3000, 2000)