ENH: Update conftest to tmp folders and ajust time tests

Author: kayqueGovetri

conftest.py

@@ -1,5 +1,8 @@
 import os
 import json
+import shutil
+import tempfile
+
 import pytest
 import typing
 import platform
@@ -14,69 +17,84 @@
 INDEX_PAGE = "https://lf2a.github.io/webpage-test/"
 
 
-def setup_chrome(headless: bool) -> WebBot:
+def get_fake_bin_path(web: WebBot) -> str:
+    return os.path.join(web.download_folder_path, 'fake.bin')
+
+
+def get_driver_path(driver: str) -> str:
+    if OS_NAME.lower() == 'windows':
+        return os.path.join(PROJECT_DIR, 'web-drivers', 'windows', f'{driver}.exe')
+
+    if OS_NAME.lower() == 'linux':
+        return os.path.join(PROJECT_DIR, 'web-drivers', 'linux', driver)
+
+    if OS_NAME.lower() == 'darwin':
+        return os.path.join(PROJECT_DIR, 'web-drivers', 'macos', driver)
+
+    raise ValueError(f'OS [{OS_NAME}] not supported.')
+
+
+def setup_chrome(headless: bool, tmp_folder: str) -> WebBot:
     web = WebBot(headless)
     web.browser = Browser.CHROME
 
-    if OS_NAME == 'Windows':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'windows', 'chromedriver.exe')
-    elif OS_NAME == 'Linux':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'linux', 'chromedriver')
-    elif OS_NAME == 'Darwin':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'macos', 'chromedriver')
-    else:
-        raise ValueError(f'OS [{OS_NAME}] not supported.')
+    web.driver_path = get_driver_path(driver='chromedriver')
+    web.download_folder_path = tmp_folder
     return web
 
 
-def setup_firefox(headless: bool) -> WebBot:
+def setup_firefox(headless: bool, tmp_folder: str) -> WebBot:
     web = WebBot(headless)
     web.browser = Browser.FIREFOX
 
-    if OS_NAME == 'Windows':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'windows', 'geckodriver.exe')
-    elif OS_NAME == 'Linux':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'linux', 'geckodriver')
-    elif OS_NAME == 'Darwin':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'macos', 'geckodriver')
-    else:
-        raise ValueError(f'OS [{OS_NAME}] not supported.')
+    web.driver_path = get_driver_path(driver='geckodriver')
+    web.download_folder_path = tmp_folder
+
     return web
 
 
-def setup_edge(headless: bool) -> WebBot:
+def setup_edge(headless: bool, tmp_folder: str) -> WebBot:
     web = WebBot(headless)
     web.browser = Browser.EDGE
 
-    opt = browsers.edge.default_options(headless=headless, download_folder_path=web.download_folder_path)
+    web.driver_path = get_driver_path(driver='msedgedriver')
+    web.download_folder_path = tmp_folder
+    opt = browsers.edge.default_options(headless=headless, download_folder_path=tmp_folder)
     opt.set_capability('platform', 'ANY')  # WINDOWS is default value:
 
-    if OS_NAME == 'Windows':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'windows', 'msedgedriver.exe')
-    elif OS_NAME == 'Linux':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'linux', 'msedgedriver')
-    elif OS_NAME == 'Darwin':
-        web.driver_path = os.path.join(PROJECT_DIR, 'web-drivers', 'macos', 'msedgedriver')
-    else:
-        raise ValueError(f'OS [{OS_NAME}] not supported.')
     web.options = opt
     return web
 
 
+def factory_setup_browser(browser: str, is_headless: bool, tmp_folder: str) -> WebBot:
+    dict_browsers = {
+        'chrome': setup_chrome,
+        'firefox': setup_firefox,
+        'edge': setup_edge
+    }
+
+    setup_browser = dict_browsers.get(browser, None)
+
+    if setup_browser is None:
+        raise ValueError(f'Browser [{browser}] not supported.')
+
+    return setup_browser(headless=is_headless, tmp_folder=tmp_folder)
+
+
 @pytest.fixture
-def web(request):
+def tmp_folder() -> str:
+    folder = tempfile.mkdtemp()
+    yield folder
+    shutil.rmtree(folder)
+
+
+@pytest.fixture
+def web(request, tmp_folder: str):
 
     browser = request.config.getoption("--browser") or Browser.CHROME
     is_headless = request.config.getoption("--headless")
 
-    if browser == 'chrome':
-        web = setup_chrome(is_headless)
-    elif browser == 'firefox':
-        web = setup_firefox(is_headless)
-    elif browser == 'edge':
-        web = setup_edge(is_headless)
-    else:
-        raise ValueError(f'Browser [{browser}] not supported.')
+    web = factory_setup_browser(browser=browser, is_headless=is_headless, tmp_folder=tmp_folder)
     yield web
     web.stop_browser()
 

test-requirements.txt

@@ -1 +1,2 @@
 pytest
+pytest-xdist

tests/test_browser.py

@@ -8,7 +8,6 @@
 
 def test_create_tab(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
-    web.wait(2_000)
 
     title = web.page_title()
     assert title == 'Botcity - web test'
@@ -17,7 +16,6 @@ def test_create_tab(web: WebBot):
 def test_close_page(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.create_window(url=conftest.TEST_PAGE)
-    web.wait(5_000)
     web.close_page()
 
     title = web.page_title()
@@ -27,7 +25,6 @@ def test_close_page(web: WebBot):
 def test_create_window(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.create_window(url=conftest.TEST_PAGE)
-    web.wait(2_000)
 
     title = web.page_title()
     assert title == 'Page test'
@@ -36,7 +33,6 @@ def test_create_window(web: WebBot):
 def test_display_size(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.set_screen_resolution(1280, 720)
-    web.wait(2_000)
     (w, h) = web.display_size()
 
     assert w == 1280
@@ -63,7 +59,6 @@ def test_get_tabs(web: WebBot):
 def test_navigate_to(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.navigate_to(url=conftest.TEST_PAGE)
-    web.wait(2_000)
 
     title = web.page_title()
     assert title == 'Page test'
@@ -173,7 +168,6 @@ def test_set_file_input_element(web: WebBot):
 
     pdf_file = os.path.join(conftest.PROJECT_DIR, 'sample.pdf')
     web.set_file_input_element(input_file_element, pdf_file)
-    web.wait(5_000)
 
     file_name = input_file_element.get_attribute('value')
     assert file_name == 'C:\\fakepath\\sample.pdf'
@@ -221,63 +215,44 @@ def test_scroll_up(web: WebBot):
     web.type_keys([web.KEYS.SHIFT, 'd'])  # scroll down trigger
     web.scroll_up(20)
 
-    mouse_icon = web.find("mouse", matching=0.97, waiting_time=10_000)
+    mouse_icon = web.find("mouse", matching=0.97, waiting_time=10000)
     assert mouse_icon is not None
 
 
 @pytest.mark.xfail
 def test_set_screen_resolution(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
     web.set_screen_resolution(500, 500)
-    web.wait(2000)
 
     page_size = web.find_element('page-size', By.ID).text
     width = page_size.split('x')[0]
     assert width == '500'
 
 
-def test_wait_for_downloads_and_file(web: WebBot):
-    if os.path.exists(conftest.FAKE_BIN_PATH):
-        os.remove(conftest.FAKE_BIN_PATH)
+def test_wait_for_downloads(web: WebBot):
+    fake_bin_path = conftest.get_fake_bin_path(web=web)
 
-    try:
-        web.browse(conftest.INDEX_PAGE)
-        web.wait(1000)
-
-        web.type_keys([web.KEYS.SHIFT, 'q'])
-        web.wait(5000)
-
-        web.wait_for_downloads(timeout=120_000)
-        web.wait(2000)
+    web.browse(conftest.INDEX_PAGE)
 
-        assert os.path.exists(conftest.FAKE_BIN_PATH) and os.path.getsize(conftest.FAKE_BIN_PATH) > 0
-    finally:
-        os.remove(conftest.FAKE_BIN_PATH)
-        wait_for_file(web=web)
+    web.type_keys([web.KEYS.SHIFT, 'q'])
 
+    web.wait_for_downloads(timeout=20000)
+    assert os.path.exists(fake_bin_path) and os.path.getsize(fake_bin_path) > 0
 
-def wait_for_file(web: WebBot):
-    try:
-        if os.path.exists(conftest.FAKE_BIN_PATH):
-            os.remove(conftest.FAKE_BIN_PATH)
 
-        web.browse(conftest.INDEX_PAGE)
-        web.wait(1000)
+def test_wait_for_file(web: WebBot):
+    fake_bin_path = conftest.get_fake_bin_path(web=web)
 
-        web.type_keys([web.KEYS.SHIFT, 'q'])
-        web.wait(5000)
+    web.browse(conftest.INDEX_PAGE)
 
-        web.wait_for_file(conftest.FAKE_BIN_PATH, timeout=120_000)
-        web.wait(2000)
+    web.type_keys([web.KEYS.SHIFT, 'q'])
 
-        assert os.path.exists(conftest.FAKE_BIN_PATH) and os.path.getsize(conftest.FAKE_BIN_PATH) > 0
-    finally:
-        os.remove(conftest.FAKE_BIN_PATH)
+    web.wait_for_file(fake_bin_path, timeout=20000)
+    assert os.path.exists(fake_bin_path) and os.path.getsize(fake_bin_path) > 0
 
 
 def test_set_current_element(web: WebBot):
     web.browse(conftest.INDEX_PAGE)
-    web.wait(1000)
 
     web.add_image('mouse', os.path.join(conftest.PROJECT_DIR, 'resources', 'mouse.png'))
     web.add_image('git', os.path.join(conftest.PROJECT_DIR, 'resources', 'git.png'))