Renamed ara_all_fields_none to is_all_field_none. (#42)

Author: Kevin Hellemun

bunq/sdk/json/adapters.py

@@ -31,7 +31,7 @@ def deserialize(cls, cls_target, obj_raw):
 
         model_ = super()._deserialize_default(cls_target, obj_raw)
 
-        if isinstance(model_, core.AnchoredObjectInterface) and model_.are_all_fields_none():
+        if isinstance(model_, core.AnchoredObjectInterface) and model_.is_all_field_none():
             for field in model_.__dict__:
                 field_ = None
                 if field in cls._override_field_map:
@@ -44,7 +44,7 @@ def deserialize(cls, cls_target, obj_raw):
 
                 contents = super()._deserialize_default(object_class, obj_raw)
 
-                if contents.are_all_fields_none():
+                if contents.is_all_field_none():
                     setattr(model_, field, None)
                 else:
                     setattr(model_, field, contents)

bunq/sdk/model/core.py

@@ -16,7 +16,7 @@ class BunqModel(object):
     # The very first index of an array
     _INDEX_FIRST = 0
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         raise NotImplementedError
 
     def to_json(self):
@@ -26,6 +26,10 @@ def to_json(self):
 
         return converter.class_to_json(self)
 
+    @staticmethod
+    def from_json(json_str):
+        raise NotImplementedError
+
     @classmethod
     def _from_json_array_nested(cls, response_raw):
         """
@@ -148,7 +152,7 @@ def id_(self):
 
         return self._id_
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.id_ is not None:
             return False
 
@@ -172,7 +176,7 @@ def uuid(self):
 
         return self._uuid
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.uuid is not None:
             return False
 
@@ -224,7 +228,7 @@ def token(self):
 
         return self._token
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.id_ is not None:
             return False
 
@@ -256,7 +260,7 @@ def server_public_key(self):
 
         return self._server_public_key
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.server_public_key is not None:
             return False
 
@@ -336,7 +340,7 @@ def generate_request_body_bytes(cls, public_key_string):
             }
         ).encode()
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.id_ is not None:
             return False
 
@@ -424,7 +428,7 @@ def generate_request_body_bytes(cls, secret):
 
         return converter.class_to_json({cls.FIELD_SECRET: secret}).encode()
 
-    def are_all_fields_none(self):
+    def is_all_field_none(self):
         if self.id_ is not None:
             return False
 

tests/model/generated/object/test_notification_url.py

@@ -103,13 +103,12 @@ def execute_notification_url_test(self,
             self.assertTrue(
                 isinstance(
                     sub_class_model,
-                    self.getModelTypeOrNone(
+                    self.get_model_type_or_none(
                         sub_class_expected_object_name
                     )
                 )
             )
 
-
     @classmethod
     def is_model_reference(cls, referenced_model, class_name):
         """
@@ -161,10 +160,7 @@ def get_notification_url(self, file_path):
                 self._KEY_NOTIFICATION_URL_MODEL in json_object
             )
 
-            return json_to_class(
-                object_.NotificationUrl,
-                json_string
-            )
+            return object_.NotificationUrl.from_json(json_string)
 
     def test_mutation_model(self):
         self.execute_notification_url_test(