Bugfix for CCFileUtils searchResolutionsOrder.

It was internally declared as NSMutableArray but accessible and writable(copy) as NSArray.
This caused all kinds of weird crashes when assigning new values after setup and running the tests.
Reenabled the tests depending on this.

Author: NickyWeber

UnitTests/CCPackageHelperTests.m

@@ -20,31 +20,30 @@ @interface CCPackageHelperTests : XCTestCase
 
 @implementation CCPackageHelperTests
 
-/*
+
 - (void)testDefaultResolution
 {
     // Standard test
-    [CCFileUtils sharedFileUtils].searchResolutionsOrder = @[CCFileUtilsSuffixiPhoneHD, CCFileUtilsSuffixiPadHD];
+    [CCFileUtils sharedFileUtils].searchResolutionsOrder = [@[CCFileUtilsSuffixiPhoneHD, CCFileUtilsSuffixiPadHD] mutableCopy];
     NSString *mappedResolution = [CCPackageHelper ccFileUtilsSuffixToResolution:CCFileUtilsSuffixiPhoneHD];
     NSString *defaultResolution = [CCPackageHelper defaultResolution];
     CCAssertEqualStrings(defaultResolution, mappedResolution);
 
     // Ignore non mappable entriy and pick next
-    [CCFileUtils sharedFileUtils].searchResolutionsOrder = @[@"weird_nonsense", CCFileUtilsSuffixiPadHD];
+    [CCFileUtils sharedFileUtils].searchResolutionsOrder = [@[@"weird_nonsense", CCFileUtilsSuffixiPadHD] mutableCopy];
     NSString *mappedResolution2 = [CCPackageHelper ccFileUtilsSuffixToResolution:CCFileUtilsSuffixiPadHD];
     NSString *defaultResolution2 = [CCPackageHelper defaultResolution];
     CCAssertEqualStrings(defaultResolution2, mappedResolution2);
 
     // Return default since nothing can be mapped
-    [CCFileUtils sharedFileUtils].searchResolutionsOrder = @[@"nothing_to_be_mapped"];
+    [CCFileUtils sharedFileUtils].searchResolutionsOrder = [@[@"nothing_to_be_mapped"] mutableCopy];
     NSString *defaultResolution3 = [CCPackageHelper defaultResolution];
     CCAssertEqualStrings(defaultResolution3, @"phonehd");
 
     // Empty array
-    [CCFileUtils sharedFileUtils].searchResolutionsOrder = @[];
+    [CCFileUtils sharedFileUtils].searchResolutionsOrder = [@[] mutableCopy];
     NSString *defaultResolution4 = [CCPackageHelper defaultResolution];
     CCAssertEqualStrings(defaultResolution4, @"phonehd");
 }
-*/
 
 @end

UnitTests/CCPackageManagerTests.m

@@ -27,13 +27,10 @@ - (void)setUp
 
 - (void)testPackageWithName
 {
-    // NOTE: This will kill many other tests due to a bug in CCFileUtils
-    // So we assume until the bug's fixed that phonehd is the default resolution
-    // [CCFileUtils sharedFileUtils].searchResolutionsOrder = @[CCFileUtilsSuffixiPadHD];
+    [CCFileUtils sharedFileUtils].searchResolutionsOrder = [@[CCFileUtilsSuffixiPadHD] mutableCopy];
 
     CCPackage *aPackage = [[CCPackage alloc] initWithName:@"foo"
-                                               // resolution:@"tablethd" // See note above
-                                               resolution:@"phonehd"
+                                               resolution:@"tablethd" // See note above
                                                        os:@"iOS"
                                                 remoteURL:[NSURL URLWithString:@"http://foo.fake"]];
 

cocos2d/Support/CCFileUtils.h

@@ -133,7 +133,7 @@ typedef NS_ENUM(NSUInteger, CCFileUtilsSearchMode) {
  If the property "enableiPhoneResourcesOniPad" is enabled, it will also search for iPhone resources if you are in an iPad.
  
  */
-@property (nonatomic, copy) NSArray *searchResolutionsOrder;
+@property (nonatomic, strong) NSMutableArray *searchResolutionsOrder;
 
 /** Array of search paths.
  You can use this array to modify the search path of the resources.