Added BACKUP_CONFIG_ENVFILE

See CHANGELOG.md of this commit

Author: williamdes

.env-example

@@ -4,11 +4,11 @@ MYSQL_HOST=localhost
 MYSQL_USER=root
 MYSQL_PASS=toor
 
-# (Optional) Databases to skip with no space between the args separated by a ,
+# (Optional, use recommended example below ) Databases to skip with no space between the args separated by a ,
 SKIP_DATABASES=mysql,information_schema,performance_schema,phpmyadmin
 
 # (Optional) No not use if you are a goat
-EXPERT_ARGS=--default-character-set=utf8 --extended-insert=FALSE --single-transaction --skip-comments --skip-dump-date --hex-blob --tz-utc
+# EXPERT_ARGS=--default-character-set=utf8 --extended-insert=FALSE --single-transaction --skip-comments --skip-dump-date --hex-blob --tz-utc
 
 # (Optional) Command called on script success, WITH the double quotes !
-ON_SUCCESS="echo 'Hello world'"
+# ON_SUCCESS="echo 'Hello world'"

CHANGELOG.md

@@ -7,7 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ## [Unreleased]
 ### Added
 - Check if mysql and mysqldump are installed
-
+- Updated README.md
+- Added optional `BACKUP_CONFIG_ENVFILE` variable to set the env file location
+- Updated .env-example (commented out some optional variables)
+- Added check if `BACKUP_DIR` exists
 
 ## [1.0.0] - 2018-04-07
 ### Added

README.md

@@ -17,10 +17,25 @@ cp .env-example .env
 ```bash
 nano .env
 ```
-or
+or  
 ```bash
 vi .env
 
+```
+then  
+```
+./backup.sh
+```
+## Extras
+
+To use an external env file in a custom location use example: 
+```bash
+
+export BACKUP_CONFIG_ENVFILE="/home/myuser/secretbackupconfig.env.txt"
+
+./backup.sh
+
+unset BACKUP_CONFIG_ENVFILE
 ```
 
 ## Options

backup.sh

@@ -3,7 +3,16 @@
 # from : github:builtinnya/dotenv-shell-loader
 DOTENV_SHELL_LOADER_SAVED_OPTS=$(set +o)
 set -o allexport
-[ -f "$(dirname $0)/.env" ] && source "$(dirname $0)/.env"
+if [ ! -z "${BACKUP_CONFIG_ENVFILE}" ]; then
+    if [ ! -f "${BACKUP_CONFIG_ENVFILE}" ]; then
+        echo "Value of variable BACKUP_CONFIG_ENVFILE is not a file (${BACKUP_CONFIG_ENVFILE})"
+        exit 1
+    else
+      [ -f "${BACKUP_CONFIG_ENVFILE}" ] && source "${BACKUP_CONFIG_ENVFILE}"
+    fi
+else
+  [ -f "$(dirname $0)/.env" ] && source "$(dirname $0)/.env"
+fi
 set +o allexport
 eval "$DOTENV_SHELL_LOADER_SAVED_OPTS"
 unset DOTENV_SHELL_LOADER_SAVED_OPTS
@@ -21,6 +30,11 @@ fi
 if [ -z "${BACKUP_DIR}" ]; then
     echo "Empty Variable BACKUP_DIR"
     exit 1
+else
+  if [ ! -d "${BACKUP_DIR}" ]; then
+      echo "Value of variable BACKUP_DIR is not a directory (${BACKUP_DIR})"
+      exit 1
+  fi
 fi
 
 if [ -z "${MYSQL_HOST}" ]; then