Skip to content

Commit 4c37284

Browse files
committed
add beforeeach step test
1 parent 6fc9bf4 commit 4c37284

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

tests/e2e/feature-flags.spec.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { ERROR_FLAG_EXISTS, ERROR_FLAG_INVALID } from '../../src/constants';
55
test.use({ storageState: process.env.WP_AUTH_STORAGE });
66

77
test.describe('Feature flags', () => {
8-
test('Create and delete flags e2e scenarios', async ({ page, admin }) => {
8+
test.beforeEach(async ({ page, admin }) => {
99
await admin.visitAdminPage('/');
1010

1111
//Find the feature flags in side menu
@@ -15,18 +15,19 @@ test.describe('Feature flags', () => {
1515
await expect(
1616
page.getByRole('heading', { name: 'Feature Flags settings' })
1717
).toBeVisible();
18+
});
1819

20+
test('Create and delete flags e2e scenarios', async ({ page }) => {
1921
//Create new flag
2022
await page.getByRole('button', { name: 'Add Flag' }).click();
21-
// await expect(await page.getByRole('textbox').count()).toBe(4);
2223
await page.getByRole('textbox').last().fill('test');
2324
await page.getByRole('button', { name: 'Save' }).click();
2425
//Confirm save success
2526
expect(
2627
await page.getByLabel('Dismiss this notice').innerText()
2728
).toMatch(/Saved successfully!/);
2829

29-
//Toggle flag test
30+
//Toggle feature flag
3031
await page
3132
.locator('id=mr-feature-flag-item')
3233
.last()
@@ -51,17 +52,15 @@ test.describe('Feature flags', () => {
5152
//update flag name to be unique and check text validation.
5253
await page.getByRole('textbox').last().fill('test 2');
5354
expect(page.getByText(ERROR_FLAG_INVALID)).toBeVisible();
54-
5555
expect(page.getByRole('button', { name: 'Save' })).toBeDisabled();
5656

57+
//Delete the flag
5758
await page
5859
.locator('id=mr-feature-flag-item')
5960
.last()
6061
.getByLabel('Delete Flag')
6162
.click();
62-
6363
await page.getByRole('button', { name: 'Yes' }).click();
64-
6564
//Confirm delete success
6665
expect(
6766
await page.getByLabel('Dismiss this notice').innerText()
@@ -88,15 +87,15 @@ test.describe('Feature flags', () => {
8887
expect(jsClipboardText).toContain(
8988
"window.mrFeatureFlags.isEnabled('test')"
9089
);
91-
90+
//Close SDK modal
9291
await page.locator('button[aria-label="Close"]').click();
9392

93+
//Delete the created flag
9494
await page
9595
.locator('id=mr-feature-flag-item')
9696
.last()
9797
.getByLabel('Delete Flag')
9898
.click();
99-
10099
await page.getByRole('button', { name: 'Yes' }).click();
101100
});
102101
});

0 commit comments

Comments
 (0)