fix: seeCssPropertiesOnElements failed when font-weight is a number (#4026)

kobenguyent · web-flow · commit 8d8d9f95dbe9 · 2023-11-29T07:08:45.000+01:00
diff --git a/lib/helper/Playwright.js b/lib/helper/Playwright.js
@@ -2123,7 +2123,9 @@ class Playwright extends Helper {
     let chunked = chunkArray(props, values.length);
     chunked = chunked.filter((val) => {
       for (let i = 0; i < val.length; ++i) {
-        if (val[i] !== values[i]) return false;
+        const _acutal = Number.isNaN(val[i]) || (typeof values[i]) === 'string' ? val[i] : Number.parseInt(val[i], 10);
+        const _expected = Number.isNaN(values[i]) || (typeof values[i]) === 'string' ? values[i] : Number.parseInt(values[i], 10);
+        if (_acutal !== _expected) return false;
       }
       return true;
     });
diff --git a/lib/helper/Puppeteer.js b/lib/helper/Puppeteer.js
@@ -1784,7 +1784,9 @@ class Puppeteer extends Helper {
     let chunked = chunkArray(props, values.length);
     chunked = chunked.filter((val) => {
       for (let i = 0; i < val.length; ++i) {
-        if (val[i] !== values[i]) return false;
+        const _acutal = Number.isNaN(val[i]) || (typeof values[i]) === 'string' ? val[i] : Number.parseInt(val[i], 10);
+        const _expected = Number.isNaN(values[i]) || (typeof values[i]) === 'string' ? values[i] : Number.parseInt(values[i], 10);
+        if (_acutal !== _expected) return false;
       }
       return true;
     });
@@ -1815,7 +1817,9 @@ class Puppeteer extends Helper {
     let chunked = chunkArray(attrs, values.length);
     chunked = chunked.filter((val) => {
       for (let i = 0; i < val.length; ++i) {
-        if (val[i] !== values[i]) return false;
+        const _acutal = Number.isNaN(val[i]) || (typeof values[i]) === 'string' ? val[i] : Number.parseInt(val[i], 10);
+        const _expected = Number.isNaN(values[i]) || (typeof values[i]) === 'string' ? values[i] : Number.parseInt(values[i], 10);
+        if (_acutal !== _expected) return false;
       }
       return true;
     });
diff --git a/lib/helper/WebDriver.js b/lib/helper/WebDriver.js
@@ -1508,7 +1508,9 @@ class WebDriver extends Helper {
     let chunked = chunkArray(props, values.length);
     chunked = chunked.filter((val) => {
       for (let i = 0; i < val.length; ++i) {
-        if (val[i] !== values[i]) return false;
+        const _acutal = Number.isNaN(val[i]) || (typeof values[i]) === 'string' ? val[i] : Number.parseInt(val[i], 10);
+        const _expected = Number.isNaN(values[i]) || (typeof values[i]) === 'string' ? values[i] : Number.parseInt(values[i], 10);
+        if (_acutal !== _expected) return false;
       }
       return true;
     });
@@ -1535,7 +1537,9 @@ class WebDriver extends Helper {
     let chunked = chunkArray(attrs, values.length);
     chunked = chunked.filter((val) => {
       for (let i = 0; i < val.length; ++i) {
-        if (val[i] !== values[i]) return false;
+        const _acutal = Number.isNaN(val[i]) || (typeof values[i]) === 'string' ? val[i] : Number.parseInt(val[i], 10);
+        const _expected = Number.isNaN(values[i]) || (typeof values[i]) === 'string' ? values[i] : Number.parseInt(values[i], 10);
+        if (_acutal !== _expected) return false;
       }
       return true;
     });
diff --git a/test/data/app/view/info.php b/test/data/app/view/info.php
@@ -7,6 +7,9 @@
     .span {
         height: 15px; 
     }
+    h4 {
+        font-weight: 300;
+    }
 </style>
 <body>
 
@@ -23,6 +26,7 @@
 <div class="notice"><?php if (isset($notice)) echo $notice; ?></div>
 
 <h3>Don't do that at home!</h3>
+<h4>Check font-weight!</h4>
 
 <p>Is that interesting?</p>
 
diff --git a/test/helper/webapi.js b/test/helper/webapi.js
@@ -1369,8 +1369,8 @@ module.exports.tests = function () {
 
       try {
         await I.amOnPage('/info');
-        await I.seeCssPropertiesOnElements('h3', {
-          'font-weight': 'bold',
+        await I.seeCssPropertiesOnElements('h4', {
+          'font-weight': 300,
         });
         await I.seeCssPropertiesOnElements('h3', {
           'font-weight': 'bold',
