corrected bugs

Author: jgauffin

src/Server/Coderr.Server.ReportAnalyzer/ApplicationVersions/Handlers/GetVersionFromReport.cs

@@ -45,14 +45,14 @@ public async Task HandleAsync(IMessageContext context, ReportAddedToIncident e)
 
             _repository.SaveIncidentVersion(e.Incident.Id, versionEntity.Id);
 
-            await IncreaseReportCounter(versionEntity.Id, isNewIncident);
+            await IncreaseReportCounter(versionEntity.Id, isNewIncident, e.Report.CreatedAtUtc);
         }
 
-        private async Task IncreaseReportCounter(int versionId, bool isNewIncident)
+        private async Task IncreaseReportCounter(int versionId, bool isNewIncident, DateTime reportedAtUtc)
         {
             var month =
-                await _repository.FindMonthForApplicationAsync(versionId, DateTime.Today.Year, DateTime.Today.Month) ??
-                new ApplicationVersionMonth(versionId, new DateTime(DateTime.Today.Year, DateTime.Today.Month, 1));
+                await _repository.FindMonthForApplicationAsync(versionId, reportedAtUtc.Year, reportedAtUtc.Month) ??
+                new ApplicationVersionMonth(versionId, new DateTime(reportedAtUtc.Year, reportedAtUtc.Month, 1));
 
             if (isNewIncident)
                 month.IncreaseIncidentCount();

src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/Suggestions.vue.html

@@ -6,7 +6,7 @@
                     {{ suggestion.incidentName }} <span class="text-muted">[{{suggestion.exceptionType}}]</span>
                 </div>
                 <div class="card-body">
-                    <strong>Motivation: </strong>
+                    <strong>Criteria: </strong>
                     {{suggestion.reason}}
                     <div v-if="!applicationId">
                         Reported for: <router-link :to="{name: 'discoverApplication', params: {applicationId: suggestion.applicationId}}">{{suggestion.applicationName}}</router-link>

src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/incident.vue.html

@@ -5,10 +5,17 @@
                 <h3>{{incident.Description}} <small class="text-muted">[{{incident.FullName}}]</small></h3>
                 <div class="">
                     <a href="#" class="btn btn-light" v-on:click.prevent="$router.back()">&lt;&lt; Back ...</a>
-                    <button class="btn btn-outline-primary" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToMe">Assign to me</button>
-                    <button class="btn btn-outline-primary" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToSomeoneElse">Assign to ..</button>
-                    <button class="btn btn-outline-primary" v-if="!isClosed" v-on:click.prevent="close">Close</button>
-                    <button class="btn btn-outline-primary" v-if="!isClosed && !isIgnored" v-on:click.prevent="ignore">Ignore (hide) incident</button>
+                    <div class="dropdown float-right">
+                        <button class="btn btn-outline-primary dropdown-toggle" type="button" id="dropdownMenuButton" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
+                            What do you want to do?
+                        </button>
+                        <div class="dropdown-menu" aria-labelledby="dropdownMenuButton">
+                            <a class="dropdown-item" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToMe">Assign to me</a>
+                            <a class="dropdown-item" href="#" v-if="incident.IncidentState == 0" v-on:click.prevent="assignToSomeoneElse">Assign to ..</a>
+                            <a class="dropdown-item" href="#" v-if="!isClosed" v-on:click.prevent="close">Close</a>
+                            <a class="dropdown-item" href="#" v-if="!isClosed && !isIgnored" v-on:click.prevent="ignore">Ignore (hide) incident</a>
+                        </div>
+                    </div>
                 </div>
             </div>
         </div>

src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/search.ts

@@ -104,8 +104,10 @@ export default class IncidentSearchComponent extends Vue {
                     if (id > 0) {
                         this.activeApplications.push(id);
                     }
+                } else {
+                    this.highlightActiveApps();
                 }
-                this.highlightActiveApps();
+                
                 this.highlightActiveTags();
                 this.highlightIncidentState(this.incidentState);
                 this.search(true);

src/Server/Coderr.Server.Web/ClientApp/components/home/navmenu/navmenu.vue.html

@@ -58,7 +58,7 @@
                             </router-link>
                         </li>
                         <li class="nav-item">
-                            <a href="#" class="nav-link" title="Log out">
+                            <a href="/account/logout" class="nav-link" title="Log out">
                                 <i class="fa fa-power-off"></i>
                             </a>
                         </li>

src/Server/Coderr.Server.Web/ClientApp/components/manage/application/security/security.vue.html

@@ -12,7 +12,7 @@ <h3>Admins</h3>
                                     {{admin.name}}
                                 </td>
                                 <td>
-                                    <a href="#" @click.prevent="removeAdmin(admin.id)" title="Downgrade to regular member"><i class="fa fa-hand-point-down text-warning"></i></a>
+                                    <a href="#" @click.prevent="removeAdmin(admin.id)" v-if="admins.length > 1" title="Downgrade to regular member"><i class="fa fa-hand-point-down text-warning"></i></a>
                                 </td>
                             </tr>
                         </table>

src/Server/Coderr.Server.Web/ClientApp/services/applications/ApplicationService.ts

@@ -34,8 +34,8 @@ export class ApplicationCreated {
 export class ApplicationSummary {
     readonly id: number;
     readonly name: string;
-    readonly sharedSecret: string;
-    readonly appKey: string;
+    sharedSecret: string;
+    appKey: string;
 
     constructor(id: number, name: string, sharedSecret: string, appKey: string) {
         this.id = id;
@@ -114,9 +114,19 @@ export class ApplicationService {
 
     async get(appId: number): Promise<ApplicationSummary> {
         for (var i = 0; i < this.applications.length; i++) {
-            if (this.applications[i].id === appId)
-                console.log('returning cahce', this.applications[i]);
-                return this.applications[i];
+            if (this.applications[i].id !== appId)
+                continue;
+
+            if (this.applications[i].appKey === 'n/a') {
+                const appQuery = new GetApplicationInfo();
+                appQuery.ApplicationId = appId;
+                const appInfo = await this.apiClient.query<GetApplicationInfoResult>(appQuery);
+                this.applications[i].appKey = appInfo.AppKey;
+                this.applications[i].sharedSecret = appInfo.SharedSecret;
+            }
+
+            console.log('returning cahce', this.applications[i]);
+            return this.applications[i];
         }
 
         var q = new GetApplicationInfo();
@@ -151,7 +161,7 @@ export class ApplicationService {
         if (id === 0) {
             throw new Error("Expected an incidentId");
         }
-        
+
         var q = new GetApplicationTeam();
         q.ApplicationId = id;
         var result = await this.apiClient.query<GetApplicationTeamResult>(q);