Added user registration tests + some UI tests refactoring

mjohanss · mjohanss · commit 3bd5de3dc210 · 2018-01-14T11:51:05.000+01:00
diff --git a/src/Server/Coderr.Server.SqlServer.Tests/Helpers/TestDataManager.cs b/src/Server/Coderr.Server.SqlServer.Tests/Helpers/TestDataManager.cs
@@ -12,6 +12,7 @@
 using codeRR.Server.SqlServer.Core.Accounts;
 using codeRR.Server.SqlServer.Core.Applications;
 using codeRR.Server.SqlServer.Core.Users;
+using codeRR.Server.SqlServer.Tests.Models;
 using Coderr.Server.PluginApi.Config;
 using Griffin.Data;
 using Griffin.Data.Mapper;
@@ -38,6 +39,8 @@ public TestDataManager(Func<IDbConnection> connectionFactory)
         /// </remarks>
         public int AccountId { get; private set; }
 
+        public TestUser TestUser { get; set; }
+
         public Application Application { get; private set; }
 
         /// <summary>
@@ -119,7 +122,7 @@ private void EnsureServerSettings(string baseUrl)
                 }
 
                 var sql = $@"INSERT INTO Settings (Section, Name, Value) VALUES
-('BaseConfig', 'AllowRegistrations', 'False'), 
+('BaseConfig', 'AllowRegistrations', 'True'), 
 ('BaseConfig', 'BaseUrl', '{baseUrl}'), 
 ('BaseConfig', 'SenderEmail', 'webtests@coderrapp.com'), 
 ('BaseConfig', 'SupportEmail', 'webtests@coderrapp.com'), 
@@ -184,11 +187,11 @@ public void ResetDatabase(string baseUrl)
         protected void CreateUserAndApplication(IAdoNetUnitOfWork uow, out int accountId, out int applicationId)
         {
             var accountRepos = new AccountRepository(uow);
-            var account = new Account("arne", "123456") {Email = "arne@som.com"};
+            var account = new Account(TestUser.Username, TestUser.Password) {Email = TestUser.Email};
             account.Activate();
             accountRepos.Create(account);
             var userRepos = new UserRepository(uow);
-            var user = new User(account.Id, "arne") {EmailAddress = "arne@som.com"};
+            var user = new User(account.Id, TestUser.Username) {EmailAddress =TestUser.Email};
             userRepos.CreateAsync(user).GetAwaiter().GetResult();
 
             var appRepos = new ApplicationRepository(uow);
diff --git a/src/Server/Coderr.Server.SqlServer.Tests/Models/TestUser.cs b/src/Server/Coderr.Server.SqlServer.Tests/Models/TestUser.cs
@@ -0,0 +1,9 @@
+﻿namespace codeRR.Server.SqlServer.Tests.Models
+{
+    public class TestUser
+    {
+        public string Username { get; set; }
+        public string Password { get; set; }
+        public string Email { get; set; }
+    }
+}
diff --git a/src/Server/Coderr.Server.Web.Tests/Helpers/Extensions/WebDriverExtensions.cs b/src/Server/Coderr.Server.Web.Tests/Helpers/Extensions/WebDriverExtensions.cs
@@ -20,12 +20,31 @@ public static bool ElementIsPresent(this IWebDriver driver, By by)
             return present;
         }
 
+        public static bool ElementIsPresent(this IWebDriver driver, IWebElement element)
+        {
+            var present = false;
+            try
+            {
+                present = element.Displayed;
+            }
+            catch (NoSuchElementException)
+            {
+            }
+            return present;
+        }
+
         public static bool WaitUntilElementIsPresent(this IWebDriver driver, By by, int timeout = 5)
         {
             var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(timeout));
             return wait.Until(d => d.ElementIsPresent(by));
         }
 
+        public static bool WaitUntilElementIsPresent(this IWebDriver driver, IWebElement element, int timeout = 5)
+        {
+            var wait = new WebDriverWait(driver, TimeSpan.FromSeconds(timeout));
+            return wait.Until(d => d.ElementIsPresent(element));
+        }
+
         public static string WaitUntilTitleEquals(this IWebDriver driver, string title, int timeout = 5)
         {
             try
diff --git a/src/Server/Coderr.Server.Web.Tests/Pages/Account/ActivationRequestedPage.cs b/src/Server/Coderr.Server.Web.Tests/Pages/Account/ActivationRequestedPage.cs
@@ -0,0 +1,17 @@
+﻿using OpenQA.Selenium;
+using OpenQA.Selenium.Support.UI;
+
+namespace codeRR.Server.Web.Tests.Pages.Account
+{
+    public class ActivationRequestedPage : BasePage
+    {
+        public ActivationRequestedPage(IWebDriver webDriver) : base(webDriver, (string) "Account/ActivationRequested", (string) "Account registered - codeRR")
+        {
+        }
+
+        public void VerifyIsCurrentPage()
+        {
+            Wait.Until(ExpectedConditions.TitleIs(Title));
+        }
+    }
+}
diff --git a/src/Server/Coderr.Server.Web.Tests/Pages/Account/LoginPage.cs b/src/Server/Coderr.Server.Web.Tests/Pages/Account/LoginPage.cs
@@ -2,14 +2,11 @@
 using OpenQA.Selenium.Support.PageObjects;
 using OpenQA.Selenium.Support.UI;
 
-namespace codeRR.Server.Web.Tests.Pages
+namespace codeRR.Server.Web.Tests.Pages.Account
 {
     public class LoginPage : BasePage
     {
-        private const string UserName = "arne";
-        private const string Password = "123456";
-
-        public LoginPage(IWebDriver webDriver) : base(webDriver, "Account/Login", "Login - codeRR")
+        public LoginPage(IWebDriver webDriver) : base(webDriver, (string) "Account/Login", (string) "Login - codeRR")
         {
         }
 
@@ -27,10 +24,10 @@ public HomePage LoginWithValidCredentials()
             NavigateToPage();
 
             UserNameField.Clear();
-            UserNameField.SendKeys(UserName);
+            UserNameField.SendKeys(TestUser.Username);
 
             PasswordField.Clear();
-            PasswordField.SendKeys(Password);
+            PasswordField.SendKeys(TestUser.Password);
 
             SignInButton.Click();
 
@@ -59,7 +56,7 @@ public LoginPage LoginWithNonExistingUserWithPasswordSpecified()
             UserNameField.SendKeys("NonExistingUsername");
 
             PasswordField.Clear();
-            PasswordField.SendKeys(Password);
+            PasswordField.SendKeys(TestUser.Password);
 
             SignInButton.Click();
 
@@ -73,7 +70,7 @@ public LoginPage LoginWithNoUserNameSpecified()
             UserNameField.Clear();
 
             PasswordField.Clear();
-            PasswordField.SendKeys(Password);
+            PasswordField.SendKeys(TestUser.Password);
 
             SignInButton.Click();
 
@@ -98,7 +95,7 @@ public LoginPage LoginWithNoPasswordSpecified()
             NavigateToPage();
 
             UserNameField.Clear();
-            UserNameField.SendKeys(UserName);
+            UserNameField.SendKeys(TestUser.Username);
 
             PasswordField.Clear();
 
@@ -112,10 +109,10 @@ public LoginPage LoginWithWrongPasswordSpecified()
             NavigateToPage();
 
             UserNameField.Clear();
-            UserNameField.SendKeys(UserName);
+            UserNameField.SendKeys(TestUser.Username);
 
             PasswordField.Clear();
-            PasswordField.SendKeys(Password.Substring(1));
+            PasswordField.SendKeys(TestUser.Password.Substring(1));
 
             SignInButton.Click();
 
diff --git a/src/Server/Coderr.Server.Web.Tests/Pages/Account/LogoutPage.cs b/src/Server/Coderr.Server.Web.Tests/Pages/Account/LogoutPage.cs
@@ -1,10 +1,10 @@
 ﻿using OpenQA.Selenium;
 
-namespace codeRR.Server.Web.Tests.Pages
+namespace codeRR.Server.Web.Tests.Pages.Account
 {
     public class LogoutPage : BasePage
     {
-        public LogoutPage(IWebDriver webDriver) : base(webDriver, "Account/Logout", "")
+        public LogoutPage(IWebDriver webDriver) : base(webDriver, (string) "Account/Logout", (string) "")
         {
         }
 
diff --git a/src/Server/Coderr.Server.Web.Tests/Pages/Account/RegisterPage.cs b/src/Server/Coderr.Server.Web.Tests/Pages/Account/RegisterPage.cs
@@ -0,0 +1,105 @@
+﻿using codeRR.Server.Web.Tests.Helpers.Extensions;
+using OpenQA.Selenium;
+using OpenQA.Selenium.Support.PageObjects;
+using OpenQA.Selenium.Support.UI;
+
+namespace codeRR.Server.Web.Tests.Pages.Account
+{
+    public class RegisterPage : BasePage
+    {
+        public RegisterPage(IWebDriver webDriver) : base(webDriver, (string) "Account/Register", (string) "Register account - codeRR")
+        {
+        }
+
+        [FindsBy(How = How.Id, Using = "UserName")]
+        public IWebElement UserNameField { get; set; }
+
+        [FindsBy(How = How.Id, Using = "Password")]
+        public IWebElement PasswordField { get; set; }
+
+        [FindsBy(How = How.Id, Using = "Password2")]
+        public IWebElement RetypePasswordField { get; set; }
+
+        [FindsBy(How = How.Id, Using = "Email")]
+        public IWebElement EmailField { get; set; }
+
+        [FindsBy(How = How.ClassName, Using = "btn-primary")]
+        public IWebElement SignUpButton { get; set; }
+
+        [FindsBy(How = How.ClassName, Using = "field-validation-error")]
+        public IWebElement ValidationErrorField { get; set; }
+
+        public void VerifyIsCurrentPage()
+        {
+            Wait.Until(ExpectedConditions.TitleIs(Title));
+        }
+
+        public RegisterPage RegisterUsingAlreadyTakenUsername()
+        {
+            NavigateToPage();
+
+            ClearForm();
+
+            UserNameField.SendKeys(TestUser.Username);
+            PasswordField.SendKeys(TestUser.Password);
+            RetypePasswordField.SendKeys(TestUser.Password);
+            EmailField.SendKeys(TestUser.Email);
+
+            SignUpButton.Click();
+
+            return this;
+        }
+
+        public RegisterPage RegisterUsingAlreadyTakenEmail()
+        {
+            NavigateToPage();
+
+            ClearForm();
+
+            UserNameField.SendKeys(TestUser.Username + "2");
+            PasswordField.SendKeys(TestUser.Password);
+            RetypePasswordField.SendKeys(TestUser.Password);
+            EmailField.SendKeys(TestUser.Email);
+
+            SignUpButton.Click();
+
+            return this;
+        }
+
+        public ActivationRequestedPage RegisterNewUser()
+        {
+            NavigateToPage();
+
+            ClearForm();
+
+            UserNameField.SendKeys(TestUser.Username + "2");
+            PasswordField.SendKeys(TestUser.Password);
+            RetypePasswordField.SendKeys(TestUser.Password);
+            EmailField.SendKeys("TestUser2@coderrapp.com");
+
+            SignUpButton.Click();
+
+            return new ActivationRequestedPage(WebDriver);
+        }
+
+        public RegisterPage VerifyUsernameIsAlreadyTaken()
+        {
+            WebDriver.WaitUntilElementIsPresent(ValidationErrorField);
+            return this;
+        }
+
+        public RegisterPage VerifyEmailIsAlreadyTaken()
+        {
+            WebDriver.WaitUntilElementIsPresent(ValidationErrorField);
+            return this;
+        }
+
+        private void ClearForm()
+        {
+            UserNameField.Clear();
+            PasswordField.Clear();
+            RetypePasswordField.Clear();
+            EmailField.Clear();
+        }
+    }
+}
diff --git a/src/Server/Coderr.Server.Web.Tests/Pages/BasePage.cs b/src/Server/Coderr.Server.Web.Tests/Pages/BasePage.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using codeRR.Server.SqlServer.Tests.Models;
 using OpenQA.Selenium;
 using OpenQA.Selenium.Support.PageObjects;
 using OpenQA.Selenium.Support.UI;
@@ -11,7 +12,9 @@ public class BasePage
         protected WebDriverWait Wait;
         protected string BaseUrl { get; }
         protected string Url { get; set; }
-        protected string Title { get; }
+        public string Title { get; }
+
+        protected readonly TestUser TestUser = WebTest.TestUser;
 
         public BasePage(IWebDriver webDriver, string url, string title)
         {
diff --git a/src/Server/Coderr.Server.Web.Tests/Tests/LoggedInTest.cs b/src/Server/Coderr.Server.Web.Tests/Tests/LoggedInTest.cs
@@ -1,4 +1,5 @@
 ﻿using codeRR.Server.Web.Tests.Pages;
+using codeRR.Server.Web.Tests.Pages.Account;
 using Xunit;
 
 namespace codeRR.Server.Web.Tests.Tests
diff --git a/src/Server/Coderr.Server.Web.Tests/Tests/LoginPageTests.cs b/src/Server/Coderr.Server.Web.Tests/Tests/LoginPageTests.cs
@@ -1,4 +1,5 @@
 ﻿using codeRR.Server.Web.Tests.Pages;
+using codeRR.Server.Web.Tests.Pages.Account;
 using Xunit;
 
 namespace codeRR.Server.Web.Tests.Tests
diff --git a/src/Server/Coderr.Server.Web.Tests/Tests/RegisterPageTests.cs b/src/Server/Coderr.Server.Web.Tests/Tests/RegisterPageTests.cs
@@ -0,0 +1,52 @@
+﻿using codeRR.Server.Web.Tests.Helpers.Extensions;
+using codeRR.Server.Web.Tests.Pages.Account;
+using Xunit;
+
+namespace codeRR.Server.Web.Tests.Tests
+{
+    [Trait("Category", "Integration")]
+    public class RegisterPageTests : LoggedInTest
+    {
+        [Fact]
+        public void Should_not_be_able_to_register_using_already_taken_username()
+        {
+            UITest(() =>
+            {
+                var sut = new RegisterPage(WebDriver)
+                    .RegisterUsingAlreadyTakenUsername();
+
+                Assert.IsType<RegisterPage>(sut);
+                sut.VerifyIsCurrentPage();
+
+                sut.VerifyUsernameIsAlreadyTaken();
+            });
+        }
+
+        [Fact]
+        public void Should_not_be_able_to_register_using_already_taken_email()
+        {
+            UITest(() =>
+            {
+                var sut = new RegisterPage(WebDriver)
+                    .RegisterUsingAlreadyTakenEmail();
+
+                Assert.IsType<RegisterPage>(sut);
+                sut.VerifyIsCurrentPage();
+
+                sut.VerifyEmailIsAlreadyTaken();
+            });
+        }
+
+        [Fact]
+        public void Should_be_able_to_register_user()
+        {
+            UITest(() =>
+            {
+                var sut = new RegisterPage(WebDriver)
+                    .RegisterNewUser();
+
+                Assert.Equal("Account registered - codeRR", WebDriver.WaitUntilTitleEquals(sut.Title));
+            });
+        }
+    }
+}
diff --git a/src/Server/Coderr.Server.Web.Tests/WebTest.cs b/src/Server/Coderr.Server.Web.Tests/WebTest.cs
@@ -5,6 +5,7 @@
 using System.Web.Configuration;
 using codeRR.Server.SqlServer.Core.Accounts;
 using codeRR.Server.SqlServer.Tests.Helpers;
+using codeRR.Server.SqlServer.Tests.Models;
 using codeRR.Server.Web.Tests.Helpers;
 using codeRR.Server.Web.Tests.Helpers.Selenium;
 using Griffin.Data.Mapper;
@@ -67,7 +68,10 @@ static WebTest()
                 webClient.DownloadString(_iisExpress.BaseUrl);
             }
 
-            TestData = new TestDataManager(_databaseManager.OpenConnection);
+            TestUser = new TestUser {Username = "TestUser", Password = "123456", Email = "TestUser@coderrapp.com"};
+
+            TestData = new TestDataManager(_databaseManager.OpenConnection) { TestUser = TestUser };
+
             WebDriver = DriverFactory.Create(BrowserType.Chrome);
             AppDomain.CurrentDomain.DomainUnload += (o, e) => { DisposeWebDriver(); };
         }
@@ -109,6 +113,8 @@ protected WebTest()
 
         public static IWebDriver WebDriver { get; private set; }
 
+        public static TestUser TestUser { get; set; }
+
         private static void DisposeWebDriver()
         {
             try

Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,10 @@`
`1`	`1`	`using OpenQA.Selenium;`
`2`	`2`
`3`		`-namespace codeRR.Server.Web.Tests.Pages`
	`3`	`+namespace codeRR.Server.Web.Tests.Pages.Account`
`4`	`4`	`{`
`5`	`5`	`public class LogoutPage : BasePage`
`6`	`6`	`{`
`7`		`- public LogoutPage(IWebDriver webDriver) : base(webDriver, "Account/Logout", "")`
	`7`	`+ public LogoutPage(IWebDriver webDriver) : base(webDriver, (string) "Account/Logout", (string) "")`
`8`	`8`	`{`
`9`	`9`	`}`
`10`	`10`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using codeRR.Server.Web.Tests.Pages;`
	`2`	`+using codeRR.Server.Web.Tests.Pages.Account;`
`2`	`3`	`using Xunit;`
`3`	`4`
`4`	`5`	`namespace codeRR.Server.Web.Tests.Tests`