* Added support for user notifications

* Activated the user bug report handler

Author: jgauffin

src/Server/Coderr.Server.Api/Core/Incidents/Commands/NotifySubscribers.cs

@@ -0,0 +1,39 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Coderr.Server.Api.Core.Incidents.Commands
+{
+    /// <summary>
+    /// Notify all users that have subscribed on an incident.
+    /// </summary>
+    [Command]
+    public class NotifySubscribers
+    {
+        public NotifySubscribers(int incidentId)
+        {
+            if (incidentId <= 0) throw new ArgumentOutOfRangeException(nameof(incidentId));
+            IncidentId = incidentId;
+        }
+
+        protected NotifySubscribers()
+        {
+
+        }
+           
+        /// <summary>
+        /// Incident id
+        /// </summary>
+        public int IncidentId { get; private set; }
+        /// <summary>
+        ///     Text to send as email body
+        /// </summary>
+        public string Body { get; set; }
+
+        /// <summary>
+        ///     Title of outbound notification.
+        /// </summary>
+        public string Title { get; set; }
+
+    }
+}

src/Server/Coderr.Server.App/Core/Incidents/Commands/NotifySubscribersHandler.cs

@@ -0,0 +1,36 @@
+using System.Linq;
+using System.Threading.Tasks;
+using Coderr.Server.Api.Core.Incidents.Commands;
+using Coderr.Server.Api.Core.Messaging;
+using Coderr.Server.Api.Core.Messaging.Commands;
+using Coderr.Server.Domain.Core.Feedback;
+using DotNetCqs;
+
+namespace Coderr.Server.App.Core.Incidents.Commands
+{
+    internal class NotifySubscribersHandler : IMessageHandler<NotifySubscribers>
+    {
+        private readonly IFeedbackRepository _feedbackRepository;
+
+        public NotifySubscribersHandler(IFeedbackRepository feedbackRepository)
+        {
+            _feedbackRepository = feedbackRepository;
+        }
+
+
+        public async Task HandleAsync(IMessageContext context, NotifySubscribers message)
+        {
+            var emails = await _feedbackRepository.GetEmailAddressesAsync(message.IncidentId);
+            if (!emails.Any())
+                return;
+
+            var emailMessage = new EmailMessage(emails)
+            {
+                Subject = message.Title,
+                TextBody = message.Body
+            };
+            var sendMessage = new SendEmail(emailMessage);
+            await context.SendAsync(sendMessage);
+        }
+    }
+}

src/Server/Coderr.Server.App/Modules/Messaging/Commands/SendEmailHandler.cs

@@ -48,17 +48,7 @@ public async Task HandleAsync(IMessageContext context, SendEmail command)
 
             var markdownHtml = Markdown.ToHtml(command.EmailMessage.TextBody ?? "");
 
-            foreach (var recipient in command.EmailMessage.Recipients)
-            {
-                if (int.TryParse(recipient.Address, out var accountId))
-                {
-                    var query = new GetAccountEmailById(accountId);
-                    var emailAddress = await context.QueryAsync(query);
-                    email.To.Add(new MailAddress(emailAddress, recipient.Name));
-                }
-                else
-                    email.To.Add(new MailAddress(recipient.Address, recipient.Name));
-            }
+
             if (string.IsNullOrEmpty(command.EmailMessage.HtmlBody) && markdownHtml == command.EmailMessage.TextBody)
             {
                 email.Body = command.EmailMessage.TextBody;
@@ -87,7 +77,23 @@ public async Task HandleAsync(IMessageContext context, SendEmail command)
             }
 
             email.AlternateViews.Add(av);
-            await client.SendMailAsync(email);
+
+            // Send one email per recipient to not share addresses.
+            foreach (var recipient in command.EmailMessage.Recipients)
+            {
+                email.To.Clear();
+                if (int.TryParse(recipient.Address, out var accountId))
+                {
+                    var query = new GetAccountEmailById(accountId);
+                    var emailAddress = await context.QueryAsync(query);
+                    email.To.Add(new MailAddress(emailAddress, recipient.Name));
+                }
+                else
+                    email.To.Add(new MailAddress(recipient.Address, recipient.Name));
+
+                await client.SendMailAsync(email);
+            }
+            
         }
 
         private SmtpClient CreateSmtpClient()

…edback/Handlers/SubmitFeedbackHandler.cs …r/Core/Feedback/SubmitFeedbackHandler.cssrc/Server/Coderr.Server.ReportAnalyzer/Feedback/Handlers/SubmitFeedbackHandler.cs renamed to src/Server/Coderr.Server.SqlServer/Core/Feedback/SubmitFeedbackHandler.cs src/Server/Coderr.Server.ReportAnalyzer/Feedback/Handlers/SubmitFeedbackHandler.cs renamed to src/Server/Coderr.Server.SqlServer/Core/Feedback/SubmitFeedbackHandler.cs

@@ -8,9 +8,8 @@
 using Griffin.Data;
 using log4net;
 
-namespace Coderr.Server.ReportAnalyzer.Feedback.Handlers
+namespace Coderr.Server.SqlServer.Core.Feedback
 {
-    //TODO: Move SQL parts to the data project.
     public class SubmitFeedbackHandler : IMessageHandler<SubmitFeedback>
     {
         private readonly ILog _logger = LogManager.GetLogger(typeof(SubmitFeedbackHandler));
@@ -56,8 +55,7 @@ public async Task HandleAsync(IMessageContext context, SubmitFeedback command)
                 catch (Exception exception)
                 {
                     _logger.Error(
-                        string.Format("{0}: Failed to store '{1}' '{2}'", command.ErrorId, command.Email,
-                            command.Feedback), exception);
+                        $"{command.ErrorId}: Failed to store '{command.Email}' '{command.Feedback}'", exception);
                     //hide errors.
                 }
 

src/Server/Coderr.Server.SqlServer/SqlServerTools.cs

@@ -26,8 +26,6 @@ public SqlServerTools(Func<IDbConnection> connectionFactory)
             _connectionFactory = connectionFactory ?? throw new ArgumentNullException(nameof(connectionFactory));
             _schemaManager = new SchemaManager(_connectionFactory);
         }
-
-        internal static string DbName { get; set; }
 
         /// <summary>
         ///     Checks if the tables exists and are for the current DB schema.

src/Server/Coderr.Server.Web/Areas/Installation/WizardSteps.cs

@@ -66,12 +66,12 @@ private static int FindCurrentIndex(IUrlHelper urlHelper)
                 if (Steps[i].IsForAbsolutePath(currentPath, urlHelper))
                     return i;
             }
-
             // in ASP.NET Core, the virtual path is in PathBase and the rest in Path
             // this we only need to check if the path is root (while the wizard link is for ./installation)
-            if (urlHelper.ActionContext.HttpContext.Request.Path == "")
+            // It's "/" when there is no virtual directory and "" when there is one. Go figure.
+            if (urlHelper.ActionContext.HttpContext.Request.Path == "" || urlHelper.ActionContext.HttpContext.Request.Path == "/")
                 return 0;
-
+            
             return -1;
         }
     }

src/Server/Coderr.Server.Web/ClientApp/boot.ts

@@ -143,6 +143,11 @@ const routes = [
                 name: "analyzeFeedback",
                 path: "incident/:incidentId/feedback/",
                 component: require("./components/analyze/incidents/feedback.vue.html")
+            },
+            {
+                name: "analyzeNotifyUsers",
+                path: "incident/:incidentId/notify/",
+                component: require("./components/analyze/incidents/status.vue.html")
             }
         ]
     },

src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/incident.ts

@@ -58,6 +58,13 @@ export default class AnalyzeIncidentComponent extends Vue {
     closeIncident() {
         AppRoot.Instance.incidentService.showClose(this.incident.Id, "CloseBody")
             .then(x => {
+                if (x.requiresStatusUpdate) {
+                    this.$router.push({
+                        name: 'analyzeNotifyUsers',
+                        params: { incidentId: this.incident.Id.toString() }
+                    });
+                    return;
+                }
                 AppRoot.Instance.incidentService.getMine(null, this.incident.Id)
                     .then(incidents => {
                         if (incidents.length === 0) {

src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/status.css

@@ -0,0 +1,14 @@
+.IncidentView .tags span {
+    margin-right: 5px;
+}
+.tags button {
+    margin-right: 5px;
+}
+
+.more {
+    display: none;
+}
+
+.feedback.col {
+    min-width: 500px;
+}

src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/status.ts

@@ -0,0 +1,51 @@
+import { PubSubService } from "../../../services/PubSub";
+import { AppRoot } from '../../../services/AppRoot';
+import * as feedback from "../../../dto/Web/Feedback";
+import {NotifySubscribers} from "../../../dto/Core/Incidents";
+import Vue from "vue";
+import { Component, Watch } from "vue-property-decorator";
+
+interface IFeedback {
+    description: string;
+    email: string;
+    writtenAtUtc: Date;
+}
+
+@Component
+export default class AnalyzeStatusUpdateComponent extends Vue {
+
+    incidentId = 0;
+    emailList = "";
+    title = "";
+    body="";
+
+    created() {
+        this.incidentId = parseInt(this.$route.params.incidentId, 10);
+
+        var q = new feedback.GetIncidentFeedback();
+        q.IncidentId = this.incidentId;
+        AppRoot.Instance.apiClient.query<feedback.GetIncidentFeedbackResult>(q)
+            .then(result => {
+                var items: string[] = [];
+                result.Items.forEach(x => {
+                    if (x.EmailAddress) {
+                        items.push(x.EmailAddress);
+                    }
+                });
+                this.emailList = items.join(', ');
+            });
+    }
+
+    send() {
+        var cmd = new NotifySubscribers();
+        cmd.IncidentId = this.incidentId;
+        cmd.Body = this.body;
+        cmd.Title = this.title;
+        AppRoot.Instance.apiClient.command(cmd)
+            .then(x => {
+                AppRoot.notify('Message have been sent.');
+                this.$router.push({ name: 'analyzeHome' });
+            });
+    }
+
+}