menu bug fixes.

Author: jgauffin

src/Server/Coderr.Server.Web/ClientApp/components/analyze/incidents/incident.ts

@@ -28,11 +28,7 @@ export default class AnalyzeIncidentComponent extends Vue {
 
     created() {
         MyIncidents.Instance.subscribeOnSelectedIncident(x => {
-            if (x == null) {
-                this.$router.push({ name: 'analyzeHome' });
-            } else {
-                this.loadIncident(x.incidentId);
-            }
+            this.selectIncident(x);
         });
     }
 
@@ -41,6 +37,10 @@ export default class AnalyzeIncidentComponent extends Vue {
         this.loadIncident(incidentId);
     }
 
+    destroyed() {
+        MyIncidents.Instance.unsubscribe(this.selectIncident);
+    }
+
     reAssign() {
         AppRoot.modal({
             contentId: 'assignToModal',
@@ -162,4 +162,11 @@ export default class AnalyzeIncidentComponent extends Vue {
     }
 
 
+    selectIncident(myIncident: IMyIncident | null): void {
+        if (myIncident == null) {
+            this.$router.push({ name: 'analyzeHome' });
+        } else {
+            this.loadIncident(myIncident.incidentId);
+        }
+    }
 }

src/Server/Coderr.Server.Web/ClientApp/components/analyze/menu.ts

@@ -20,8 +20,8 @@ export default class AnalyzeMenuComponent extends Vue {
     incidentId: number | null = null;
 
     created() {
-        MyIncidents.Instance.subscribeOnSelectedIncident(x => this.onIncidentSelected(x));
-        MyIncidents.Instance.subscribeOnListChanges(() => this.onListChanged());
+        MyIncidents.Instance.subscribeOnSelectedIncident(this.onIncidentSelected);
+        MyIncidents.Instance.subscribeOnListChanges(this.onListChanged);
         MyIncidents.Instance.ready()
             .then(x => {
                 this.incidents = MyIncidents.Instance.myIncidents;
@@ -86,7 +86,6 @@ export default class AnalyzeMenuComponent extends Vue {
         } else {
             var newIncidentId = parseInt(value, 10);
             if (this.incidentId === newIncidentId) {
-                console.log('exiting')
                 return;
             }
             this.incidentId = newIncidentId;