Bug fixes

Author: jgauffin

src/Server/Coderr.Server.App/Core/Applications/QueryHandlers/GetMyApplications.cs

@@ -46,7 +46,7 @@ public async Task<ApplicationListItem[]> HandleAsync(IMessageContext context, Ge
             var isSysAdmin = false;
             if (query.AccountId > 0)
             {
-                var account = await _accountRepository.GetByIdAsync((int) query.AccountId);
+                var account = await _accountRepository.GetByIdAsync((int)query.AccountId);
                 if (account.IsSysAdmin)
                 {
                     query.AccountId = 0;

src/Server/Coderr.Server.App/Core/Incidents/Jobs/DeleteEmptyIncidents.cs

@@ -43,7 +43,7 @@ public async Task ExecuteAsync()
             using (var cmd = _unitOfWork.CreateDbCommand())
             {
                 cmd.CommandText =
-                    $@"DELETE TOP(1000) Incidents 
+                    $@"DELETE TOP(500) Incidents 
                        WHERE LastReportAtUtc < @retentionDays";
 
                 // Wait until no reports have been received for the specified report save time

src/Server/Coderr.Server.SqlServer/Coderr.Server.SqlServer.csproj

@@ -28,5 +28,6 @@
     <None Remove="Schema\Update.v11.sql" />
     <None Remove="Schema\Update.v12.sql" />
     <None Remove="Schema\Update.v13.sql" />
+    <None Remove="Schema\Update.v14.sql" />
   </ItemGroup>
 </Project>

src/Server/Coderr.Server.SqlServer/Core/Applications/ApplicationRepository.cs

@@ -34,7 +34,8 @@ public async Task<UserApplication[]> GetForUserAsync(int accountId)
                 cmd.CommandText = @"SELECT a.Id ApplicationId, a.Name ApplicationName, ApplicationMembers.Roles
                                         FROM Applications a
                                         JOIN ApplicationMembers ON (ApplicationMembers.ApplicationId = a.Id) 
-                                        WHERE ApplicationMembers.AccountId = @userId";
+                                        WHERE ApplicationMembers.AccountId = @userId
+                                        ORDER BY Name";
                 cmd.AddParameter("userId", accountId);
                 using (var reader = await cmd.ExecuteReaderAsync())
                 {
@@ -167,7 +168,7 @@ public async Task<Application[]> GetAllAsync()
         {
             using (var cmd = (DbCommand) _uow.CreateCommand())
             {
-                cmd.CommandText = "SELECT * FROM Applications";
+                cmd.CommandText = "SELECT * FROM Applications ORDER BY Name";
 
                 //cmd.AddParameter("ids", string.Join(", ", appIds.Select(x => "'" + x + "'")));
                 var result = await cmd.ToListAsync<Application>();

src/Server/Coderr.Server.SqlServer/Core/Incidents/Queries/FindIncidentsHandler.cs

@@ -122,6 +122,7 @@ SELECT Distinct IncidentId
                                         FROM ErrorReports 
                                         WHERE StackTrace LIKE @FreeText 
                                             OR ErrorReports.Title LIKE @FreeText
+                                            OR ErrorReports.ErrorId LIKE @FreeText
                                             OR Incidents.Description LIKE @FreeText)
                                     )";
                     cmd.AddParameter("FreeText", $"%{query.FreeText}%");

src/Server/Coderr.Server.SqlServer/Schema/Update.v14.sql

@@ -0,0 +1,3 @@
+--alter table ApplicationVersions alter column Version varchar(20) not null;
+
+--UPDATE DatabaseSchema SET Version = 14;

src/Server/Coderr.Server.Web/Areas/Installation/Controllers/SqlController.cs

@@ -8,7 +8,7 @@
 namespace Coderr.Server.Web.Areas.Installation.Controllers
 {
     [Area("Installation")]
-    
+
     public class SqlController : Controller
     {
         private static int _counter;
@@ -79,9 +79,10 @@ public ActionResult Tables(string go)
 
         public ActionResult Validate()
         {
+            string constr = "Not set";
             try
             {
-                var constr = _config.GetConnectionString("Db");
+                constr = _config.GetConnectionString("Db");
                 constr = ChangeConnectionTimeout(constr);
                 SetupTools.DbTools.TestConnection(constr);
                 return Content(@"{ ""result"": ""ok"" }", "application/json");
@@ -95,7 +96,7 @@ public ActionResult Validate()
                 return Json(new
                 {
                     result = "fail",
-                    reason = errMsg,
+                    reason = errMsg + "<br>Connection string: " + constr,
                     attempt = ++_counter
                 });
             }

src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/search.ts

@@ -182,11 +182,14 @@ export default class IncidentSearchComponent extends Vue {
         query.FreeText = this.freeText;
 
         switch (this.incidentState) {
+            case -1:
+                break;
             case 0:
                 query.IsNew = true;
                 break;
             case 1:
                 query.IsAssigned = true;
+                break;
             case 3:
                 query.IsClosed = true;
                 break;
@@ -204,7 +207,7 @@ export default class IncidentSearchComponent extends Vue {
             query.ApplicationIds = this.activeApplications;
         }
 
-        if (byCode !== true) {
+        if (!byCode) {
             AppRoot.Instance.storeState({
                 name: 'incident-search',
                 component: this,
@@ -287,7 +290,7 @@ export default class IncidentSearchComponent extends Vue {
             this.activeApplications = [body.applicationId];
             this.showApplicationColumn = false;
         }
-            
+
         this.search();
     }
     private drawSearchUi() {

src/Server/Coderr.Server.Web/ClientApp/components/discover/incidents/search.vue.html

@@ -30,6 +30,11 @@ <h4>Tags</h4>
                         <div class="state">
                             <h4>Incident state</h4>
                             <div class="row text-nowrap">
+                                <div class="col">
+                                    <button class="btn btn-dark" v-model="incidentState" value="-1" v-on:click.prevent="toggleState(-1, $event)">
+                                        All
+                                    </button>
+                                </div>
                                 <div class="col">
                                     <button class="btn btn-dark" v-model="incidentState" value="0" v-on:click.prevent="toggleState(0, $event)">
                                         New

src/Server/Coderr.Server.Web/Coderr.Server.Web.csproj

@@ -19,7 +19,7 @@
   </ItemGroup>-->
 
   <ItemGroup>
-    <PackageReference Include="Coderr.Client.AspNetCore.Mvc" Version="1.1.2" />
+    <PackageReference Include="Coderr.Client.AspNetCore.Mvc" Version="1.1.3" />
     <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.6" />
     <PackageReference Include="Griffin.Framework" Version="2.0.0-alpha01" />
     <PackageReference Include="Microsoft.AspNetCore.Authentication.Cookies" Version="2.0.3" />