Can now handle logical errors.

Author: jgauffin

src/Server/Coderr.Server.ReportAnalyzer/ErrorReports/HashCodeGenerator.cs

@@ -66,14 +66,34 @@ protected virtual string DefaultCreateHashCode(ErrorReportEntity report)
 
 
             var hashSource = $"{report.Exception.FullName ?? report.Exception.Name}\r\n";
+            var foundHashSource = false;
 
             // the client libraries can by themselves specify how we should identify
             // unqiue incidents. We then use that identifier in combination with the exception name.
             var collection = report.ContextCollections.FirstOrDefault(x => x.Name == "CoderrData");
-            if (collection != null && collection.Properties.TryGetValue("HashSource", out var reportHashSource))
-                hashSource += reportHashSource;
-            else
-                hashSource += StripLineNumbers(report.Exception.StackTrace ?? "");
+            if (collection != null)
+            {
+                if (collection.Properties.TryGetValue("HashSource", out var reportHashSource))
+                {
+                    foundHashSource = true;
+                    hashSource += reportHashSource;
+                }
+                else
+                    hashSource += StripLineNumbers(report.Exception.StackTrace ?? "");
+            }
+            if (!foundHashSource)
+            {
+                // This identifier is determined by the developer when  the error is generated.
+                foreach (var contextCollection in report.ContextCollections)
+                {
+                    if (!contextCollection.Properties.TryGetValue("ErrorHashSource", out var ourHashSource)) 
+                        continue;
+
+                    hashSource = ourHashSource;
+                    break;
+                }
+            }
+            
 
             var hash = 23;
             foreach (var c in hashSource)

src/Server/Coderr.Server.Web/Controllers/ReportReceiverController.cs

@@ -9,7 +9,6 @@
 using Coderr.Server.App.Core.Reports.Config;
 using Coderr.Server.ReportAnalyzer.Inbound;
 using Coderr.Server.Web.Infrastructure;
-using Coderr.Server.Web.Infrastructure.Misc;
 using Coderr.Server.Web.Infrastructure.Results;
 using DotNetCqs.Queues;
 using Griffin.Data;
@@ -55,9 +54,6 @@ public async Task<IActionResult> Post(string appKey, string sig)
                 return await KillLargeReportAsync(appKey);
             if (contentLength == null || contentLength < 1)
                 return BadRequest("Content required.");
-
-            if (!IsBelowReportLimit()) return NoContent();
-
             try
             {
                 var buffer = new byte[contentLength.Value];
@@ -112,30 +108,6 @@ internal static ClaimsPrincipal CreateReporterPrincipal()
             return principal;
         }
 
-        private bool IsBelowReportLimit()
-        {
-            if (!string.IsNullOrEmpty(License.LicensedTo))
-                return true;
-
-            var count = License.Count / 5;
-            count = count / 10;
-
-            if (_currentReportCount == 0)
-                using (var cmd = _unitOfWork.CreateDbCommand())
-                {
-                    var from = new DateTime(DateTime.Today.Year, DateTime.Today.Month, 1);
-                    cmd.CommandText =
-                        "SELECT count(*) FROM ErrorReports WHERE CreatedAtUtc >= @from AND CreatedAtUtc <= @to";
-                    cmd.AddParameter("from", from);
-                    cmd.AddParameter("to", DateTime.Now);
-                    _currentReportCount = (int) cmd.ExecuteScalar();
-                }
-            else
-                _currentReportCount++;
-
-            return _currentReportCount < count;
-        }
-
         private Task<IActionResult> KillLargeReportAsync(string appKey)
         {
             _logger.Error(appKey + "Too large report: " + Request.ContentLength + " from " +