Remove compiler warnings and messages

delete editorConfig

Author: codingseb

CodingSeb.ExpressionEvaluator.Tests/ExpressionEvaluatorTests.cs

@@ -1179,7 +1179,6 @@ public static IEnumerable<TestCaseData> TestCasesForWithCustomVariablesExpressio
                 yield return new TestCaseData("expObj.NullValue ?? \"A\"", ExpandoObjectVariables, true).SetCategory("ExpandoObject").SetCategory("Instance Property").Returns("A");
                 #endregion
 
-
                 #endregion
 
                 #region Delegates as a variable
@@ -1494,7 +1493,7 @@ public static IEnumerable<TestCaseData> TestCasesForExceptionThrowingEvaluation
                 yield return new TestCaseData(evaluator, "false || 1/0>0", typeof(DivideByZeroException)).SetCategory("Conditional Or, positive left operand (should lead to exception associativity)");
                 yield return new TestCaseData(evaluator, "true && (true && 1/0>0)", typeof(DivideByZeroException)).SetCategory("Conditional And, positive left operand (should lead to exception)");
                 yield return new TestCaseData(evaluator, "false || (false || 1/0>0)", typeof(DivideByZeroException)).SetCategory("Conditional Or, positive left operand (should lead to exception associativity)");
-                
+
                 #endregion
             }
         }
@@ -1638,9 +1637,9 @@ public static IEnumerable<TestCaseData> TestCasesEvaluateWithSpecificEvaluator
                     .SetCategory("Integer Numbers default types");
 
                 yield return new TestCaseData(new ExpressionEvaluator
-                    {
-                        OptionForceIntegerNumbersEvaluationsAsDoubleByDefault = false
-                    }
+                {
+                    OptionForceIntegerNumbersEvaluationsAsDoubleByDefault = false
+                }
                     , "(130-120)/(2*250)"
                     , null)
                     .Returns(0)
@@ -2021,12 +2020,12 @@ void Evaluator_PreEvaluateVariable(object sender, VariablePreEvaluationEventArg
 
                 yield return new TestCaseData(xExpressionEvaluator1
                     , "true || true"
-                    , new Func<Exception, object> (exception =>
-                    {
-                        exception.ShouldNotBeOfType<ExpressionEvaluatorSyntaxErrorException>();
+                    , new Func<Exception, object>(exception =>
+                   {
+                       exception.ShouldNotBeOfType<ExpressionEvaluatorSyntaxErrorException>();
 
-                        return true;
-                    }))
+                       return true;
+                   }))
                     .Returns(true)
                     .SetCategory("ExpressionEvaluator extend")
                     .SetCategory("inherits ExpressionEvaluator")
@@ -2160,7 +2159,7 @@ void Evaluator_PreEvaluateVariable(object sender, VariablePreEvaluationEventArg
                     , "Persons.Sum(x=>x.Number)"
                     , null)
                     .Returns(23.22m)
-                    .SetCategory("Bug resolution"); 
+                    .SetCategory("Bug resolution");
 
                 yield return new TestCaseData(new ExpressionEvaluator() { Context = new { Persons } }
                     , "Persons.Average(x=>x.Number)"

CodingSeb.ExpressionEvaluator.Tests/GlobalSuppressions.cs

@@ -0,0 +1,13 @@
+// This file is used by Code Analysis to maintain SuppressMessage
+// attributes that are applied to this project.
+// Project-level suppressions either have no target or are given
+// a specific target and scoped to a namespace, type, member, etc.
+
+using System.Diagnostics.CodeAnalysis;
+
+[assembly: SuppressMessage("Design", "RCS1169:Make field read-only.", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]
+[assembly: SuppressMessage("Style", "IDE0044:Add readonly modifier", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]
+[assembly: SuppressMessage("CodeQuality", "IDE0051:Remove unused private members", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]
+[assembly: SuppressMessage("Redundancy", "RCS1213:Remove unused member declaration.", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]
+[assembly: SuppressMessage("CodeQuality", "IDE0051:Remove unused private members", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]
+[assembly: SuppressMessage("Design", "RCS1170:Use read-only auto-implemented property.", Justification = "<Pending>", Scope = "namespaceanddescendants", Target = "~N:CodingSeb.ExpressionEvaluator.Tests")]

CodingSeb.ExpressionEvaluator.Tests/TestsUtils/ClassWithNonPublicMembersAndMethods.cs

@@ -1,24 +1,16 @@
-namespace CodingSeb.ExpressionEvaluator.Tests
+#pragma warning disable 414
+namespace CodingSeb.ExpressionEvaluator.Tests
 {
     public class ClassWithNonPublicMembersAndMethods
     {
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "RCS1169:Make field read-only.", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1213:Remove unused member declaration.", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE0044:Add readonly modifier", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Code Quality", "IDE0051:Remove unused private members", Justification = "<Pending>")]
         private int myPrivateField = 5;
 
         protected int myProtectedField = 10;
 
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "RCS1170:Use read-only auto-implemented property.", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1213:Remove unused member declaration.", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Code Quality", "IDE0051:Remove unused private members", Justification = "<Pending>")]
         private int MyPrivateProperty { get; set; } = 15;
 
         protected int MyProtectedProperty { get; set; } = 20;
 
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Redundancy", "RCS1213:Remove unused member declaration.", Justification = "<Pending>")]
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Code Quality", "IDE0051:Remove unused private members", Justification = "<Pending>")]
         private string MyPrivateMethod(string name)
         {
             return "Hello " + name;

CodingSeb.ExpressionEvaluator.sln

@@ -1,4 +1,4 @@
-
+
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio Version 16
 VisualStudioVersion = 16.0.28729.10

CodingSeb.ExpressionEvaluator/CodingSeb.ExpressionEvaluator.csproj

@@ -17,6 +17,7 @@
     <TargetFrameworks>net45;netstandard2.0</TargetFrameworks>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <PackageIconUrl>https://github.com/codingseb/ExpressionEvaluator/blob/master/Icon.png?raw=true</PackageIconUrl>
+    <PackageIcon>Icon.png</PackageIcon>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <PackageReleaseNotes>* Better exception when expression is empty</PackageReleaseNotes>
     <PackageLicenseFile>LICENSE.md</PackageLicenseFile>
@@ -36,6 +37,10 @@
     <PackageReference Include="System.Dynamic.Runtime" Version="4.3.0" />
   </ItemGroup>
   <ItemGroup>
+    <None Include="..\Icon.png">
+      <Pack>True</Pack>
+      <PackagePath></PackagePath>
+    </None>
     <None Include="..\LICENSE.md">
       <Pack>True</Pack>
       <PackagePath></PackagePath>