Fix install issue and update setup.py

Author: shenxianpeng

README.md

@@ -2,7 +2,7 @@
 
 [![codecov](https://codecov.io/gh/shenxianpeng/clang-tools-pip/branch/master/graph/badge.svg?token=40G5ZOIRRR)](https://codecov.io/gh/shenxianpeng/clang-tools-pip) [![Python application](https://github.com/shenxianpeng/clang-tools-pip/actions/workflows/python-test.yml/badge.svg)](https://github.com/shenxianpeng/clang-tools-pip/actions/workflows/python-test.yml)
 
-Install clang-tools <sub><sup>(clang-format & clang-tidy)</sup></sub> with pip.
+Install clang-tools (clang-format, clang-tidy) with pip.
 
 ## Install
 

clang_tools/install.py

@@ -3,7 +3,7 @@
 import shutil
 import os
 from posixpath import basename
-from clang_tools.util import check_os
+from clang_tools.util import check_install_os
 from clang_tools.util import download_file
 
 def clang_format_exist(version) -> bool:
@@ -30,36 +30,37 @@ def clang_tidy_exist(version) -> bool:
         exist = False
     return exist
 
-def clang_tools_binary_url(tool, version, os) -> string:
-    return f"https://github.com/muttleyxd/clang-tools-static-binaries/releases/download/master-208096c1/{tool}-{version}_{os}-amd64"
+def clang_tools_binary_url(tool, version) -> string:
+    install_os = check_install_os()
+    return f"https://github.com/muttleyxd/clang-tools-static-binaries/releases/download/master-208096c1/{tool}-{version}_{install_os}-amd64"
 
 def install_clang_format(version) -> None:
     if clang_format_exist(version):
         return
-    clang_format_binary_url = clang_tools_binary_url("clang-format", version, os)
+    clang_format_binary_url = clang_tools_binary_url("clang-format", version)
     clang_format_binary = basename(clang_format_binary_url)
     download_file(clang_format_binary_url, clang_format_binary)
     install_clang_binary(clang_format_binary, f"clang-format-{version}")
 
 def install_clang_tidy(version) -> None:
     if clang_tidy_exist(version):
         return
-    clang_tidy_binary_url = clang_tools_binary_url("clang-tidy", version, os)
+    clang_tidy_binary_url = clang_tools_binary_url("clang-tidy", version)
     clang_tidy_binary = basename(clang_tidy_binary_url)
     download_file(clang_tidy_binary_url, clang_tidy_binary)
     install_clang_binary(clang_tidy_binary, f"clang-tidy-{version}")
 
 def install_clang_binary(old_file_name, new_file_name) -> None:
     """Move download clang-tools binary and move to bin dir with right permission."""
-    os = check_os()
-    if os in ['linux', 'macosx']:
+    install_os = check_install_os()
+    if install_os in ['linux', 'macosx']:
         clang_tools_dir = "/usr/bin"
-    elif os == "windows":
+    elif install_os == "windows":
         clang_tools_dir = "C:/bin"
     else:
-        raise Exception(f"Not support {os}")
+        raise Exception(f"Not support {install_os}")
     shutil.move(old_file_name, f"{clang_tools_dir}/{new_file_name}")
-    os.chmod(f"{clang_tools_dir}/{new_file_name}", "0777")
+    os.chmod(os.path.join(clang_tools_dir, new_file_name), 0o777)
 
 def install_clang_tools(version) -> None:
     install_clang_format(version)

clang_tools/util.py

@@ -4,7 +4,7 @@
 import platform
 
 
-def check_os() -> string:
+def check_install_os() -> string:
     os = platform.system().lower()
     return os
 

setup.py

@@ -1,12 +1,34 @@
 from setuptools import setup, find_packages
 
+with open("README.md", "r") as file:
+    long_description = file.read()
+
 setup(
     name="clang_tools",
     version = "0.0.1",
+    description="Install clang-tools (clang-format, clang-tidy) with pip",
+    long_description=long_description,
+    long_description_content_type="text/markdown",
     author="Peter Shen",
     author_email="xianpeng.shen@gmail.com",
-    keywords="clang clang-tools clang-extra clang-tidy clang-format",
+    keywords=["clang", "clang-tools", "clang-extra", "clang-tidy", "clang-format"],
+    license="MIT License",
     packages = find_packages(),
+    project_urls={
+        "Source": "https://github.com/shenxianpeng/clang-tools-pip",
+        "Tracker": "https://github.com/shenxianpeng/clang-tools-pip/issues"
+    },
+    classifiers=[
+        # https://pypi.org/pypi?%3Aaction=list_classifiers
+        "Development Status :: 1 - Planning",
+        "Intended Audience :: Developers",
+        "Intended Audience :: System Administrators",
+        "Intended Audience :: Information Technology",
+        "Natural Language :: English",
+        "Operating System :: OS Independent",
+        "Programming Language :: Python :: 3.8",
+        "Topic :: Utilities",
+    ],
     entry_points={
         "console_scripts": [
             "clang-tools=clang_tools.main:main"