feat: support install to a specified directory

Author: shenxianpeng

README.md

@@ -16,17 +16,21 @@ $ sudo pip install clang-tools
 
 ```bash
 $ sudo clang-tools --help
-usage: clang-tools [-h] [-i INSTALL]
+usage: clang-tools [-h] [-i INSTALL] [-d DIRECTORY]
 
 optional arguments:
   -h, --help            show this help message and exit
   -i INSTALL, --install INSTALL
                         Install clang-tools with specific version. default is 12.
+  -d DIRECTORY, --directory DIRECTORY
+                        The directory where is the clang-tools install.
 ```
 Use `clang-tools` command to install version 13 binaries.
 
 ```bash
 $ sudo clang-tools --install 13
+# Or install to a specified directory
+$ sudo clang-tools --install 13 --directory .
 
 $ clang-format-13 --version
 clang-format version 13.0.0

clang_tools/install.py

@@ -35,41 +35,45 @@ def clang_tidy_exist(version) -> bool:
 
 def clang_tools_binary_url(tool, version) -> string:
     install_os = check_install_os()
-    return f"https://github.com/muttleyxd/clang-tools-static-binaries/ \
-    releases/download/master-208096c1/{tool}-{version}_{install_os}-amd64"
+    url = f"https://github.com/muttleyxd/clang-tools-static-binaries/releases/ \
+    download/master-208096c1/{tool}-{version}_{install_os}-amd64".replace(" ", "")
+    return url
 
 
-def install_clang_format(version) -> None:
+def install_clang_format(version, directory) -> None:
     if clang_format_exist(version):
         return
     clang_format_binary_url = clang_tools_binary_url("clang-format", version)
     clang_format_binary = basename(clang_format_binary_url)
     download_file(clang_format_binary_url, clang_format_binary)
-    install_clang_binary(clang_format_binary, f"clang-format-{version}")
+    move_and_chmod_binary(clang_format_binary, f"clang-format-{version}", directory)
 
 
-def install_clang_tidy(version) -> None:
+def install_clang_tidy(version, directory) -> None:
     if clang_tidy_exist(version):
         return
     clang_tidy_binary_url = clang_tools_binary_url("clang-tidy", version)
     clang_tidy_binary = basename(clang_tidy_binary_url)
     download_file(clang_tidy_binary_url, clang_tidy_binary)
-    install_clang_binary(clang_tidy_binary, f"clang-tidy-{version}")
+    move_and_chmod_binary(clang_tidy_binary, f"clang-tidy-{version}", directory)
 
 
-def install_clang_binary(old_file_name, new_file_name) -> None:
+def move_and_chmod_binary(old_file_name, new_file_name, directory) -> None:
     """Move download clang-tools binary and move to bin dir with right permission."""
-    install_os = check_install_os()
-    if install_os in ['linux', 'macosx']:
-        clang_tools_dir = "/usr/bin"
-    elif install_os == "windows":
-        clang_tools_dir = "C:/bin"
+    if directory:
+        clang_tools_dir = directory
     else:
-        raise Exception(f"Not support {install_os}")
+        install_os = check_install_os()
+        if install_os in ['linux', 'macosx']:
+            clang_tools_dir = "/usr/bin"
+        elif install_os == "windows":
+            clang_tools_dir = "C:/bin"
+        else:
+            raise Exception(f"Not support {install_os}")
     shutil.move(old_file_name, f"{clang_tools_dir}/{new_file_name}")
     os.chmod(os.path.join(clang_tools_dir, new_file_name), 0o777)
 
 
-def install_clang_tools(version) -> None:
-    install_clang_format(version)
-    install_clang_tidy(version)
+def install_clang_tools(version, directory) -> None:
+    install_clang_format(version, directory)
+    install_clang_tidy(version, directory)

clang_tools/main.py

@@ -12,19 +12,18 @@ def main() -> int:
         help="Install clang-tools with specific version. default is 12.",
     )
 
-    # parser.add_argument(
-    #     "-d",
-    #     "--directory",
-    #     default="/usr/bin/",
-    #     help="The directory where is the clang-tools install.",
-    # )
+    parser.add_argument(
+        "-d",
+        "--directory",
+        default="",
+        help="The directory where is the clang-tools install.",
+    )
     args = parser.parse_args()
 
-    install_version = args.install
-    # install_dir = args.directory
+    version = args.install
+    directory = args.directory
 
-    if install_version:
-        install_clang_tools(install_version)
+    install_clang_tools(version, directory)
 
 
 if __name__ == '__main__':