fix: don't ignore errors

When capturing clang tools output,
any error encountered should cause fast-failure behavior.

Also adjust run_main() tests so that erroneous output is more helpful..

Author: 2bndy5

cpp-linter/src/clang_tools/mod.rs

@@ -248,14 +248,15 @@ pub async fn capture_clang_tools_output(
     }
 
     while let Some(output) = executors.join_next().await {
-        if let Ok(out) = output? {
-            let (file_name, logs) = out;
-            rest_api_client.start_log_group(format!("Analyzing {}", file_name.to_string_lossy()));
-            for (level, msg) in logs {
-                log::log!(level, "{}", msg);
-            }
-            rest_api_client.end_log_group();
+        // output?? acts as a fast-fail for any error encountered.
+        // This includes any `spawn()` error and any `analyze_single_file()` error.
+        // Any unresolved tasks are aborted and dropped when an error is returned here.
+        let (file_name, logs) = output??;
+        rest_api_client.start_log_group(format!("Analyzing {}", file_name.to_string_lossy()));
+        for (level, msg) in logs {
+            log::log!(level, "{}", msg);
         }
+        rest_api_client.end_log_group();
     }
     Ok(clang_versions)
 }

cpp-linter/src/run.rs

@@ -165,56 +165,57 @@ mod test {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "-l".to_string(),
             "false".to_string(),
             "--repo-root".to_string(),
             "tests".to_string(),
             "demo/demo.cpp".to_string(),
         ])
-        .await;
-        assert!(result.is_ok());
+        .await
+        .unwrap();
     }
 
     #[tokio::test]
     async fn version_command() {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec!["cpp-linter".to_string(), "version".to_string()]).await;
-        assert!(result.is_ok());
+        run_main(vec!["cpp-linter".to_string(), "version".to_string()])
+            .await
+            .unwrap();
     }
 
     #[tokio::test]
     async fn force_debug_output() {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "-l".to_string(),
             "false".to_string(),
             "-v".to_string(),
             "-i=target|benches/libgit2".to_string(),
         ])
-        .await;
-        assert!(result.is_ok());
+        .await
+        .unwrap();
     }
 
     #[tokio::test]
     async fn no_version_input() {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "-l".to_string(),
             "false".to_string(),
             "-V".to_string(),
         ])
-        .await;
-        assert!(result.is_ok());
+        .await
+        .unwrap();
     }
 
     #[tokio::test]
@@ -223,14 +224,14 @@ mod test {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
             env::set_var("PRE_COMMIT", "1");
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "--lines-changed-only".to_string(),
             "false".to_string(),
             "--ignore=target|benches/libgit2".to_string(),
         ])
-        .await;
-        assert!(result.is_err());
+        .await
+        .unwrap_err();
     }
 
     // Verifies that the system gracefully handles cases where all analysis is disabled.
@@ -240,29 +241,29 @@ mod test {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "-l".to_string(),
             "false".to_string(),
             "--style".to_string(),
             String::new(),
             "--tidy-checks=-*".to_string(),
         ])
-        .await;
-        assert!(result.is_ok());
+        .await
+        .unwrap();
     }
 
     #[tokio::test]
     async fn bad_repo_root() {
         unsafe {
             env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
         }
-        let result = run_main(vec![
+        run_main(vec![
             "cpp-linter".to_string(),
             "--repo-root".to_string(),
             "some-non-existent-dir".to_string(),
         ])
-        .await;
-        assert!(result.is_err());
+        .await
+        .unwrap_err();
     }
 }