refactor: change owner config json

Author: tanhongit

src/Commands/ChangeOwnerConfigJson.php

@@ -35,18 +35,33 @@ public function handle(): void
             return;
         }
 
-        $user = (string) ($this->argument('user') ?? '');
-        $group = (string) ($this->argument('group') ?? $user);
+        $user = $this->argument('user');
+        $group = $this->argument('group') ?? $user;
 
-        if (empty($user) || empty($group)) {
-            $group = $user = (string) exec('ps aux | egrep "(apache|httpd|nginx)" | grep -v "root" | head -n1 | cut -d\  -f1');
+        if (!is_string($user) || !is_string($group)) {
+            $user = $group = $this->getDefaultUserGroup();
         }
 
         $jsonsPath = config('telegram-git-notifier.data_file.storage_folder');
         if (is_string($jsonsPath) && file_exists($jsonsPath)) {
-            shell_exec("chown -R " . escapeshellarg($user) . ":" . escapeshellarg($group) . " " . escapeshellarg($jsonsPath));
+            shell_exec("chown -R ".escapeshellarg($user).":".escapeshellarg($group)." ".escapeshellarg($jsonsPath));
         } else {
             $this->error('The path to the jsons folder is not valid');
         }
     }
+
+    /**
+     * Get the default user and group for the chown command.
+     *
+     * @return string
+     */
+    private function getDefaultUserGroup(): string
+    {
+        $defaultUserGroup = exec('ps aux | egrep "(apache|httpd|nginx)" | grep -v "root" | head -n1 | cut -d\  -f1');
+        if ($defaultUserGroup === false) {
+            $this->error('Failed to retrieve default user and group');
+            return '';
+        }
+        return $defaultUserGroup;
+    }
 }