selftests: net: lib: fix shift count out of range

JIRA: https://issues.redhat.com/browse/RHEL-115594

commit 47c8499
Author: Hangbin Liu <liuhangbin@gmail.com>
Date:   Wed Jul 9 09:12:44 2025 +0000

    selftests: net: lib: fix shift count out of range

    I got the following warning when writing other tests:

      + handle_test_result_pass 'bond 802.3ad' '(lacp_active off)'
      + local 'test_name=bond 802.3ad'
      + shift
      + local 'opt_str=(lacp_active off)'
      + shift
      + log_test_result 'bond 802.3ad' '(lacp_active off)' ' OK '
      + local 'test_name=bond 802.3ad'
      + shift
      + local 'opt_str=(lacp_active off)'
      + shift
      + local 'result= OK '
      + shift
      + local retmsg=
      + shift
      /net/tools/testing/selftests/net/forwarding/../lib.sh: line 315: shift: shift count out of range

    This happens because an extra shift is executed even after all arguments
    have been consumed. Remove the last shift in log_test_result() to avoid
    this warning.

    Fixes: a923af1 ("selftests: forwarding: Convert log_test() to recognize RET values")
    Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
    Link: https://patch.msgid.link/20250709091244.88395-1-liuhangbin@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: CKI Backport Bot <cki-ci-bot+cki-gitlab-backport-bot@redhat.com>

Author: CKI Backport Bot

tools/testing/selftests/net/lib.sh

@@ -263,7 +263,7 @@ log_test_result()
 	local test_name=$1; shift
 	local opt_str=$1; shift
 	local result=$1; shift
-	local retmsg=$1; shift
+	local retmsg=$1
 
 	printf "TEST: %-60s  [%s]\n" "$test_name $opt_str" "$result"
 	if [[ $retmsg ]]; then