mei: vsc: Destroy mutex after freeing the IRQ

JIRA: https://issues.redhat.com/browse/RHEL-113185

commit 35b7f35
Author: Hans de Goede <hansg@kernel.org>
Date:   Mon Jun 23 10:50:47 2025 +0200

    mei: vsc: Destroy mutex after freeing the IRQ

    The event_notify callback which runs from vsc_tp_thread_isr may call
    vsc_tp_xfer() which locks the mutex. So the ISR depends on the mutex.

    Move the mutex_destroy() call to after free_irq() to ensure that the ISR
    is not running while the mutex is destroyed.

    Fixes: 566f5ca ("mei: Add transport driver for IVSC device")
    Signed-off-by: Hans de Goede <hansg@kernel.org>
    Link: https://lore.kernel.org/r/20250623085052.12347-6-hansg@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Signed-off-by: Steve Best <sbest@redhat.com>

Author: sfbest

drivers/misc/mei/vsc-tp.c

@@ -521,10 +521,10 @@ static int vsc_tp_probe(struct spi_device *spi)
 	return 0;
 
 err_destroy_lock:
-	mutex_destroy(&tp->mutex);
-
 	free_irq(spi->irq, tp);
 
+	mutex_destroy(&tp->mutex);
+
 	return ret;
 }
 
@@ -535,9 +535,9 @@ static void vsc_tp_remove(struct spi_device *spi)
 
 	platform_device_unregister(tp->pdev);
 
-	mutex_destroy(&tp->mutex);
-
 	free_irq(spi->irq, tp);
+
+	mutex_destroy(&tp->mutex);
 }
 
 static const struct acpi_device_id vsc_tp_acpi_ids[] = {