arm64/sysreg: Fix GIC CDEOI instruction encoding

JIRA: https://issues.redhat.com/browse/RHEL-101059

commit e9ad390
Author: Lorenzo Pieralisi <lpieralisi@kernel.org>
Date: Tue, 7 Oct 2025 12:26:00 +0200

    The GIC CDEOI system instruction requires the Rt field to be set to 0b11111
    otherwise the instruction behaviour becomes CONSTRAINED UNPREDICTABLE.

    Currenly, its usage is encoded as a system register write, with a constant
    0 value:

    write_sysreg_s(0, GICV5_OP_GIC_CDEOI)

    While compiling with GCC, the 0 constant value, through these asm
    constraints and modifiers ('x' modifier and 'Z' constraint combo):

    asm volatile(__msr_s(r, "%x0") : : "rZ" (__val));

    forces the compiler to issue the XZR register for the MSR operation (ie
    that corresponds to Rt == 0b11111) issuing the right instruction encoding.

    Unfortunately LLVM does not yet understand that modifier/constraint
    combo so it ends up issuing a different register from XZR for the MSR
    source, which in turns means that it encodes the GIC CDEOI instruction
    wrongly and the instruction behaviour becomes CONSTRAINED UNPREDICTABLE
    that we must prevent.

    Add a conditional to write_sysreg_s() macro that detects whether it
    is passed a constant 0 value and issues an MSR write with XZR as source
    register - explicitly doing what the asm modifier/constraint is meant to
    achieve through constraints/modifiers, fixing the LLVM compilation issue.

    Fixes: 7ec80fb ("irqchip/gic-v5: Add GICv5 PPI support")
    Suggested-by: Catalin Marinas <catalin.marinas@arm.com>
    Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
    Acked-by: Marc Zyngier <maz@kernel.org>
    Cc: stable@vger.kernel.org
    Cc: Sascha Bischoff <sascha.bischoff@arm.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Marc Zyngier <maz@kernel.org>
    Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
    Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

Signed-off-by: Mark Salter <msalter@redhat.com>

Author: mosalter

arch/arm64/include/asm/sysreg.h

@@ -1171,10 +1171,19 @@
 	__val;								\
 })
 
+/*
+ * The "Z" constraint combined with the "%x0" template should be enough
+ * to force XZR generation if (v) is a constant 0 value but LLVM does not
+ * yet understand that modifier/constraint combo so a conditional is required
+ * to nudge the compiler into using XZR as a source for a 0 constant value.
+ */
 #define write_sysreg_s(v, r) do {					\
 	u64 __val = (u64)(v);						\
 	u32 __maybe_unused __check_r = (u32)(r);			\
-	asm volatile(__msr_s(r, "%x0") : : "rZ" (__val));		\
+	if (__builtin_constant_p(__val) && __val == 0)			\
+		asm volatile(__msr_s(r, "xzr"));			\
+	else								\
+		asm volatile(__msr_s(r, "%x0") : : "r" (__val));	\
 } while (0)
 
 /*