Skip to content

Commit 69aeb50

Browse files
pip-izonydtor
authored andcommitted
Input: pegasus-notetaker - fix potential out-of-bounds access
In the pegasus_notetaker driver, the pegasus_probe() function allocates the URB transfer buffer using the wMaxPacketSize value from the endpoint descriptor. An attacker can use a malicious USB descriptor to force the allocation of a very small buffer. Subsequently, if the device sends an interrupt packet with a specific pattern (e.g., where the first byte is 0x80 or 0x42), the pegasus_parse_packet() function parses the packet without checking the allocated buffer size. This leads to an out-of-bounds memory access. Fixes: 1afca2b ("Input: add Pegasus Notetaker tablet driver") Signed-off-by: Seungjin Bae <eeodqql09@gmail.com> Link: https://lore.kernel.org/r/20251007214131.3737115-2-eeodqql09@gmail.com Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 7363096 commit 69aeb50

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

drivers/input/tablet/pegasus_notetaker.c

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@
6363
#define BUTTON_PRESSED 0xb5
6464
#define COMMAND_VERSION 0xa9
6565

66+
/* 1 Status + 1 Color + 2 X + 2 Y = 6 bytes */
67+
#define NOTETAKER_PACKET_SIZE 6
68+
6669
/* in xy data packet */
6770
#define BATTERY_NO_REPORT 0x40
6871
#define BATTERY_LOW 0x41
@@ -311,6 +314,12 @@ static int pegasus_probe(struct usb_interface *intf,
311314
}
312315

313316
pegasus->data_len = usb_maxpacket(dev, pipe);
317+
if (pegasus->data_len < NOTETAKER_PACKET_SIZE) {
318+
dev_err(&intf->dev, "packet size is too small (%d)\n",
319+
pegasus->data_len);
320+
error = -EINVAL;
321+
goto err_free_mem;
322+
}
314323

315324
pegasus->data = usb_alloc_coherent(dev, pegasus->data_len, GFP_KERNEL,
316325
&pegasus->data_dma);

0 commit comments

Comments
 (0)