Skip to content

Commit 8ccdf3a

Browse files
Ma Kegregkh
authored andcommitted
RDMA/rtrs: server: Fix error handling in get_or_create_srv
[ Upstream commit a338d6e ] After device_initialize() is called, use put_device() to release the device according to kernel device management rules. While direct kfree() work in this case, using put_device() is more correct. Found by code review. Fixes: 9cb8374 ("RDMA/rtrs: server: main functionality") Signed-off-by: Ma Ke <make24@iscas.ac.cn> Link: https://patch.msgid.link/20251110005158.13394-1-make24@iscas.ac.cn Acked-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Leon Romanovsky <leon@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 83f23bf commit 8ccdf3a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/infiniband/ulp/rtrs/rtrs-srv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1450,7 +1450,7 @@ static struct rtrs_srv_sess *get_or_create_srv(struct rtrs_srv_ctx *ctx,
14501450
kfree(srv->chunks);
14511451

14521452
err_free_srv:
1453-
kfree(srv);
1453+
put_device(&srv->dev);
14541454
return ERR_PTR(-ENOMEM);
14551455
}
14561456

0 commit comments

Comments
 (0)