Skip to content

Commit 91c6b43

Browse files
author
Myron Stowe
committed
irqchip: Drop MSI_CHIP_FLAG_SET_ACK from unsuspecting MSI drivers
JIRA: https://issues.redhat.com/browse/RHEL-120705 Upstream Status: fb0ea6e commit fb0ea6e Author: Marc Zyngier <maz@kernel.org> Date: Tue May 13 18:28:15 2025 +0100 irqchip: Drop MSI_CHIP_FLAG_SET_ACK from unsuspecting MSI drivers Commit 1c000dc ("irqchip/irq-msi-lib: Optionally set default irq_eoi()/irq_ack()") added blanket MSI_CHIP_FLAG_SET_ACK flags, irrespective of whether the underlying irqchip required it or not. Drop it from a number of drivers that do not require it. Fixes: 1c000dc ("irqchip/irq-msi-lib: Optionally set default irq_eoi()/irq_ack()") Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/20250513172819.2216709-6-maz@kernel.org Signed-off-by: Myron Stowe <mstowe@redhat.com>
1 parent 9e27234 commit 91c6b43

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

drivers/irqchip/irq-gic-v2m.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ static void __init gicv2m_teardown(void)
252252
static struct msi_parent_ops gicv2m_msi_parent_ops = {
253253
.supported_flags = GICV2M_MSI_FLAGS_SUPPORTED,
254254
.required_flags = GICV2M_MSI_FLAGS_REQUIRED,
255-
.chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
255+
.chip_flags = MSI_CHIP_FLAG_SET_EOI,
256256
.bus_select_token = DOMAIN_BUS_NEXUS,
257257
.bus_select_mask = MATCH_PCI_MSI | MATCH_PLATFORM_MSI,
258258
.prefix = "GICv2m-",

drivers/irqchip/irq-gic-v3-its-msi-parent.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ static bool its_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
202202
const struct msi_parent_ops gic_v3_its_msi_parent_ops = {
203203
.supported_flags = ITS_MSI_FLAGS_SUPPORTED,
204204
.required_flags = ITS_MSI_FLAGS_REQUIRED,
205-
.chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
205+
.chip_flags = MSI_CHIP_FLAG_SET_EOI,
206206
.bus_select_token = DOMAIN_BUS_NEXUS,
207207
.bus_select_mask = MATCH_PCI_MSI | MATCH_PLATFORM_MSI,
208208
.prefix = "ITS-",

drivers/irqchip/irq-gic-v3-mbi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ static bool mbi_init_dev_msi_info(struct device *dev, struct irq_domain *domain,
197197
static const struct msi_parent_ops gic_v3_mbi_msi_parent_ops = {
198198
.supported_flags = MBI_MSI_FLAGS_SUPPORTED,
199199
.required_flags = MBI_MSI_FLAGS_REQUIRED,
200-
.chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
200+
.chip_flags = MSI_CHIP_FLAG_SET_EOI,
201201
.bus_select_token = DOMAIN_BUS_NEXUS,
202202
.bus_select_mask = MATCH_PCI_MSI | MATCH_PLATFORM_MSI,
203203
.prefix = "MBI-",

drivers/irqchip/irq-mvebu-gicp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ static const struct irq_domain_ops gicp_domain_ops = {
161161
static const struct msi_parent_ops gicp_msi_parent_ops = {
162162
.supported_flags = GICP_MSI_FLAGS_SUPPORTED,
163163
.required_flags = GICP_MSI_FLAGS_REQUIRED,
164-
.chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
164+
.chip_flags = MSI_CHIP_FLAG_SET_EOI,
165165
.bus_select_token = DOMAIN_BUS_GENERIC_MSI,
166166
.bus_select_mask = MATCH_PLATFORM_MSI,
167167
.prefix = "GICP-",

drivers/irqchip/irq-mvebu-odmi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ static const struct irq_domain_ops odmi_domain_ops = {
157157
static const struct msi_parent_ops odmi_msi_parent_ops = {
158158
.supported_flags = ODMI_MSI_FLAGS_SUPPORTED,
159159
.required_flags = ODMI_MSI_FLAGS_REQUIRED,
160-
.chip_flags = MSI_CHIP_FLAG_SET_EOI | MSI_CHIP_FLAG_SET_ACK,
160+
.chip_flags = MSI_CHIP_FLAG_SET_EOI,
161161
.bus_select_token = DOMAIN_BUS_GENERIC_MSI,
162162
.bus_select_mask = MATCH_PLATFORM_MSI,
163163
.prefix = "ODMI-",

0 commit comments

Comments
 (0)