Skip to content

Commit b8bcc17

Browse files
Asbjørn Sloth Tønnesenzx2c4
authored andcommitted
wireguard: netlink: lower .maxattr for WG_CMD_GET_DEVICE
Previously .maxattr was shared for both WG_CMD_GET_DEVICE and WG_CMD_SET_DEVICE. Now that it is split, then we can lower it for WG_CMD_GET_DEVICE to follow the documentation which defines .maxattr as WGDEVICE_A_IFNAME for WG_CMD_GET_DEVICE. $ grep -hC5 'one but not both of:' include/uapi/linux/wireguard.h * WG_CMD_GET_DEVICE * ----------------- * * May only be called via NLM_F_REQUEST | NLM_F_DUMP. The command * should contain one but not both of: * * WGDEVICE_A_IFINDEX: NLA_U32 * WGDEVICE_A_IFNAME: NLA_NUL_STRING, maxlen IFNAMSIZ - 1 * * The kernel will then return several messages [...] While other attributes weren't rejected previously, the consensus is that nobody sends those attributes, so nothing should break. Link: https://lore.kernel.org/r/aRyLoy2iqbkUipZW@zx2c4.com/ Suggested-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
1 parent 73af07d commit b8bcc17

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/wireguard/netlink.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ static const struct genl_split_ops wireguard_nl_ops[] = {
623623
.dumpit = wg_get_device_dump,
624624
.done = wg_get_device_done,
625625
.policy = device_policy,
626-
.maxattr = WGDEVICE_A_PEERS,
626+
.maxattr = WGDEVICE_A_IFNAME,
627627
.flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DUMP,
628628
}, {
629629
.cmd = WG_CMD_SET_DEVICE,

0 commit comments

Comments
 (0)