Skip to content

Commit f99b03e

Browse files
committed
drm/i915/display: Check whether platform supports joiner
jira NONE_AUTOMATION Rebuild_History Non-Buildable kernel-5.14.0-570.18.1.el9_6 commit-author Ankit Nautiyal <ankit.k.nautiyal@intel.com> commit 26fee9e Add macros to check if platform supports bigjoiner/uncompressed joiner. Replace the existing DISPLAY_VER checks with these. Additionally use it before readout for joiner stuff, where its missing. Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240912132931.1320686-1-ankit.k.nautiyal@intel.com (cherry picked from commit 26fee9e) Signed-off-by: Jonathan Maple <jmaple@ciq.com>
1 parent 838cd1e commit f99b03e

File tree

4 files changed

+10
-5
lines changed

4 files changed

+10
-5
lines changed

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1710,7 +1710,7 @@ static void hsw_crtc_enable(struct intel_atomic_state *state,
17101710

17111711
intel_dsc_enable(pipe_crtc_state);
17121712

1713-
if (DISPLAY_VER(dev_priv) >= 13)
1713+
if (HAS_UNCOMPRESSED_JOINER(dev_priv))
17141714
intel_uncompressed_joiner_enable(pipe_crtc_state);
17151715

17161716
intel_set_pipe_src_size(pipe_crtc_state);
@@ -3542,6 +3542,9 @@ static void enabled_joiner_pipes(struct drm_i915_private *dev_priv,
35423542
*primary_pipes = 0;
35433543
*secondary_pipes = 0;
35443544

3545+
if (!HAS_BIGJOINER(dev_priv))
3546+
return;
3547+
35453548
for_each_intel_crtc_in_pipe_mask(&dev_priv->drm, crtc,
35463549
joiner_pipes(dev_priv)) {
35473550
enum intel_display_power_domain power_domain;
@@ -3561,7 +3564,7 @@ static void enabled_joiner_pipes(struct drm_i915_private *dev_priv,
35613564
*secondary_pipes |= BIT(pipe);
35623565
}
35633566

3564-
if (DISPLAY_VER(dev_priv) < 13)
3567+
if (!HAS_UNCOMPRESSED_JOINER(dev_priv))
35653568
continue;
35663569

35673570
power_domain = POWER_DOMAIN_PIPE(pipe);
@@ -7962,7 +7965,7 @@ static int max_dotclock(struct drm_i915_private *i915)
79627965
int max_dotclock = i915->display.cdclk.max_dotclk_freq;
79637966

79647967
/* icl+ might use joiner */
7965-
if (DISPLAY_VER(i915) >= 11)
7968+
if (HAS_BIGJOINER(i915))
79667969
max_dotclock *= 2;
79677970

79687971
return max_dotclock;

drivers/gpu/drm/i915/display/intel_display_debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,7 @@ void intel_connector_debugfs_add(struct intel_connector *connector)
15481548
connector, &i915_dsc_fractional_bpp_fops);
15491549
}
15501550

1551-
if (DISPLAY_VER(i915) >= 11 &&
1551+
if (HAS_BIGJOINER(i915) &&
15521552
(connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
15531553
connector_type == DRM_MODE_CONNECTOR_eDP)) {
15541554
debugfs_create_bool("i915_bigjoiner_force_enable", 0644, root,

drivers/gpu/drm/i915/display/intel_display_device.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ enum intel_display_subplatform {
118118

119119
#define HAS_4TILE(i915) (IS_DG2(i915) || DISPLAY_VER(i915) >= 14)
120120
#define HAS_ASYNC_FLIPS(i915) (DISPLAY_VER(i915) >= 5)
121+
#define HAS_BIGJOINER(i915) (DISPLAY_VER(i915) >= 11)
121122
#define HAS_CDCLK_CRAWL(i915) (DISPLAY_INFO(i915)->has_cdclk_crawl)
122123
#define HAS_CDCLK_SQUASH(i915) (DISPLAY_INFO(i915)->has_cdclk_squash)
123124
#define HAS_CUR_FBC(i915) (!HAS_GMCH(i915) && IS_DISPLAY_VER(i915, 7, 13))
@@ -152,6 +153,7 @@ enum intel_display_subplatform {
152153
#define HAS_SAGV(i915) (DISPLAY_VER(i915) >= 9 && !IS_LP(i915))
153154
#define HAS_TRANSCODER(i915, trans) ((DISPLAY_RUNTIME_INFO(i915)->cpu_transcoder_mask & \
154155
BIT(trans)) != 0)
156+
#define HAS_UNCOMPRESSED_JOINER(i915) (DISPLAY_VER(i915) >= 13)
155157
#define HAS_VRR(i915) (DISPLAY_VER(i915) >= 11)
156158
#define HAS_AS_SDP(i915) (DISPLAY_VER(i915) >= 13)
157159
#define HAS_CMRR(i915) (DISPLAY_VER(i915) >= 20)

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2514,7 +2514,7 @@ bool intel_dp_joiner_needs_dsc(struct drm_i915_private *i915, bool use_joiner)
25142514
* limitation. DG2 onwards pipe joiner can be enabled without
25152515
* compression.
25162516
*/
2517-
return DISPLAY_VER(i915) < 13 && use_joiner;
2517+
return !HAS_UNCOMPRESSED_JOINER(i915) && use_joiner;
25182518
}
25192519

25202520
static int

0 commit comments

Comments
 (0)