Skip to content

Commit 255e18c

Browse files
committed
remove poorly made comments, I am using friend classes
1 parent bde0099 commit 255e18c

File tree

4 files changed

+6
-14
lines changed

4 files changed

+6
-14
lines changed

src/BaseClasses/ANTPLUS_BaseMasterProfile.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,15 @@
66
class BaseMasterProfile : public BaseProfile {
77
public:
88
BaseMasterProfile(uint16_t deviceNumber, uint8_t transmissionType);
9-
/******************************************
10-
*LIBRARY INTERNAL ONLY FUNCTIONS BELOW
11-
******************************************/
9+
protected:
1210
/**
1311
* Used to catch EVENT_TX and continue transmission pattern
1412
*/
1513
virtual void onChannelEventResponse(ChannelEventResponse& msg);
16-
protected:
1714
/**
1815
* This function, when called, will transmit the next message in the broadcast pattern
1916
*/
2017
virtual void transmitNextDataPage() = 0;
2118
};
2219

23-
#endif // ANTPLUS_BASESLAVEPROFILE_h
20+
#endif // ANTPLUS_BASESLAVEPROFILE_h

src/BaseClasses/ANTPLUS_BaseSlaveProfile.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ BaseSlaveProfile::BaseSlaveProfile(uint16_t deviceNumber, uint8_t transmissionTy
1515

1616
uint8_t BaseSlaveProfile::searchForDevices(uint16_t* buffer) {
1717
// TODO
18+
return 0;
1819
}
1920

2021
uint8_t BaseSlaveProfile::waitForPair() {

src/Profiles/BicycleSpeed/Sensor/ANTPLUS_ProfileBicycleSpeedSensor.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,9 @@ class ProfileHeartRateMonitor : BaseMasterProfile {
1111
void onRequestDataPage(void (*func)(RequestDataPage&, uintptr_t), uintptr_t data = 0) { _onRequestDataPage.set(func, data); }
1212
void begin();
1313
void stop();
14-
/******************************************
15-
*LIBRARY INTERNAL ONLY FUNCTIONS BELOW
16-
******************************************/
14+
protected:
1715
void onAcknowledgedData(AcknowledgedData& msg);
1816
void onBroadcastData(BroadcastData& msg);
19-
protected:
2017
void transmitNextDataPage();
2118
private:
2219
bool handleCapabilities(HeartRateBaseMainDataPage& dataPage);

src/Profiles/HeartRate/Monitor/ANTPLUS_ProfileHeartRateMonitor.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,10 @@ class ProfileHeartRateMonitor : BaseMasterProfile {
1111
void onRequestDataPage(void (*func)(RequestDataPage&, uintptr_t), uintptr_t data = 0) { _onRequestDataPage.set(func, data); }
1212
void begin();
1313
void stop();
14-
/******************************************
15-
*LIBRARY INTERNAL ONLY FUNCTIONS BELOW
16-
******************************************/
17-
void onAcknowledgedData(AcknowledgedData& msg);
18-
void onBroadcastData(BroadcastData& msg);
1914
protected:
2015
void transmitNextDataPage();
16+
void onAcknowledgedData(AcknowledgedData& msg);
17+
void onBroadcastData(BroadcastData& msg);
2118
private:
2219
bool handleCapabilities(HeartRateBaseMainDataPage& dataPage);
2320
bool handleRequestDataPage(HeartRateBaseMainDataPage& dataPage);

0 commit comments

Comments
 (0)