pylint cleanup

Author: craigbarratt

custom_components/pyscript/eval.py

@@ -123,23 +123,23 @@ def __init__(self, value):
         """Initialize return statement value."""
         self.value = value
 
-    def name(self):
+    def name(self):  # pylint: disable=no-self-use
         """Return short name."""
         return "return"
 
 
 class EvalBreak(EvalStopFlow):
     """Break statement."""
 
-    def name(self):
+    def name(self):  # pylint: disable=no-self-use
         """Return short name."""
         return "break"
 
 
 class EvalContinue(EvalStopFlow):
     """Continue statement."""
 
-    def name(self):
+    def name(self):  # pylint: disable=no-self-use
         """Return short name."""
         return "continue"
 
@@ -657,8 +657,7 @@ async def recurse_assign(self, lhs, val):
                     if var_name in sym_table:
                         sym_table[var_name] = val
                         return
-                else:
-                    raise TypeError(f"can't find nonlocal '{var_name}' for assignment")
+                raise TypeError(f"can't find nonlocal '{var_name}' for assignment")
             self.sym_table[var_name] = val
 
     async def ast_assign(self, arg):
@@ -741,7 +740,7 @@ async def ast_delete(self, arg):
             else:
                 raise NotImplementedError(f"unknown target type {arg1} in del")
 
-    async def ast_attribute_collapse(self, arg):  # pylint: disable=no-self-use
+    async def ast_attribute_collapse(self, arg):
         """Combine dotted attributes to allow variable names to have dots."""
         # collapse dotted names, eg:
         #   Attribute(value=Attribute(value=Name(id='i', ctx=Load()), attr='j', ctx=Load()), attr='k', ctx=Store())
@@ -999,7 +998,7 @@ async def ast_dict(self, arg):
 
     async def ast_set(self, arg):
         """Evaluate set."""
-        return {elt for elt in await self.eval_elt_list(arg.elts)}
+        return {elt for elt in await self.eval_elt_list(arg.elts)}  # pylint: disable=unnecessary-comprehension
 
     async def ast_subscript(self, arg):
         """Evaluate subscript."""

custom_components/pyscript/global_ctx.py

@@ -218,7 +218,7 @@ async def do_service_call(func, ast_ctx, data):
         kwarg_check = {
             "task_unique": {"kill_me"},
         }
-        for dec_name in trig_args.keys():
+        for dec_name in trig_args:
             if dec_name not in kwarg_check and "kwargs" in trig_args[dec_name]:
                 self.logger.error(
                     "%s defined in %s: decorator @%s doesn't take keyword arguments; ignored",

custom_components/pyscript/trigger.py

@@ -752,7 +752,6 @@ async def trigger_watch(self):
 
         async def do_func_call(func, ast_ctx, task_unique, kwargs=None):
             if task_unique:
-                _LOGGER.debug(f"do_func_call: calling task_unique with {task_unique}")
                 await self.handler.task_unique(task_unique)
             await func.call(ast_ctx, kwargs=kwargs)
             if ast_ctx.get_exception_obj():
@@ -876,7 +875,6 @@ async def do_func_call(func, ast_ctx, task_unique, kwargs=None):
                         "trigger %s got %s trigger, @task_unique kill_me=True prevented new action",
                         notify_type,
                         self.name,
-                        func_args,
                     )
                     continue