Skip to content

Commit a18e253

Browse files
committed
make state_check_now logic more readable
1 parent b063ff6 commit a18e253

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

custom_components/pyscript/trigger.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -711,19 +711,19 @@ def ident_values_changed(self, func_args):
711711

712712
if var_name is None:
713713
_LOGGER.debug(
714-
"%s ident changes detected because no var_name",
714+
"%s ident changes not detected because no var_name",
715715
self.name,
716716
)
717-
return True
717+
return False
718718

719719
for check_var in self.state_trig_ident:
720-
# if check_var in self.state_trig_ident_any:
721-
# _LOGGER.debug(
722-
# "%s ident change skipping %s because also ident_any",
723-
# self.name,
724-
# check_var,
725-
# )
726-
# continue
720+
if check_var in self.state_trig_ident_any:
721+
_LOGGER.debug(
722+
"%s ident change skipping %s because also ident_any",
723+
self.name,
724+
check_var,
725+
)
726+
continue
727727
var_pieces = check_var.split('.')
728728
if len(var_pieces) == 2 and check_var == var_name:
729729
if value != old_value:
@@ -846,7 +846,8 @@ async def trigger_watch(self):
846846
new_vars, func_args = notify_info
847847

848848
if not self.ident_any_values_changed(func_args):
849-
if not self.ident_values_changed(func_args):
849+
# if var_name not in func_args we are state_check_now
850+
if "var_name" in func_args and not self.ident_values_changed(func_args):
850851
continue
851852

852853
if self.state_trig_eval:

0 commit comments

Comments
 (0)