add tests and fix bugs

Author: raman325

custom_components/pyscript/config_flow.py

@@ -1,11 +1,14 @@
 """Config flow for Vizio."""
-import copy
+import voluptuous as vol
 
 from homeassistant import config_entries
 
-from . import PYSCRIPT_SCHEMA
 from .const import CONF_ALLOW_ALL_IMPORTS, DOMAIN
 
+PYSCRIPT_SCHEMA = vol.Schema(
+    {vol.Optional(CONF_ALLOW_ALL_IMPORTS, default=False): bool}, extra=vol.ALLOW_EXTRA,
+)
+
 
 class PyscriptConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
     """Handle a pyscript config flow."""
@@ -16,9 +19,10 @@ class PyscriptConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
     async def async_step_user(self, user_input):
         """Handle a flow initialized by the user."""
         if user_input is not None:
-            if await self.async_set_unique_id(unique_id=DOMAIN, raise_on_progress=True):
-                self.async_abort(reason="single_instance_allowed")
+            if len(self.hass.config_entries.async_entries(DOMAIN)) > 0:
+                return self.async_abort(reason="single_instance_allowed")
 
+            await self.async_set_unique_id(DOMAIN)
             return self.async_create_entry(title=DOMAIN, data=user_input)
 
         return self.async_show_form(step_id="user", data_schema=PYSCRIPT_SCHEMA)
@@ -33,7 +37,7 @@ async def async_step_import(self, import_config):
             if entry.data.get(CONF_ALLOW_ALL_IMPORTS, False) != import_config.get(
                 CONF_ALLOW_ALL_IMPORTS, False
             ):
-                updated_data = copy.copy(entry.data)
+                updated_data = entry.data.copy()
                 updated_data[CONF_ALLOW_ALL_IMPORTS] = import_config.get(CONF_ALLOW_ALL_IMPORTS, False)
                 self.hass.config_entries.async_update_entry(entry=entry, data=updated_data)
                 await self.hass.config_entries.async_reload(entry.entry_id)

tests/test_config_flow.py

@@ -0,0 +1,107 @@
+"""Tests for pyscript config flow."""
+import logging
+
+from custom_components.pyscript import PYSCRIPT_SCHEMA
+from custom_components.pyscript.const import CONF_ALLOW_ALL_IMPORTS, DOMAIN
+import pytest
+from pytest_homeassistant.async_mock import patch
+
+from homeassistant import data_entry_flow
+from homeassistant.config_entries import SOURCE_IMPORT, SOURCE_USER
+
+_LOGGER = logging.getLogger(__name__)
+
+
+@pytest.fixture(name="pyscript_bypass_setup")
+def pyscript_bypass_setup_fixture():
+    """Mock component setup."""
+    with patch("custom_components.pyscript.async_setup_entry", return_value=True):
+        yield
+
+
+async def test_user_flow_minimum_fields(hass, pyscript_bypass_setup):
+    """Test user config flow with minimum fields."""
+    # test form shows
+    result = await hass.config_entries.flow.async_init(DOMAIN, context={"source": SOURCE_USER})
+    assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
+    assert result["step_id"] == "user"
+
+    result = await hass.config_entries.flow.async_configure(result["flow_id"], user_input={})
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+    assert CONF_ALLOW_ALL_IMPORTS in result["data"]
+    assert not result["data"][CONF_ALLOW_ALL_IMPORTS]
+
+
+async def test_user_flow_all_fields(hass, pyscript_bypass_setup,) -> None:
+    """Test user config flow with all fields."""
+    # test form shows
+    result = await hass.config_entries.flow.async_init(DOMAIN, context={"source": SOURCE_USER})
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_FORM
+    assert result["step_id"] == "user"
+
+    result = await hass.config_entries.flow.async_configure(
+        result["flow_id"], user_input={CONF_ALLOW_ALL_IMPORTS: True}
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+    assert CONF_ALLOW_ALL_IMPORTS in result["data"]
+    assert result["data"][CONF_ALLOW_ALL_IMPORTS]
+
+
+async def test_user_already_configured(hass, pyscript_bypass_setup,) -> None:
+    """Test service is already configured during user setup."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_USER}, data={CONF_ALLOW_ALL_IMPORTS: True}
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_USER}, data={CONF_ALLOW_ALL_IMPORTS: True}
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
+    assert result["reason"] == "single_instance_allowed"
+
+
+async def test_import_flow(hass, pyscript_bypass_setup):
+    """Test import config flow works."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_IMPORT}, data=PYSCRIPT_SCHEMA({})
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+
+
+async def test_import_flow_update_entry(hass, pyscript_bypass_setup):
+    """Test import config flow updates existing entry."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_IMPORT}, data=PYSCRIPT_SCHEMA({})
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_IMPORT}, data={CONF_ALLOW_ALL_IMPORTS: True}
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
+    assert result["reason"] == "updated_entry"
+
+
+async def test_import_flow_no_update(hass, pyscript_bypass_setup):
+    """Test import config flow doesn't update existing entry when data is same."""
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_IMPORT}, data=PYSCRIPT_SCHEMA({})
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_CREATE_ENTRY
+
+    result = await hass.config_entries.flow.async_init(
+        DOMAIN, context={"source": SOURCE_IMPORT}, data=PYSCRIPT_SCHEMA({})
+    )
+
+    assert result["type"] == data_entry_flow.RESULT_TYPE_ABORT
+    assert result["reason"] == "already_configured_service"