Breaking changes for analyzer version 4.0.0

Change-Id: I26961f29f9171e94db2f5c95f1f8af5fd01bb9b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/_fe_analyzer_shared/lib/src/scanner/error_token.dart

@@ -101,11 +101,6 @@ abstract class ErrorToken extends SimpleToken {
   int? get endOffset => null;
 
   BeginToken? get begin => null;
-
-  @override
-  Token copy() {
-    throw 'unsupported operation';
-  }
 }
 
 /// Represents an encoding error.

pkg/_fe_analyzer_shared/lib/src/scanner/token.dart

@@ -54,9 +54,6 @@ class BeginToken extends SimpleToken {
         type == TokenType.STRING_INTERPOLATION_EXPRESSION);
   }
 
-  @override
-  Token copy() => new BeginToken(type, offset, copyComments(precedingComments));
-
   @override
   Token? get endGroup => endToken;
 
@@ -83,25 +80,6 @@ class CommentToken extends StringToken {
    */
   CommentToken(TokenType type, String value, int offset)
       : super(type, value, offset);
-
-  @override
-  CommentToken copy() => new CommentToken(type, _value, offset);
-
-  /**
-   * Remove this comment token from the list.
-   *
-   * This is used when we decide to interpret the comment as syntax.
-   */
-  void remove() {
-    Token? previous = this.previous;
-    if (previous != null) {
-      previous.setNextWithoutSettingPrevious(next);
-      next?.previous = previous;
-    } else {
-      assert(parent!.precedingComments == this);
-      parent!.precedingComments = next as CommentToken?;
-    }
-  }
 }
 
 /**
@@ -114,9 +92,6 @@ class DocumentationCommentToken extends CommentToken {
    */
   DocumentationCommentToken(TokenType type, String value, int offset)
       : super(type, value, offset);
-
-  @override
-  CommentToken copy() => new DocumentationCommentToken(type, _value, offset);
 }
 
 enum KeywordStyle {
@@ -481,10 +456,6 @@ class KeywordToken extends SimpleToken {
   KeywordToken(this.keyword, int offset, [CommentToken? precedingComment])
       : super(keyword, offset, precedingComment);
 
-  @override
-  Token copy() =>
-      new KeywordToken(keyword, offset, copyComments(precedingComments));
-
   @override
   bool get isIdentifier => keyword.isPseudo || keyword.isBuiltIn;
 
@@ -515,10 +486,6 @@ class LanguageVersionToken extends CommentToken {
 
   LanguageVersionToken.from(String text, int offset, this.major, this.minor)
       : super(TokenType.SINGLE_LINE_COMMENT, text, offset);
-
-  @override
-  LanguageVersionToken copy() =>
-      new LanguageVersionToken.from(lexeme, offset, major, minor);
 }
 
 /**
@@ -633,25 +600,6 @@ class SimpleToken implements Token {
   @override
   String? get stringValue => type.stringValue;
 
-  @override
-  Token copy() =>
-      new SimpleToken(type, offset, copyComments(precedingComments));
-
-  @override
-  CommentToken? copyComments(CommentToken? token) {
-    if (token == null) {
-      return null;
-    }
-    CommentToken head = token.copy();
-    Token tail = head;
-    token = token.next as CommentToken?;
-    while (token != null) {
-      tail = tail.setNext(token.copy());
-      token = token.next as CommentToken?;
-    }
-    return head;
-  }
-
   @override
   bool matchesAny(List<TokenType> types) {
     for (TokenType type in types) {
@@ -718,10 +666,6 @@ class StringToken extends SimpleToken {
   @override
   String get lexeme => _value;
 
-  @override
-  Token copy() =>
-      new StringToken(type, _value, offset, copyComments(precedingComments));
-
   @override
   String value() => _value;
 }
@@ -741,10 +685,6 @@ class SyntheticBeginToken extends BeginToken {
   @override
   Token? beforeSynthetic;
 
-  @override
-  Token copy() =>
-      new SyntheticBeginToken(type, offset, copyComments(precedingComments));
-
   @override
   bool get isSynthetic => true;
 
@@ -767,9 +707,6 @@ class SyntheticKeywordToken extends KeywordToken {
 
   @override
   int get length => 0;
-
-  @override
-  Token copy() => new SyntheticKeywordToken(keyword, offset);
 }
 
 /**
@@ -794,9 +731,6 @@ class SyntheticStringToken extends StringToken {
 
   @override
   int get length => _length ?? super.length;
-
-  @override
-  Token copy() => new SyntheticStringToken(type, _value, offset, _length);
 }
 
 /**
@@ -813,9 +747,6 @@ class SyntheticToken extends SimpleToken {
 
   @override
   int get length => 0;
-
-  @override
-  Token copy() => new SyntheticToken(type, offset);
 }
 
 /// A token used to replace another token in the stream, while still keeping the
@@ -839,9 +770,6 @@ class ReplacementToken extends SyntheticToken {
 
   @override
   int get length => 0;
-
-  @override
-  Token copy() => new ReplacementToken(type, replacedToken);
 }
 
 /**
@@ -1041,18 +969,6 @@ abstract class Token implements SyntacticEntity {
    */
   TokenType get type;
 
-  /**
-   * Return a newly created token that is a copy of this tokens
-   * including any [preceedingComment] tokens,
-   * but that is not a part of any token stream.
-   */
-  Token copy();
-
-  /**
-   * Copy a linked list of comment tokens identical to the given comment tokens.
-   */
-  CommentToken? copyComments(CommentToken? token);
-
   /**
    * Return `true` if this token has any one of the given [types].
    */

pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart

@@ -5,7 +5,7 @@
 library _fe_analyzer_shared.scanner.token;
 
 import 'token.dart' as analyzer;
-import 'token.dart' show Token, TokenType;
+import 'token.dart' show TokenType;
 
 import 'token_constants.dart' show IDENTIFIER_TOKEN;
 
@@ -115,10 +115,6 @@ class StringToken extends analyzer.SimpleToken implements analyzer.StringToken {
     return canonicalizer.canonicalize(data, start, end, asciiOnly);
   }
 
-  @override
-  Token copy() => new StringToken._(
-      type, valueOrLazySubstring, charOffset, copyComments(precedingComments));
-
   @override
   String value() => lexeme;
 }
@@ -134,10 +130,6 @@ class SyntheticStringToken extends StringToken
 
   @override
   int get length => 0;
-
-  @override
-  Token copy() => new SyntheticStringToken(
-      type, valueOrLazySubstring, offset, copyComments(precedingComments));
 }
 
 class CommentToken extends StringToken implements analyzer.CommentToken {
@@ -167,24 +159,6 @@ class CommentToken extends StringToken implements analyzer.CommentToken {
   CommentToken.fromUtf8Bytes(TokenType type, List<int> data, int start, int end,
       bool asciiOnly, int charOffset)
       : super.fromUtf8Bytes(type, data, start, end, asciiOnly, charOffset);
-
-  CommentToken._(TokenType type, valueOrLazySubstring, int charOffset)
-      : super._(type, valueOrLazySubstring, charOffset);
-
-  @override
-  CommentToken copy() =>
-      new CommentToken._(type, valueOrLazySubstring, charOffset);
-
-  @override
-  void remove() {
-    if (previous != null) {
-      previous!.setNextWithoutSettingPrevious(next);
-      next?.previous = previous;
-    } else {
-      assert(parent!.precedingComments == this);
-      parent!.precedingComments = next as CommentToken;
-    }
-  }
 }
 
 class LanguageVersionToken extends CommentToken
@@ -209,10 +183,6 @@ class LanguageVersionToken extends CommentToken
       int tokenStart, this.major, this.minor)
       : super.fromUtf8Bytes(
             TokenType.SINGLE_LINE_COMMENT, bytes, start, end, true, tokenStart);
-
-  @override
-  LanguageVersionToken copy() =>
-      new LanguageVersionToken.from(lexeme, offset, major, minor);
 }
 
 class DartDocToken extends CommentToken
@@ -234,13 +204,6 @@ class DartDocToken extends CommentToken
   DartDocToken.fromUtf8Bytes(TokenType type, List<int> data, int start, int end,
       bool asciiOnly, int charOffset)
       : super.fromUtf8Bytes(type, data, start, end, asciiOnly, charOffset);
-
-  DartDocToken._(TokenType type, valueOrLazySubstring, int charOffset)
-      : super._(type, valueOrLazySubstring, charOffset);
-
-  @override
-  DartDocToken copy() =>
-      new DartDocToken._(type, valueOrLazySubstring, charOffset);
 }
 
 /**

pkg/analysis_server/lib/src/analysis_server_abstract.dart

@@ -503,7 +503,7 @@ abstract class AbstractAnalysisServer {
 
     try {
       await driver.applyPendingFileChanges();
-      return driver.resolveForCompletion(
+      return await driver.resolveForCompletion(
         path: path,
         offset: offset,
         performance: performance,

pkg/analysis_server/lib/src/services/completion/dart/not_imported_contributor.dart

@@ -73,7 +73,7 @@ class NotImportedContributor extends DartCompletionContributor {
         continue;
       }
 
-      var element = analysisDriver.getLibraryByFile(file);
+      var element = await analysisDriver.getLibraryByFile(file);
       if (element == null || importedLibraries.contains(element)) {
         continue;
       }

pkg/analysis_server/lib/src/services/correction/fix/dart/extensions.dart

@@ -36,7 +36,7 @@ class Extensions {
         continue;
       }
 
-      var libraryElement = analysisDriver.getLibraryByFile(file);
+      var libraryElement = await analysisDriver.getLibraryByFile(file);
       if (libraryElement == null) {
         continue;
       }

pkg/analysis_server/lib/src/services/correction/fix/dart/top_level_declarations.dart

@@ -39,7 +39,7 @@ class TopLevelDeclarations {
         continue;
       }
 
-      var libraryElement = analysisDriver.getLibraryByFile(file);
+      var libraryElement = await analysisDriver.getLibraryByFile(file);
       if (libraryElement == null) {
         continue;
       }

pkg/analyzer/CHANGELOG.md

@@ -1,3 +1,26 @@
+## 4.0.0 (Not yet released - breaking changes)
+* Removed deprecated `UriKind` and `Source.uriKind`.
+* Removed deprecated `LibraryElement.hasExtUri`.
+* Removed deprecated `LibraryElement.hasLoadLibraryFunction`.
+* Removed deprecated `ImportElement.prefixOffset`.
+* Removed deprecated `CompilationUnitElement.types`.
+* Removed deprecated `Source.encoding`.
+* Removed deprecated `Source.isInSystemLibrary`.
+* Removed deprecated `Source.modificationStamp`.
+* Removed deprecated `stamp` in `MemoryResourceProvider`.
+* Removed deprecated `SourceFactory.restoreUri`, use `pathToUri` instead.
+* Removed deprecated `AnalysisContext.workspace`.
+* The `isNonNullableByDefault` parameter in `ErrorReporter` is now required.
+* Removed `Element.SORT_BY_OFFSET`, it is not used.
+* Changed synchronous `AnalysisSession.getFile` and `getParsedUnit` to fail
+  if there are pending file changes, instead of reading. As for any other
+  `AnalysisSession` method, await `AnalysisContext.applyPendingFileChanges()`.
+* Removed `Token.copy()` and `copyComments()`.
+* Removed `CommentToken.remove()`.
+* Removed deprecated `astFactory` and `AstFactory`.
+* Removed `AnalysisOptions.signature` and `signaturesEqual`.
+* Removed deprecated `buildSdkSummary()`.
+
 ## 3.4.1
 * Remove checks for consistency after operations in `AnalysisSession`.
 

pkg/analyzer/lib/dart/analysis/analysis_context.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/analysis/context_root.dart';
 import 'package:analyzer/dart/analysis/session.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/generated/engine.dart';
-import 'package:analyzer/src/workspace/workspace.dart';
 
 /// A representation of a body of code and the context in which the code is to
 /// be analyzed.
@@ -32,10 +31,6 @@ abstract class AnalysisContext {
   /// analyzed, or `null` if the SDK is not directory based.
   Folder? get sdkRoot;
 
-  /// Return the workspace for containing the context root.
-  @Deprecated('Use contextRoot.workspace instead')
-  Workspace get workspace;
-
   /// Return a [Future] that completes after pending file changes are applied,
   /// so that [currentSession] can be used to compute results.
   ///

pkg/analyzer/lib/dart/analysis/analysis_options.dart

@@ -2,8 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'dart:typed_data';
-
 import 'package:analyzer/dart/analysis/code_style_options.dart';
 import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/source/error_processor.dart';
@@ -52,22 +50,6 @@ abstract class AnalysisOptions {
   /// there is no `pubspec.yaml` or if it does not contain an SDK range.
   VersionConstraint? get sdkVersionConstraint;
 
-  /// Return the opaque signature of the options.
-  Uint32List get signature;
-
   /// Return `true` the lint with the given [name] is enabled.
   bool isLintEnabled(String name);
-
-  /// Determine whether two signatures returned by [signature] are equal.
-  static bool signaturesEqual(Uint32List a, Uint32List b) {
-    if (a.length != b.length) {
-      return false;
-    }
-    for (int i = 0; i < a.length; i++) {
-      if (a[i] != b[i]) {
-        return false;
-      }
-    }
-    return true;
-  }
 }