[vm] Exclude timeline from Flutter linux release engine

This undoes size regression introduced 
commit 489f63a

This also exclude timeline from Dart binaries built
in PRODUCT mode - but not from PRODUCT AOT runtime
built as part of normal SDK.

This CL also fixes the build with DART_DISABLE_TIMELINE.

TEST=manually by building Linux engine

Change-Id: Ie43826ea4150aac6bdb686f37215ba0c6a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459600
Commit-Queue: Slava Egorov <vegorov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>

Author: mraleph

runtime/BUILD.gn

@@ -31,6 +31,9 @@ config("dart_maybe_product_config") {
     }
     assert(!dart_debug)
     defines += [ "PRODUCT" ]
+    if (target_os == "linux") {
+      defines += [ "DART_DISABLE_TIMELINE" ]
+    }
   }
 }
 

runtime/vm/globals.h

@@ -114,11 +114,14 @@ const intptr_t kDefaultNewGenSemiMaxSize = (kWordSize <= 4) ? 8 : 16;
 // whenever timeline with perfetto support is included as well as in
 // precompiler builds (to enable stack dumping when precompiler crashes).
 #if !defined(PRODUCT) ||                                                       \
-    (defined(SUPPORT_TIMELINE) && defined(SUPPORT_PERFETTO)) ||                \
-    defined(DART_PRECOMPILER)
+    (defined(SUPPORT_TIMELINE) && defined(SUPPORT_PERFETTO))
 #define DART_INCLUDE_PROFILER 1
 #endif
 
+#if defined(DART_INCLUDE_PROFILER) || defined(DART_PRECOMPILER)
+#define DART_INCLUDE_STACK_DUMPER 1
+#endif
+
 // Include IL printer and disassembler functionality into non-PRODUCT builds,
 // in all AOT compiler builds or when forced.
 #if !defined(PRODUCT) || defined(DART_PRECOMPILER) ||                          \

runtime/vm/profiler.cc

@@ -70,7 +70,7 @@ DEFINE_FLAG(
     "the oldest ones. This flag itself does not enable the profiler; the "
     "profiler must be enabled separately, e.g. with --profiler.");
 
-#if defined(DART_INCLUDE_PROFILER)
+#if defined(DART_INCLUDE_STACK_DUMPER)
 ProfilerCounters Profiler::counters_ = {};
 
 static void DumpStackFrame(uword pc, uword fp, const char* name, uword offset) {
@@ -367,6 +367,7 @@ static bool ValidateThreadStackBounds(uintptr_t fp,
   return true;
 }
 
+#if defined(DART_INCLUDE_PROFILER)
 // Get |thread|'s stack boundary and verify that |sp| and |fp| are within
 // it. Return |false| if anything looks suspicious.
 static bool GetAndValidateThreadStackBounds(OSThread* os_thread,
@@ -410,6 +411,7 @@ static bool GetAndValidateThreadStackBounds(OSThread* os_thread,
 
   return ValidateThreadStackBounds(fp, sp, *stack_lower, *stack_upper);
 }
+#endif  // defined(DART_INCLUDE_PROFILER)
 
 static bool GetAndValidateCurrentThreadStackBounds(uintptr_t fp,
                                                    uintptr_t sp,
@@ -600,6 +602,9 @@ void Profiler::DumpStackTrace(uword sp, uword fp, uword pc, bool for_crash) {
 
   DumpCompilerState(thread);
 }
+#endif  // defined(DART_INCLUDE_STACK_DUMPER)
+
+#if defined(DART_INCLUDE_PROFILER)
 
 RelaxedAtomic<bool> Profiler::initialized_ = false;
 SampleBlockBuffer* Profiler::sample_block_buffer_ = nullptr;