Skip to content

Commit df5f902

Browse files
mralephCommit Queue
authored andcommitted
[vm] Fix product testing builds
Our product builds (used for testing) are setting dart_runtime_mode == "release", so we better align behavior of dart_product_config and dart_maybe_product_config in such case otherwise we create unexpected skew between artifacts and dartaotruntime which is used to compile them. In reality we should probably delete Product$ARCH build altogether because all necessary artifacts are actually part of Relase$ARCH builds anyway these days. TEST=Run vm-aot-dyn-linux-product-x64 tests Change-Id: Ifbc2b9679a666c9f22b289d6eb0b8b836a6a6964 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460040 Commit-Queue: Slava Egorov <vegorov@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
1 parent 633ed8f commit df5f902

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

runtime/BUILD.gn

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ config("dart_product_config") {
5151
"-fvisibility=hidden",
5252
]
5353
}
54+
if (dart_runtime_mode == "release" && target_os == "linux") {
55+
defines += [ "DART_DISABLE_TIMELINE" ]
56+
}
5457
}
5558
}
5659

0 commit comments

Comments
 (0)